Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1282369rwb; Fri, 19 Aug 2022 00:20:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR7mzeP6mxilUv8JAjoMamMh3ALsPLYzCdFILJy5F8VGO67iSMHpqq7jd1Fsilqo5nRhviSB X-Received: by 2002:aa7:d0d1:0:b0:445:e46f:3703 with SMTP id u17-20020aa7d0d1000000b00445e46f3703mr5161483edo.55.1660893628730; Fri, 19 Aug 2022 00:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660893628; cv=none; d=google.com; s=arc-20160816; b=H+ZQA+d80Is1ADPX5xduhZEnCYhY2G6NPgdEltWqL+swTtCyFhxTSuxiANMoyFft8h Qxwx0uFLKh359IpymHI7F0unxtwOsX0tRyY+wU880fjsksrfph6GOBK1FVYNRGPI4LKC eOqxHjMxqC4p6stSsNVZilD2zictWtoo45Cwtw4g4tMluRQgAB78wsyEdHvQDQz5lN50 dnr6ZSeHedldqyWaLoEK9FsFvWuCIAnISiZFs3QCE3PdqNExz33OX37RNK1ljHIuAI0l xOcEuaIiVwN74LusAK2xyYcrrgxYdAhdmZvwCV3oUTJUxhDTSXQT9Da1XVmbjiHHCNjn zX4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ogYWaoryFZGzPLUpZBdKNn7c/gmhvMKnaJ0BOTDxjOg=; b=sFHcWMCZdA3Ot/RRF0p3GC3ZwF7zaOkYOsmLHq08/6X20x6mbaABc2xKdf4vVf2rlb 6NKUC8bZcAS3Q5qxG3sG5Q8xbRs8vaPf5nECuWe77e5HrWPi70Agq6VLzoWI924QdHNj FUtkcCUWZE6As9rKKXfb+CC53QlBWuolItqKklIAbpL5z4L0eQvtOvyN98VpDu5AqTsD mgqlZMpzVR+FQcp9wOmh2d0BGrcTns5D8UuKJeQCQVo/XfHLGJKKxW7ea101CH2L9yBs hzXbtfCVx/dQjd8lhFhbJhlBXRt1uvueX8Q45Q/IyNGjWTUzX3ubzN3TzL4EkiTdeioT gVbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PdQnZ8kL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a50cd92000000b0043de558914asi2472155edi.487.2022.08.19.00.20.02; Fri, 19 Aug 2022 00:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PdQnZ8kL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346988AbiHSHGi (ORCPT + 99 others); Fri, 19 Aug 2022 03:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346847AbiHSHGh (ORCPT ); Fri, 19 Aug 2022 03:06:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE9AE1933 for ; Fri, 19 Aug 2022 00:06:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19BD2615FB for ; Fri, 19 Aug 2022 07:06:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21ABFC433D6; Fri, 19 Aug 2022 07:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660892795; bh=cp+vyEMTbv7YFDOX3ot15HLf44wWAWu4Pm5/zW002lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PdQnZ8kL1yciTjvliLlzLOGtXUUsCjz29FI3MhGF4VUTfa1x/N4Fg3jqxRS1ZL1EF Eani4mUsiDzs54ksizqaDBqcUg4flri5rpCfr80Gv8IIoGWHdqMNrcInzbcBLLdj8J 8Pk/IscJbXNF1KX1PXVLgVVnuX48EWdZdvzS+YI4= Date: Fri, 19 Aug 2022 09:06:27 +0200 From: Greg KH To: Abhishek Shah Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org, bjohannesmeyer@gmail.com, jakobkoschel@gmail.com, xiam0nd.tong@gmail.com, Gabriel Ryan Subject: Re: data-race in set_console / vt_ioctl Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2022 at 09:17:00PM -0400, Abhishek Shah wrote: > Hi all, > > We found a data race involving the *vt_dont_switch* variable. Upon further > investigation, we see that this racing variable controls whether the > callbacks will be scheduled in the console (see here > ), > but we are not sure of its security implications. Please let us know what > you think. Again, any patch that you might have to resolve this would be great, as that's the easiest thing to review. thanks, greg k-h