Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1319406rwb; Fri, 19 Aug 2022 01:14:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR5on4WyhUHJJx0kO0XEOpklJJ6hfsJuprKH8hhCYAHr4kfP4moQ528h9VwW9lcQB/6HW4ZG X-Received: by 2002:a17:907:970b:b0:732:f76a:97a2 with SMTP id jg11-20020a170907970b00b00732f76a97a2mr4278680ejc.396.1660896873126; Fri, 19 Aug 2022 01:14:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660896873; cv=none; d=google.com; s=arc-20160816; b=n1hOoz6cjq2e/9ynFhIAayBYmM2wJqZ3Lavc+Fku3ZLOQrHffgE+Y9LYqOBCJNwsYr hwR5g82H5eMZqJ6kWnJr7KI6ohQ7v07yA0v5CmlLaN6Va76723Up8yDChUv1LtNrZExr aKotp3goeTrVbHpCYBBTp9J/PuQLyYQXeaPLTTBDE2CWBeNK1PZyBWmeUFKnngdqei6K pddkhogqj5BNwC78IqHTuOdvqhLciV0Hu8aS1bGeIrMh8TjDfhk61b4HoGAD3MxN6PJb kJ4Gmq1AMbTLFmm6nQa7s1yJjb6X0WEGpkA+BXdmq8Hm0wgdYnqfeol9z5BOqsmzvqbh CKeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cyh9GNwkSeiWX8VVWJet6cmrStrv1Y1BhHYKMAKCy08=; b=rn5uLQCCYOvizTQ/0RWHgXqFW3J1/HqOAJhXomVLNetfhZ80EXhbcUcBBfyF3bJQmo YZMM8vR1T7oFOK/xjQKir5u+ZEle0Mvy2+bEcpt+3O4tari9yEky/pfm2YCEz7Zg8XlP yaeYaQ5B25zak26pmDhHz2WE9zNFNleM+Gh6H6cFui3r2e4CAyIPMoxb4ujj/HTolr61 jwh/I2ADLU0lOLdwc5A3QPZNEvC294gp5qsgAOoK+GluqG5zokOhddD01i2ZurJDWK5p d/UhnCZuX4M2CUg/Yj5fc0IfyAryzVpA3bSFkzzj4faLKX/kaQ5JGKU2dkFZeR/tnaGO 9t4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Mbf+/6gN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs43-20020a1709072d2b00b00730928be67asi3045574ejc.675.2022.08.19.01.14.07; Fri, 19 Aug 2022 01:14:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Mbf+/6gN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347360AbiHSIAh (ORCPT + 99 others); Fri, 19 Aug 2022 04:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347225AbiHSIAb (ORCPT ); Fri, 19 Aug 2022 04:00:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32065DFB5A for ; Fri, 19 Aug 2022 01:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660896029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cyh9GNwkSeiWX8VVWJet6cmrStrv1Y1BhHYKMAKCy08=; b=Mbf+/6gNvw/GGH06KxHHpl8Qm1UTNN9a4ePYnJIfkWlCfcFwxmIqCIiYnsoG7ozwtpBAim 8OuDDtMOMbvEDXID/X8Ls2L0FWwgKMOeQNRfUDBL8tif4tVgUWBzt9Y54S2Np14S0LGFMr cbOPe8s8bTRF9nFXJtQcjVol9AHBhMo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-472-bnpzuPYKOIyzKT_4YXZnTw-1; Fri, 19 Aug 2022 04:00:27 -0400 X-MC-Unique: bnpzuPYKOIyzKT_4YXZnTw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 946A1101A54E; Fri, 19 Aug 2022 08:00:27 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDF4C2026985; Fri, 19 Aug 2022 08:00:23 +0000 (UTC) From: Paolo Bonzini To: Li kunyu Cc: seanjc@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH v2] KVM: Drop unnecessary initialization of "ops" in kvm_ioctl_create_device() initialized and assigned, it is used after assignment Date: Fri, 19 Aug 2022 04:00:23 -0400 Message-Id: <20220819080023.2328382-1-pbonzini@redhat.com> In-Reply-To: <20220819021535.483702-1-kunyu@nfschina.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Queued, thanks. Paolo