Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hu, Robert" <robert.hu@intel.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>
CC:     "x86@kernel.org" <x86@kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zhang, Weihong" <weihong.zhang@intel.com>
Subject: RE: [PATCHv6 09/11] selftests/x86/lam: Add mmap and SYSCALL test
 cases for linear-address masking
Thread-Topic: [PATCHv6 09/11] selftests/x86/lam: Add mmap and SYSCALL test
 cases for linear-address masking
Thread-Index: AQHYsF3oJDX/VqQwxkuwP50rjb2Iwq215fvQ
Date:   Fri, 19 Aug 2022 08:15:13 +0000
Message-ID: <CY5PR11MB6187230204E669607437716FE06C9@CY5PR11MB6187.namprd11.prod.outlook.com>
References: <20220815041803.17954-1-kirill.shutemov@linux.intel.com>
 <20220815041803.17954-10-kirill.shutemov@linux.intel.com>
In-Reply-To: <20220815041803.17954-10-kirill.shutemov@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q0EJxKzGPq8ilvE90bQ5AFB7wQF9TsrUa7melLsCABKrR7Ke4DOrMv6Dsz6p?=
 =?us-ascii?Q?tb6EBKu2s8TTdizJ5zu4KK6eXXnBFDbAQYXrbP9CibdRpFZj9E6IjDXTVr08?=
 =?us-ascii?Q?3cUvUMfneaZNGWBTm/rbFN0nU/ET+H4bCN7CihV0ZkIRJT69Vo7RzLp9lkQi?=
 =?us-ascii?Q?R6G1DNo0L9dHrfMG9zr1mGqSp8R7yxTfI6da7c7uhco5yg6AYWVW9ZGN6Brt?=
 =?us-ascii?Q?AIxrpIvN0elte9jQ3BeKqXNo2CHsLn6T9BTyMN6qERfBW7zAgzOVLwm+FrGo?=
 =?us-ascii?Q?+4MoFAvpGQmgcYp5rHiCfwMNktOoLKGzf0j9e5b0REFA3aKY/49OgaUQaMCh?=
 =?us-ascii?Q?6Qi9ho0bVTm3CoaKqN/K1717uv1NbmM9d6/cGUsmxX3rax5GlCFiAwhZlabk?=
 =?us-ascii?Q?NZmy165RmQNWyfmlFDoZSsYzc49dqf7XwWiJGsUf50hLPQzC30jVbUJFqPmZ?=
 =?us-ascii?Q?kUZe3Yi9m08UfMaIS3ZQ9Ms3EkELmu9FqA6r3P0xV/m97iUhM5td5p3eF5/L?=
 =?us-ascii?Q?oBZw/etijnPZ3uvPfhYzhlvwRx3uzykS8tG0tClSKfjecW4Y1t53NR0QcxG1?=
 =?us-ascii?Q?j1A1i1/p4hI6EhaVwB28GD26BVOzMf64THmbro6X5thlMheRx9zgA5p14J2x?=
 =?us-ascii?Q?JQ2C6xqznbxckKEsXiH6jMoxHPXMYD3JAGnVtElBQKowWfdPWsZOQxZEotE8?=
 =?us-ascii?Q?dHsxpKKXlgcKYSSLzGIPV8xR3MzqD+2kz3S42RsVDmWvFPMYYLRjAEO/bhbk?=
 =?us-ascii?Q?s6PF5IYKzmkapwXG2mJDk+lP2PBixJI8GmQHVabNHpD2ge1Bx9CuU/Jx1Pjz?=
 =?us-ascii?Q?nKwsxQXUl4C5FEMGkexpTB6XGnP8a08uWxWWcJIJBt8vmtHMOWOld1S5gNCD?=
 =?us-ascii?Q?KcHHv0ZI7GSTJMVVMQW9dZfSkCy8yJBAg7D9dfEKuTg+RlLXQhuaplNyfr9p?=
 =?us-ascii?Q?4sPyvvzMoSlZhOKMT/4Zvd+Uf4BcLdx/3qiKdVXTb5nWus6mSnh3PB4qfZIX?=
 =?us-ascii?Q?EDDp3Kqn6L0W8qVEwbf2Lar/3W5SqOP/ashv922nI1Le2aPgo2L5QNom38Jd?=
 =?us-ascii?Q?jB+9poV0DryM3havU5fRby/YBKbE5d4uRcBoXeKUPUkiJ5GeqMlgIztvCOeH?=
 =?us-ascii?Q?EdK1YPtWH5+sHrywZhmn567ZA8RZEARyzz1tNpE3vSDd4xfz0X3VzhvKStiR?=
 =?us-ascii?Q?MX8r3Mw563A5wxzDZK04Ujve9UPGXusIUQWD3Q5lyVC3unFNrrHS1Kt9NHJw?=
 =?us-ascii?Q?6DQJ+pMu79cLzD0nl4y+hJOMqqHmiA1mjjXOohrkwKBHzAyp+PZqVaLxi0/+?=
 =?us-ascii?Q?GN0aRVLvZ6n9YRCUpuA4vXdb2O1ACFInhiPVOCoKChsUduLg9pQhZ6mzHo/h?=
 =?us-ascii?Q?Z253BY9VUVW/ahyPcrGIQ/X9spsGu1LnF2LxHWtdxAyRAleKw+Ij/2b7cSul?=
 =?us-ascii?Q?4PszvOdh9b5gONAU/BliadKxtsbOcQSkD7fW61Pkk1/07feb7xVC7VAZN88S?=
 =?us-ascii?Q?2aO2P0LfPfoRUDhgzikDx4BnEaljV+seQTFwW3G+lj7lsU6q63Y1D8Xk2P/o?=
 =?us-ascii?Q?+4tFCkjE36u38LxTpa/DWHRqEjDNxSTKJw/Bb80M?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6187.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b675945c-81fa-4704-02bd-08da81baf15c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2022 08:15:13.9117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: an3piKYPnpGwEuJHryck5Zq1HaHdpzqmw9ogcOn9anC4ETma862peF/d2cTcWMhkqA489vMzrABKxP+FokJVuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3912
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Sent: Monday, August 15, 2022 12:18
> To: Dave Hansen <dave.hansen@linux.intel.com>; Lutomirski, Andy
> <luto@kernel.org>; Peter Zijlstra <peterz@infradead.org>
> Cc: x86@kernel.org; Kostya Serebryany <kcc@google.com>; Andrey Ryabinin
> <ryabinin.a.a@gmail.com>; Andrey Konovalov <andreyknvl@gmail.com>;
> Alexander Potapenko <glider@google.com>; Taras Madan
> <tarasmadan@google.com>; Dmitry Vyukov <dvyukov@google.com>; H . J . Lu
> <hjl.tools@gmail.com>; Andi Kleen <ak@linux.intel.com>; Edgecombe, Rick P
> <rick.p.edgecombe@intel.com>; linux-mm@kvack.org; linux-
> kernel@vger.kernel.org; Zhang, Weihong <weihong.zhang@intel.com>; Kirill =
A .
> Shutemov <kirill.shutemov@linux.intel.com>
> Subject: [PATCHv6 09/11] selftests/x86/lam: Add mmap and SYSCALL test
> cases for linear-address masking
>=20
> From: Weihong Zhang <weihong.zhang@intel.com>
>=20
> Add mmap and SYSCALL test cases.
>=20
> SYSCALL test cases:
>=20
>  - LAM supports set metadata in high bits 62:57 (LAM_U57) of a user point=
er,
> pass
>    the pointer to SYSCALL, SYSCALL can dereference the pointer and return
> correct
>    result.
>=20
>  - Disable LAM, pass a pointer with metadata in high bits to SYSCALL,
>    SYSCALL returns -1 (EFAULT).
>=20
> MMAP test cases:
>=20
>  - Enable LAM_U57, MMAP with low address (below bits 47), set metadata
>    in high bits of the address, dereference the address should be
>    allowed.
>=20
>  - Enable LAM_U57, MMAP with high address (above bits 47), set metadata
>    in high bits of the address, dereference the address should be
>    allowed.
>=20
> Signed-off-by: Weihong Zhang <weihong.zhang@intel.com>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  tools/testing/selftests/x86/lam.c | 135 +++++++++++++++++++++++++++++-
>  1 file changed, 132 insertions(+), 3 deletions(-)
>=20
> diff --git a/tools/testing/selftests/x86/lam.c b/tools/testing/selftests/=
x86/lam.c
> index 4c6c6dbf7db6..e9e92ab7fea8 100644
> --- a/tools/testing/selftests/x86/lam.c
> +++ b/tools/testing/selftests/x86/lam.c
> @@ -7,6 +7,7 @@
>  #include <signal.h>
>  #include <setjmp.h>
>  #include <sys/mman.h>
> +#include <sys/utsname.h>
>  #include <sys/wait.h>
>  #include <inttypes.h>
>=20
> @@ -27,11 +28,18 @@
>  /* Specified test function bits */
>  #define FUNC_MALLOC             0x1
>  #define FUNC_BITS               0x2
> +#define FUNC_MMAP               0x4
> +#define FUNC_SYSCALL            0x8
>=20
> -#define TEST_MASK               0x3
> +#define TEST_MASK               0xf
> +
> +#define LOW_ADDR                (0x1UL << 30)
> +#define HIGH_ADDR               (0x3UL << 48)
>=20
>  #define MALLOC_LEN              32
>=20
> +#define PAGE_SIZE               (4 << 10)
> +
>  struct testcases {
>  	unsigned int later;
>  	int expected; /* 2: SIGSEGV Error; 1: other errors */ @@ -47,6 +55,7
> @@ jmp_buf segv_env;  static void segv_handler(int sig)  {
>  	ksft_print_msg("Get segmentation fault(%d).", sig);
> +
>  	siglongjmp(segv_env, 1);
>  }
>=20
> @@ -59,6 +68,16 @@ static inline int cpu_has_lam(void)
>  	return (cpuinfo[0] & (1 << 26));
>  }
>=20
> +/* Check 5-level page table feature in CPUID.(EAX=3D07H,
> +ECX=3D00H):ECX.[bit 16] */ static inline int cpu_has_la57(void) {
> +	unsigned int cpuinfo[4];
> +
> +	__cpuid_count(0x7, 0, cpuinfo[0], cpuinfo[1], cpuinfo[2], cpuinfo[3]);
> +
> +	return (cpuinfo[2] & (1 << 16));
> +}
> +
>  /*
>   * Set tagged address and read back untag mask.
>   * check if the untagged mask is expected.
> @@ -204,6 +223,68 @@ static int handle_malloc(struct testcases *test)
>  	return ret;
>  }
>=20
> +static int handle_mmap(struct testcases *test) {
> +	void *ptr;
> +	unsigned int flags =3D MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED;
> +	int ret =3D 0;
> +
> +	if (test->later =3D=3D 0 && test->lam !=3D 0)
> +		if (set_lam(test->lam) !=3D 0)
> +			return 1;
> +
> +	ptr =3D mmap((void *)test->addr, PAGE_SIZE, PROT_READ |
> PROT_WRITE,
> +		   flags, -1, 0);
> +	if (ptr =3D=3D MAP_FAILED) {
> +		if (test->addr =3D=3D HIGH_ADDR)
> +			if (!cpu_has_la57())
> +				return 3; /* unsupport LA57 */
> +		return 1;
> +	}
> +
> +	if (test->later !=3D 0 && test->lam !=3D 0)
> +		if (set_lam(test->lam) !=3D 0)
> +			ret =3D 1;
> +
> +	if (ret =3D=3D 0) {
> +		if (sigsetjmp(segv_env, 1) =3D=3D 0) {
> +			signal(SIGSEGV, segv_handler);
> +			ret =3D handle_lam_test(ptr, test->lam);
> +		} else {
> +			ret =3D 2;
> +		}
> +	}
> +
> +	munmap(ptr, PAGE_SIZE);
> +	return ret;
> +}
> +
> +static int handle_syscall(struct testcases *test) {
> +	struct utsname unme, *pu;
> +	int ret =3D 0;
> +
> +	if (test->later =3D=3D 0 && test->lam !=3D 0)
> +		if (set_lam(test->lam) !=3D 0)
> +			return 1;
> +
> +	if (sigsetjmp(segv_env, 1) =3D=3D 0) {
> +		signal(SIGSEGV, segv_handler);
> +		pu =3D (struct utsname *)get_metadata((uint64_t)&unme, test-
> >lam);
> +		ret =3D uname(pu);
> +		if (ret < 0)
> +			ret =3D 1;
> +	} else {
> +		ret =3D 2;
> +	}
> +
> +	if (test->later !=3D 0 && test->lam !=3D 0)
> +		if (set_lam(test->lam) !=3D -1 && ret =3D=3D 0)
> +			ret =3D 1;
> +
> +	return ret;
> +}
> +
>  static int fork_test(struct testcases *test)  {
>  	int ret, child_ret;
> @@ -259,7 +340,6 @@ static struct testcases malloc_cases[] =3D {
>  	},
>  };
>=20
> -
>  static struct testcases bits_cases[] =3D {
>  	{
>  		.test_func =3D handle_max_bits,
> @@ -267,11 +347,54 @@ static struct testcases bits_cases[] =3D {
>  	},
>  };
>=20
> +static struct testcases syscall_cases[] =3D {
> +	{
> +		.later =3D 0,
> +		.lam =3D LAM_U57_BITS,
> +		.test_func =3D handle_syscall,
> +		.msg =3D "SYSCALL: LAM_U57. syscall with metadata\n",
> +	},
> +	{
> +		.later =3D 1,
> +		.expected =3D 1,
> +		.lam =3D LAM_U57_BITS,
> +		.test_func =3D handle_syscall,
> +		.msg =3D "SYSCALL:[Negtive] Disable LAM. Dereferencing pointer
[Hu, Robert]=20
Trivial, Negtive --> Negative.

> with metadata.\n",
> +	},
> +};
> +
> +static struct testcases mmap_cases[] =3D {
[Hu, Robert]=20
Can mmap also have negative case?

> +	{
> +		.later =3D 1,
> +		.expected =3D 0,
> +		.lam =3D LAM_U57_BITS,
> +		.addr =3D HIGH_ADDR,
> +		.test_func =3D handle_mmap,
> +		.msg =3D "MMAP: First mmap high address, then set
> LAM_U57.\n",
> +	},
> +	{
> +		.later =3D 0,
> +		.expected =3D 0,
> +		.lam =3D LAM_U57_BITS,
> +		.addr =3D HIGH_ADDR,
> +		.test_func =3D handle_mmap,
> +		.msg =3D "MMAP: First LAM_U57, then High address.\n",
> +	},
> +	{
> +		.later =3D 0,
> +		.expected =3D 0,
> +		.lam =3D LAM_U57_BITS,
> +		.addr =3D LOW_ADDR,
> +		.test_func =3D handle_mmap,
> +		.msg =3D "MMAP: First LAM_U57, then Low address.\n",
> +	},
> +};
> +
>  static void cmd_help(void)
>  {
>  	printf("usage: lam [-h] [-t test list]\n");
>  	printf("\t-t test list: run tests specified in the test list, default:0=
x%x\n",
> TEST_MASK);
> -	printf("\t\t0x1:malloc; 0x2:max_bits;\n");
> +	printf("\t\t0x1:malloc; 0x2:max_bits; 0x4:mmap; 0x8:syscall.\n");
>  	printf("\t-h: help\n");
>  }
>=20
> @@ -311,6 +434,12 @@ int main(int argc, char **argv)
>  	if (tests & FUNC_BITS)
>  		run_test(bits_cases, ARRAY_SIZE(bits_cases));
>=20
> +	if (tests & FUNC_MMAP)
> +		run_test(mmap_cases, ARRAY_SIZE(mmap_cases));
> +
> +	if (tests & FUNC_SYSCALL)
> +		run_test(syscall_cases, ARRAY_SIZE(syscall_cases));
> +
>  	ksft_set_plan(tests_cnt);
>=20
>  	return ksft_exit_pass();
> --
> 2.35.1