Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a128efb7-ae33-59c1-cc32-8893c2af897a@intel.com>
Date:   Fri, 19 Aug 2022 16:39:12 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH 3/8] memblock tests: add labels to verbose output for
 generic alloc tests
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>
CC:     Mike Rapoport <rppt@kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>,
        David Hildenbrand <david@redhat.com>
References: <cover.1660454730.git.remckee0@gmail.com>
 <d4d2a848668f92dbea697402eeaced3a9c7785ba.1660454730.git.remckee0@gmail.com>
 <63e9e964-021e-e141-00f8-afd7feb774fb@intel.com>
 <20220816023951.GB3590@sophie>
 <03f8614e-2bd7-afa8-6744-14397cbc9cb1@intel.com>
 <20220819050358.GA3930@sophie>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <20220819050358.GA3930@sophie>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2dOaG9lN05PcjRRaXdNVTBmdTNqb3ltK1diYno1VTAxTHpvTGQ3Tk9MZVZM?=
 =?utf-8?B?TnN0M1YxR1ppbk9uVHQ5TjJ0UE5LVmVlaGM4Q0Joa3VXTGZ4RWhKRXpHTEd6?=
 =?utf-8?B?dHByelE2Q1o0b08zaUlRTXRhelJDOWU0NjhvZSs0U1hQSVJqVElYdEVseFB0?=
 =?utf-8?B?TTNaUDZ4NWFrRFFMd2hOZElGQ0RBVFByTkN0ZmZKOXFpSUt5Q0t2ZzY1VUxW?=
 =?utf-8?B?Zm5DUjZncW9ONGdlQjE1Y3o5bFhKYVNudmY5bGJXV24wVC9aSU1zWEwrTTlW?=
 =?utf-8?B?Y0hMYzJIQTdmOGJLSWRQL0xhYW1XOHdWWXNhSU53UlpaYWdJN2phRFFxcGFS?=
 =?utf-8?B?TnJocHpHL2ZUbVBJRGQzM3FBclRoVjVVWGhETmwxajhaOUZWZHlrSDQ3QTBi?=
 =?utf-8?B?REtCRTVuZHJEb0pSYUVjSU1odEZsVTZwTFBiQndIUDc1MnhSb2QveXI2MVFr?=
 =?utf-8?B?NElSeElhRkh4YkNnSklwcTZITXAzOWNoS0RLWHpVYzMxaVVRY1E0bGFYem9G?=
 =?utf-8?B?YVdNb2dwc3JZVWc2SGtXVk5IU3VqcVdIaDFKRVo1NGZPcUd0Qm1xVU05NjNO?=
 =?utf-8?B?ajczcWZacWJiQ3ZyTXNwNXdoRkJPRGMwQTBsRFQvcTM1NXVUcmVEN0hoakEz?=
 =?utf-8?B?UWdGZVhNenhwRTdBbStHc2t2dG5abjBGdG0wdENIcUhtbUZJbXRBK1lzNk1W?=
 =?utf-8?B?QTExdTlIdWFiSm5Ea2VDV09RL1RpcmlRMSszYUFDeHhmVk5ESk9YZ3Q1S3pn?=
 =?utf-8?B?REVad1QrTzFrZXdCTzBrYzJiSUNlc3gxV01FQzJiQzhiUzJkNHFOalVEaVZF?=
 =?utf-8?B?KzR4S1EzZjhCQThzLzR5c0FwNUFjN2ZNRDVoOTNVOUUxV29XMk1QMEdkNkdR?=
 =?utf-8?B?Sm9DV05UdVNWdWhLRWZ1RUZmb0dFRHlXenR2UGpJa0lTdW5RMGFZUjNCdis0?=
 =?utf-8?B?VXpxY2x6V01LeGxKWGI2S2E1WjJwcmlNR0lCc0ZDRk1SV3Fhb2U4WXJCem00?=
 =?utf-8?B?SGFSMDhHclliMEp5S3d2ODkyRTNhMUVhNnBrZzdjd0JUakZMalljeUFycUNC?=
 =?utf-8?B?Sy9TeStvcEhmRWN2ZUgyN1dSQmRwaEpKazFENXhBUnhaSGk0c3lkeGR2aThl?=
 =?utf-8?B?b3lvSUU0cWdOWk9KMHEzS0pPUk93SXdxbHl0a3czRFZQV2V6L0JhWlN6RkZD?=
 =?utf-8?B?MzliMWs0YkIwQlNFNExKVk5vRWhTbWh6aUhjOFQ5MHBPQ3VzMzN1cjZ2Nm0z?=
 =?utf-8?B?cUpyY1ppNzN6WktzQW9kZTdRckVaRUFaakpRbEVITjduMEhlRFAwSSsrSHRM?=
 =?utf-8?B?L2NnYUprZU9oeXc3Y0gxMkNXdi9RWE5jZ1U4QUFzbTNPMXNlVjA5RzY0NU5I?=
 =?utf-8?B?QU9BK1haT0tIR2pEaUpiWTR1MFp5Y3hlL1E3S2s4Z1kvU2ttQndObUJQblRm?=
 =?utf-8?B?d0I4Tkp2TGN0ZU0yRzE2cnM3ZlJJWmVScjY5QVZ2bDVIamdKK0tRUzl5eWtF?=
 =?utf-8?B?SnFsdjlveUlKc3JzdkV2ZzAvYnU5TU10MUhQdVhHS29xUUVTY2hHV01CRU9l?=
 =?utf-8?B?MjMyNkp2Wm1OTGhuVGJaVWpoSi9ZTm5kVmd5MXdSaDRnT2d2TWhMazd2MlEw?=
 =?utf-8?B?WGU3QlA4TVkwbmQ4K25ta2xQZ3ZUMXYrbnNXMTd4cnFyYk1oVVlSQzliZjQ3?=
 =?utf-8?B?M0tiTEdrd1ZSOGdQQy80dFJqS2xYM21RY2ZyVFJPamR5K0JNL0RHbGNKc0t0?=
 =?utf-8?B?M3J2aEoyL0pvQ2UyQUhLVnFENTBVais5Zm50aG5pRlQxbW5pYkt6VmhjakFF?=
 =?utf-8?B?M1ltT0t5VW5abEJaWDViclVRcUtzMzRad081Wkc4VnFxdnZIOGNnK3BxRVUz?=
 =?utf-8?B?NzRoK0dubVRYazdtblVBK2RCT2l2WEFsNnV0aTcvZW0xMFJ4ZW9zQks1MFF6?=
 =?utf-8?B?c1FpaGhRUGlwSzdXV3RTem5SQTBDbTRBVktlZm1qcjJmTzJqYlVwbEp5UGxy?=
 =?utf-8?B?bnRGTVJjRVN3ejlJeEUvbVBsU0RKdUVoNXNLSTVGMGVkMUk4WUoxTms0WTRz?=
 =?utf-8?B?ZFloNzFYWWNmb3BxUktjc2dPWFZoNmEvaCtab0dXMjUwYjR1Q0EvYXRHUEFx?=
 =?utf-8?B?TlQza0ZpKytOZmtZRE1CaVhuUjFWbTd4TFdXUUJ5c1R1bXZvS1NrLzVGYVox?=
 =?utf-8?B?ZFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02b901dc-625d-42f2-fbed-08da81be506f
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 08:39:22.4163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tfBpnvRXzkETw/OmmPR5zfPx3wjgcQaeBBAvPBhgOy5bCtDlh7/x967JInrHpobFX+JpZCfygghphUu8bUHK7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5402
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/19/2022 1:03 PM, Rebecca Mckeever wrote:
> On Tue, Aug 16, 2022 at 11:08:44AM +0800, Huang, Shaoqin wrote:
>>
>>
>> On 8/16/2022 10:39 AM, Rebecca Mckeever wrote:
>>> On Mon, Aug 15, 2022 at 05:15:47PM +0800, Huang, Shaoqin wrote:
>>>> I found original some of test function has the prefix `top_down` and
>>>> `bottom_up`, and some of test function didn't have the prefix.
>>>>
>>>> In this patch, it just modified these functions which didn't have the prefix
>>>> `top_down` or `bottom_up`, and now there are two style about these test
>>>> functions in the code.
>>>>
>>>> One is:
>>>> 	run_top_down(alloc_in_between_generic_check);
>>>> 	run_bottom_up(alloc_in_between_generic_check);
>>>>
>>>> Another one is:
>>>> 	memblock_set_bottom_up(false);
>>>> 	alloc_top_down_before_check();
>>>> 	memblock_set_bottom_up(true);
>>>> 	alloc_bottom_up_before_check();
>>>>
>>>> Thus there gonna be two output style, here is an example:
>>>> ok 89 : memblock_alloc_from: top-down: alloc_from_simple_generic_check:
>>>> passed
>>>> ok 90 : memblock_alloc_from: bottom-up: alloc_from_simple_generic_check:
>>>> passed
>>>>
>>>> ok 99 : memblock_alloc_try_nid: alloc_try_nid_top_down_simple_check: passed
>>>> ok 100 : memblock_alloc_try_nid: alloc_try_nid_bottom_up_simple_check:
>>>> passed
>>>>
>>>> It may make confuse if one is printed between the colon and one is inside
>>>> the function name.
>>>>
>>>> So maybe make the style consistent is more make sense. And I think this can
>>>> be done by modify all these function name which with `top_down` and
>>>> `bottom_up` inside, and replace them with your new run_top_down() and
>>>> run_bottom_up() functions.
>>>>
>>> So you're saying use run_top_down() and run_bottom_up() even for functions
>>> with `top_down` and `bottom_up` in the name, but don't change the names?
>>>
>>
>> Yes. We can't delete these `top_down` and `bottom_up` in the name and makes
>> two functions to have the same name. Due to these functions with `top_down`
>> and `bottom_up` have different implementation.
>>
>> If use run_top_down() and run_bottom_up() for these functions. We can get
>> the consistent output style, but a little redundant output(Maybe this isn't
>> a good idea).
>>
> Yes, I think the output would be too redundant. Even though there are
> two different output styles, the style is consistent within each pair of
> tests. So there is at least a consistent pattern.
> 

Ok. Just keep the current implementation is fine.

>>>> On 8/14/2022 1:53 PM, Rebecca Mckeever wrote:
>>>>> Generic tests for memblock_alloc*() functions do not use separate
>>>>> functions for testing top-down and bottom-up allocation directions.
>>>>> Therefore, the function name that is displayed in the verbose testing
>>>>> output does not include the allocation direction.
>>>>>
>>>>> Add an additional prefix when running generic tests for
>>>>> memblock_alloc*() functions that indicates which allocation direction is
>>>>> set. The prefix will be displayed when the tests are run in verbose mode.
>>>>>
>>>>> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
>>>>> ---
>>>>>     tools/testing/memblock/tests/alloc_api.c      | 36 +++++++------------
>>>>>     .../memblock/tests/alloc_helpers_api.c        | 12 +++----
>>>>>     tools/testing/memblock/tests/alloc_nid_api.c  | 36 +++++++------------
>>>>>     tools/testing/memblock/tests/common.h         | 16 +++++++++
>>>>>     4 files changed, 44 insertions(+), 56 deletions(-)
>>>>>
>>>>> diff --git a/tools/testing/memblock/tests/alloc_api.c b/tools/testing/memblock/tests/alloc_api.c
>>>>> index 71c89cb9b2a8..73c2c43e702a 100644
>>>>> --- a/tools/testing/memblock/tests/alloc_api.c
>>>>> +++ b/tools/testing/memblock/tests/alloc_api.c
>>>>> @@ -752,10 +752,8 @@ static int alloc_after_check(void)
>>>>>     static int alloc_in_between_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_in_between_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_in_between_generic_check();
>>>>> +	run_top_down(alloc_in_between_generic_check);
>>>>> +	run_bottom_up(alloc_in_between_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -774,10 +772,8 @@ static int alloc_second_fit_check(void)
>>>>>     static int alloc_small_gaps_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_small_gaps_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_small_gaps_generic_check();
>>>>> +	run_top_down(alloc_small_gaps_generic_check);
>>>>> +	run_bottom_up(alloc_small_gaps_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -785,10 +781,8 @@ static int alloc_small_gaps_check(void)
>>>>>     static int alloc_all_reserved_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_all_reserved_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_all_reserved_generic_check();
>>>>> +	run_top_down(alloc_all_reserved_generic_check);
>>>>> +	run_bottom_up(alloc_all_reserved_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -796,10 +790,8 @@ static int alloc_all_reserved_check(void)
>>>>>     static int alloc_no_space_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_no_space_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_no_space_generic_check();
>>>>> +	run_top_down(alloc_no_space_generic_check);
>>>>> +	run_bottom_up(alloc_no_space_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -807,10 +799,8 @@ static int alloc_no_space_check(void)
>>>>>     static int alloc_limited_space_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_limited_space_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_limited_space_generic_check();
>>>>> +	run_top_down(alloc_limited_space_generic_check);
>>>>> +	run_bottom_up(alloc_limited_space_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -818,10 +808,8 @@ static int alloc_limited_space_check(void)
>>>>>     static int alloc_no_memory_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_no_memory_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_no_memory_generic_check();
>>>>> +	run_top_down(alloc_no_memory_generic_check);
>>>>> +	run_bottom_up(alloc_no_memory_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> diff --git a/tools/testing/memblock/tests/alloc_helpers_api.c b/tools/testing/memblock/tests/alloc_helpers_api.c
>>>>> index 796527cf3bd2..1ccf02639ad6 100644
>>>>> --- a/tools/testing/memblock/tests/alloc_helpers_api.c
>>>>> +++ b/tools/testing/memblock/tests/alloc_helpers_api.c
>>>>> @@ -357,10 +357,8 @@ static int alloc_from_bottom_up_min_addr_cap_check(void)
>>>>>     static int alloc_from_simple_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_from_simple_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_from_simple_generic_check();
>>>>> +	run_top_down(alloc_from_simple_generic_check);
>>>>> +	run_bottom_up(alloc_from_simple_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -368,10 +366,8 @@ static int alloc_from_simple_check(void)
>>>>>     static int alloc_from_misaligned_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_from_misaligned_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_from_misaligned_generic_check();
>>>>> +	run_top_down(alloc_from_misaligned_generic_check);
>>>>> +	run_bottom_up(alloc_from_misaligned_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> diff --git a/tools/testing/memblock/tests/alloc_nid_api.c b/tools/testing/memblock/tests/alloc_nid_api.c
>>>>> index 71b7beb35526..82fa8ea36320 100644
>>>>> --- a/tools/testing/memblock/tests/alloc_nid_api.c
>>>>> +++ b/tools/testing/memblock/tests/alloc_nid_api.c
>>>>> @@ -1142,10 +1142,8 @@ static int alloc_try_nid_cap_min_check(void)
>>>>>     static int alloc_try_nid_min_reserved_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_min_reserved_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_min_reserved_generic_check();
>>>>> +	run_top_down(alloc_try_nid_min_reserved_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_min_reserved_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -1153,10 +1151,8 @@ static int alloc_try_nid_min_reserved_check(void)
>>>>>     static int alloc_try_nid_max_reserved_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_max_reserved_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_max_reserved_generic_check();
>>>>> +	run_top_down(alloc_try_nid_max_reserved_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_max_reserved_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -1164,10 +1160,8 @@ static int alloc_try_nid_max_reserved_check(void)
>>>>>     static int alloc_try_nid_exact_address_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_exact_address_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_exact_address_generic_check();
>>>>> +	run_top_down(alloc_try_nid_exact_address_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_exact_address_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -1175,10 +1169,8 @@ static int alloc_try_nid_exact_address_check(void)
>>>>>     static int alloc_try_nid_reserved_full_merge_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_reserved_full_merge_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_reserved_full_merge_generic_check();
>>>>> +	run_top_down(alloc_try_nid_reserved_full_merge_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_reserved_full_merge_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -1186,10 +1178,8 @@ static int alloc_try_nid_reserved_full_merge_check(void)
>>>>>     static int alloc_try_nid_reserved_all_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_reserved_all_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_reserved_all_generic_check();
>>>>> +	run_top_down(alloc_try_nid_reserved_all_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_reserved_all_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> @@ -1197,10 +1187,8 @@ static int alloc_try_nid_reserved_all_check(void)
>>>>>     static int alloc_try_nid_low_max_check(void)
>>>>>     {
>>>>>     	test_print("\tRunning %s...\n", __func__);
>>>>> -	memblock_set_bottom_up(false);
>>>>> -	alloc_try_nid_low_max_generic_check();
>>>>> -	memblock_set_bottom_up(true);
>>>>> -	alloc_try_nid_low_max_generic_check();
>>>>> +	run_top_down(alloc_try_nid_low_max_generic_check);
>>>>> +	run_bottom_up(alloc_try_nid_low_max_generic_check);
>>>>>     	return 0;
>>>>>     }
>>>>> diff --git a/tools/testing/memblock/tests/common.h b/tools/testing/memblock/tests/common.h
>>>>> index 7a16a7dc8f2c..e0dd5b410099 100644
>>>>> --- a/tools/testing/memblock/tests/common.h
>>>>> +++ b/tools/testing/memblock/tests/common.h
>>>>> @@ -101,4 +101,20 @@ static inline void test_pass_pop(void)
>>>>>     	prefix_pop();
>>>>>     }
>>>>> +static inline void run_top_down(int (*func)())
>>>>> +{
>>>>> +	memblock_set_bottom_up(false);
>>>>> +	prefix_push("top-down");
>>>>> +	func();
>>>>> +	prefix_pop();
>>>>> +}
>>>>> +
>>>>> +static inline void run_bottom_up(int (*func)())
>>>>> +{
>>>>> +	memblock_set_bottom_up(true);
>>>>> +	prefix_push("bottom-up");
>>>>> +	func();
>>>>> +	prefix_pop();
>>>>> +}
>>>>> +
>>>>>     #endif
> 
> Thanks,
> Rebecca
>