Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 11:51:07 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] iio: ad7292: Prevent regulator double disable
Message-ID: <Yv9O+9sxU7gAv3vM@fedora>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="j8siMrN4F96COOfa"
Content-Disposition: inline
Precedence: bulk


--j8siMrN4F96COOfa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The ad7292 tries to add an devm_action for disabling a regulator at
device detach using devm_add_action_or_reset(). The
devm_add_action_or_reset() does call the release function should adding
action fail. The driver inspects the value returned by
devm_add_action_or_reset() and manually calls regulator_disable() if
adding the action has failed. This leads to double disable and messes
the enable count for regulator.

Do not manually call disable if devm_add_action_or_reset() fails.

Fixes: 506d2e317a0a ("iio: adc: Add driver support for AD7292")
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---

The bug was found during browsing the code. I don't have the hardware to
test this so reviewing and testing is highly appreciated.
---
 drivers/iio/adc/ad7292.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
index 92c68d467c50..a2f9fda25ff3 100644
--- a/drivers/iio/adc/ad7292.c
+++ b/drivers/iio/adc/ad7292.c
@@ -287,10 +287,8 @@ static int ad7292_probe(struct spi_device *spi)
=20
 		ret =3D devm_add_action_or_reset(&spi->dev,
 					       ad7292_regulator_disable, st);
-		if (ret) {
-			regulator_disable(st->reg);
+		if (ret)
 			return ret;
-		}
=20
 		ret =3D regulator_get_voltage(st->reg);
 		if (ret < 0)
--=20
2.37.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--j8siMrN4F96COOfa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmL/Tu8ACgkQeFA3/03a
ocUO4gf/azvFounl1vyk3T14IF7Feghc/XD57U3YdHlt7xSuxeimG0glII68S28H
x59nP9Vrzr3xMTnAVIxqGLBDDvm1Gt8fCR/3w7fxQzxIZ5jq4XSi4FtBmSsdyev3
kYFgtaK9tO+awvdBry7Kh9o7cCf5IQ+hdku+H7ADInC/jAOXquD7aUHUBOnaLirR
/PS9zV3lIdKKkEPUh3sIcnMkODsKRjwPyWLRkNDDo5kinCbmSG5n0qt34aLyKBAR
bmy7POEi7RMM7LBPmODHc85BFCD0UEEIp3tAdcOozzKp8HpuFyn9ilP8FSW7jo+K
76lm1/T0VOVZ4z35+1M8ipEnXJB1hg==
=wdVz
-----END PGP SIGNATURE-----

--j8siMrN4F96COOfa--