Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
MIME-Version: 1.0
Subject: Re: [PATCH -next v2] bootmem: remove the vmemmap pages from kmemleak
 in put_page_bootmem
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <20220819094005.2928241-1-liushixin2@huawei.com>
Date:   Fri, 19 Aug 2022 17:49:20 +0800
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Matthew Wilcox <willy@infradead.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Linux MM <linux-mm@kvack.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9B9B1BE4-3D6F-4D68-8741-8888AA2FEFB1@linux.dev>
References: <20220819094005.2928241-1-liushixin2@huawei.com>
To:     Liu Shixin <liushixin2@huawei.com>
Precedence: bulk


> On Aug 19, 2022, at 17:40, Liu Shixin <liushixin2@huawei.com> wrote:
>=20
> The vmemmap pages is marked by kmemleak when allocated from memblock.
> Remove it from kmemleak when free the page. Otherwise, when we reuse =
the
> page, kmemleak may report such an error and then stop working.
>=20
> kmemleak: Cannot insert 0xffff98fb6eab3d40 into the object search tree =
(overlaps existing)
> kmemleak: Kernel memory leak detector disabled
> kmemleak: Object 0xffff98fb6be00000 (size 335544320):
> kmemleak:   comm "swapper", pid 0, jiffies 4294892296
> kmemleak:   min_count =3D 0
> kmemleak:   count =3D 0
> kmemleak:   flags =3D 0x1
> kmemleak:   checksum =3D 0
> kmemleak:   backtrace:
>=20
> Fixes: f41f2ed43ca5 (mm: hugetlb: free the vmemmap pages associated =
with each HugeTLB page)
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Thanks for fixing this.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>