Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1401469rwb; Fri, 19 Aug 2022 03:06:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR5kIq3V9Uj3OEz0NqL2DCcNycFIekPEykFEpTMKrcYgD7KUozW/7rtHRrbkRJgDnQ1ELOMs X-Received: by 2002:a17:902:ea07:b0:16e:daf6:6087 with SMTP id s7-20020a170902ea0700b0016edaf66087mr6635350plg.68.1660903573540; Fri, 19 Aug 2022 03:06:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660903573; cv=none; d=google.com; s=arc-20160816; b=aJ5ZMlRrxeaTb9P3luQZw7Ql4SdN6EZwOWU8NI34CrAWvINggFp35Ix+cr+vq4werX fytEkw9YtLWtxt6sjQijoj1Bw2Mdpdat+kL/2gI1ggYTJn5qpvY9++xOdupQR664RI8c xBgrp/PnHkmN3IDDI3u+08Xsy/5mkcUG7RlRQ97T1w6pic3UdC7lA12jeLHN/QS94I8D jnAgbwCBBnect0tbnyTkfq62fGdKqB0vddXWPnCJ6ne0FIpe5VznZlSRAtSq/DtoaZsR BWCGMhnB3c6K+ldSi+9hfv+/ifMTpEFacthGtoTaRZEzw9ObYQDK/zJG6d7vMik9DsjF Emnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=D6tM+h5TEtZd+GQXFtPKzsyn9d4kOBiEHXuz6ywcyws=; b=sW+FY/tLlE6ozPMxV/VXPSojyAEM4LXvQYObS6Epwlj1VlVYEMMBuCtPw3GddWMQeJ j6IR4afhXFdkPzGm7ZN6RXqsuvkhM6W6xu/bDsd7Y5xzXXSegpfPAewF+2k/QupHm42k p1D9kGMtekTopMHo2l1kyzCmcH1uHuODrXwMtcMvLKZpavPJJLsZEk3Rj/pLhLbsRqS8 LhEMNAJx1w/IEggWGtiE0aITP/b4e1UtIP85ECooE023yviqKDbukbhG7zUO4bhLPo+D EyL/M6uFIwiDApCEPwrb3bNOGG8dVt9sVVye4iHytFwZd4h5bNZ8ZLO4o4Gi3kK16l+0 /9sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk14-20020a17090b224e00b001f617f345bbsi1403892pjb.110.2022.08.19.03.06.01; Fri, 19 Aug 2022 03:06:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348132AbiHSJjE (ORCPT + 99 others); Fri, 19 Aug 2022 05:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348100AbiHSJiz (ORCPT ); Fri, 19 Aug 2022 05:38:55 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 321AF4F689 for ; Fri, 19 Aug 2022 02:38:49 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4M8Gmn5b1JzXdpD; Fri, 19 Aug 2022 17:34:33 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 17:38:47 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 17:38:46 +0800 From: Yang Yingliang To: , CC: Subject: [PATCH -next] driver core: switch to use dev_err_probe() Date: Fri, 19 Aug 2022 17:46:56 +0800 Message-ID: <20220819094656.1945653-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use dev_err_probe() to simplify code and print error code. Signed-off-by: Yang Yingliang --- drivers/base/core.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 753e7cca0f40..e51a09f9d0ec 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2507,11 +2507,9 @@ static ssize_t uevent_store(struct device *dev, struct device_attribute *attr, int rc; rc = kobject_synth_uevent(&dev->kobj, buf, count); - - if (rc) { - dev_err(dev, "uevent: failed to send synthetic uevent\n"); - return rc; - } + if (rc) + return dev_err_probe(dev, rc, + "uevent: failed to send synthetic uevent\n"); return count; } -- 2.25.1