Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 12.22.5.236 as permitted sender) receiver=protection.outlook.com;
 client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C
References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
User-agent: mu4e 1.6.6; emacs 28.1
From:   Petr Machata <petrm@nvidia.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        Ido Schimmel <idosch@nvidia.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy
Date:   Fri, 19 Aug 2022 11:45:57 +0200
In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com>
Message-ID: <87czcwmu82.fsf@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 09:57:29.4948
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7593c910-40af-434f-9dc7-08da81c93a7f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.236];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT101.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6364
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Wolfram Sang <wsa+renesas@sang-engineering.com> writes:

>  drivers/net/ethernet/mellanox/mlxsw/core.c       |  2 +-
>  drivers/net/ethernet/mellanox/mlxsw/minimal.c    |  4 ++--
>  .../ethernet/mellanox/mlxsw/spectrum_ethtool.c   |  6 +++---

Reviewed-by: Petr Machata <petrm@nvidia.com> # For drivers/net/ethernet/mellanox/mlxsw

> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
> index 75553eb2c7f2..7331635607f7 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
> @@ -633,7 +633,7 @@ static void mlxsw_emad_process_string_tlv(const struct sk_buff *skb,
>  		return;
>  
>  	string = mlxsw_emad_string_tlv_string_data(string_tlv);
> -	strlcpy(trans->emad_err_string, string,
> +	strscpy(trans->emad_err_string, string,
>  		MLXSW_EMAD_STRING_TLV_STRING_LEN);
>  }
>  
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> index bb1cd4bae82e..e3c045a82ae2 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> @@ -94,14 +94,14 @@ static void mlxsw_m_module_get_drvinfo(struct net_device *dev,
>  	struct mlxsw_m_port *mlxsw_m_port = netdev_priv(dev);
>  	struct mlxsw_m *mlxsw_m = mlxsw_m_port->mlxsw_m;
>  
> -	strlcpy(drvinfo->driver, mlxsw_m->bus_info->device_kind,
> +	strscpy(drvinfo->driver, mlxsw_m->bus_info->device_kind,
>  		sizeof(drvinfo->driver));
>  	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
>  		 "%d.%d.%d",
>  		 mlxsw_m->bus_info->fw_rev.major,
>  		 mlxsw_m->bus_info->fw_rev.minor,
>  		 mlxsw_m->bus_info->fw_rev.subminor);
> -	strlcpy(drvinfo->bus_info, mlxsw_m->bus_info->device_name,
> +	strscpy(drvinfo->bus_info, mlxsw_m->bus_info->device_name,
>  		sizeof(drvinfo->bus_info));
>  }
>  
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c
> index 915dffb85a1c..dcd79d7e2af4 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c
> @@ -14,16 +14,16 @@ static void mlxsw_sp_port_get_drvinfo(struct net_device *dev,
>  	struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(dev);
>  	struct mlxsw_sp *mlxsw_sp = mlxsw_sp_port->mlxsw_sp;
>  
> -	strlcpy(drvinfo->driver, mlxsw_sp->bus_info->device_kind,
> +	strscpy(drvinfo->driver, mlxsw_sp->bus_info->device_kind,
>  		sizeof(drvinfo->driver));
> -	strlcpy(drvinfo->version, mlxsw_sp_driver_version,
> +	strscpy(drvinfo->version, mlxsw_sp_driver_version,
>  		sizeof(drvinfo->version));
>  	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
>  		 "%d.%d.%d",
>  		 mlxsw_sp->bus_info->fw_rev.major,
>  		 mlxsw_sp->bus_info->fw_rev.minor,
>  		 mlxsw_sp->bus_info->fw_rev.subminor);
> -	strlcpy(drvinfo->bus_info, mlxsw_sp->bus_info->device_name,
> +	strscpy(drvinfo->bus_info, mlxsw_sp->bus_info->device_name,
>  		sizeof(drvinfo->bus_info));
>  }