Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 12:07:16 +0200
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 1/4] iio/adc: ingenic: fix channel offsets in buffer
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Artur Rojek <contact@artur-rojek.eu>,
        Jonathan Cameron <jic23@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Chris Morgan <macromorgan@hotmail.com>,
        BROADCOM NVRAM DRIVER <linux-mips@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>
Message-Id: <4GXUGR.SAF00K92YJMF@crapouillou.net>
In-Reply-To: <CAHp75Vd49aCKkK+KvmxJrW2mKk7=VgtSBCTYE9umOhZhc4Y8FA@mail.gmail.com>
References: <20220817105643.95710-1-contact@artur-rojek.eu>
        <20220817105643.95710-2-contact@artur-rojek.eu>
        <CAHp75Vd49aCKkK+KvmxJrW2mKk7=VgtSBCTYE9umOhZhc4Y8FA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andy,

Le ven., ao=FBt 19 2022 at 11:12:38 +0300, Andy Shevchenko=20
<andy.shevchenko@gmail.com> a =E9crit :
> On Wed, Aug 17, 2022 at 1:58 PM Artur Rojek <contact@artur-rojek.eu>=20
> wrote:
>>=20
>>  Consumers expect the buffer to only contain enabled channels. While
>>  preparing the buffer, the driver also (incorrectly) inserts empty=20
>> data
>>  for disabled channels, causing the enabled channels to appear at=20
>> wrong
>>  offsets. Fix that.
>=20
> What consumers? Have you tested on all of them? Please, elaborate. It
> might be that some of them have to be fixed. In such case you need to
> report the issue to their respective channels and put the
> corresponding links here.

There are no consumers to fix, only this driver. I believe it  wasn't=20
noticed until now because all consumers were only using channels 0 and=20
1.

Cheers,
-Paul

> P.S. It doesn't mean I'm against the patch.
>=20
> --
> With Best Regards,
> Andy Shevchenko