Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1525395rwb; Fri, 19 Aug 2022 05:20:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR44r1/dXuE6OFI3/G22mAuCAiaihKmE19UYZ7kG4aCxGf7QpBH0dGuphdBjTcCOdcFL37a1 X-Received: by 2002:a17:907:11c1:b0:731:5c53:d912 with SMTP id va1-20020a17090711c100b007315c53d912mr4642810ejb.354.1660911623110; Fri, 19 Aug 2022 05:20:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660911623; cv=none; d=google.com; s=arc-20160816; b=NMArafDRlvwE5sIMeYMv5en6gNPagiR5ytrkQ6/crqJUbCtYhK9k8MF0xrHvuVkFts JmE+JlmvkVX/zJ6ZTevjVd5jea0COYQcilBxu18i5ItB6pFcdoPXG4BDF1CU3oXyfRhj cA3j/jyTrhPU2H0inHBcMCPZp7FyYZ1hILGsI1ZhNmXKiRz6/2XU9/GGDOIoNBPfVHP7 mu2LS+1/iBQPrswd/FwZQJen5mJO+/JYTN/hsZ5v1U7dKDcBVSWRTL/uERSTlkHgjJ1f b8s/ko8BaPyA0mb/tTh1ev9RX4P38xR1SqPdpzro2CfhMcgY0X9fnHi7xqcu7ILRqtrl g6Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g/YPOMlZjMsEaO2WgP8P2ictRGCTTr097gbQCAoAdL0=; b=IpD/33kL/FYDnJkjbcbgBmvcVM0r3H87w9WDJtCqhL8S1Qn+SCMARzEYMo+eeTTb5A dg+dVozm5LbIUitX4UgatGTkK7AZTsnyt4Oo09c+KIw9nBI91Krgi43xLXcAo89fXOi0 7DqSGvSYcYvIsvDAo77eJRWcnWb7nChpyw/IeEowL8POsXdm7yLc9y/1jhDXbpNLpMJ5 zNBmDMNLA1NSD1+Yx2lN6vTQQcO19LNzflrI+joLSPV5q3AY7zttDXXH4tMQwawLZuw7 alALBfKIVM8bXdlnruQaUvxyomm+xZGlfDZke/5eoenNio2Nm23HA46pyQpxLBJJQXsg D/4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=eqz286Wl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l22-20020a170906795600b00730a42c33f5si3430517ejo.768.2022.08.19.05.19.56; Fri, 19 Aug 2022 05:20:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=eqz286Wl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348900AbiHSMHH (ORCPT + 99 others); Fri, 19 Aug 2022 08:07:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348496AbiHSMHD (ORCPT ); Fri, 19 Aug 2022 08:07:03 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2BA010096A; Fri, 19 Aug 2022 05:06:57 -0700 (PDT) X-UUID: 90fb09d8026b40bcb47f4d9907776688-20220819 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=g/YPOMlZjMsEaO2WgP8P2ictRGCTTr097gbQCAoAdL0=; b=eqz286WlDwrBi5Va/N4fvbTOki8cK9cI0LmYNnDzFWCsjXmeTlOCqu/2Jhpv+NPutiJY0p2uWvvOT7i/eMstPdBc5XClUzx5QospF2u+Q5GA7GDkXqvSAqM/dEt3mcht86PcrlRQR0nOOLeDolrM8B495gkLY4dj1oohGoUmKJ8=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:b698d438-228e-4734-ac58-4b3edee145df,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Releas e_Ham,ACTION:release,TS:-25 X-CID-META: VersionHash:84eae18,CLOUDID:459c36c9-6b09-4f60-bf82-12f039f5d530,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 90fb09d8026b40bcb47f4d9907776688-20220819 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1512524538; Fri, 19 Aug 2022 20:06:52 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 19 Aug 2022 20:06:50 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 19 Aug 2022 20:06:50 +0800 From: Allen-KH Cheng To: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger CC: , , , , , Allen-KH Cheng , Guodong Liu Subject: [PATCH v3] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes Date: Fri, 19 Aug 2022 20:06:49 +0800 Message-ID: <20220819120649.21523-1-allen-kh.cheng@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mt8186 contains 8 GPIO physical address bases that correspond to the 'reg-names' of the pinctrl driver. The 'reg-names' entries in bindings are ordered incorrectly, though. The system crashes due of an erroneous address when the regulator initializes. We fix the 'reg-names' for the pinctrl nodes and the pinctrl-mt8186 example in bindings. Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document") Co-developed-by: Guodong Liu Signed-off-by: Guodong Liu Signed-off-by: Allen-KH Cheng Acked-by: Krzysztof Kozlowski Reviewed-by: NĂ­colas F. R. A. Prado --- Change in v2: * Remove changes of the formatting of addresses and add C-d-b tag for Guodong Change in v1: * Capitalize First Letter of Sentences and rephrase the commit message [Allen-KH Cheng ] --- --- .../bindings/pinctrl/pinctrl-mt8186.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml index 1eeb885ce0c6..26573a793b57 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml @@ -41,12 +41,12 @@ properties: Gpio base register names. items: - const: iocfg0 - - const: iocfg_bm - - const: iocfg_bl - - const: iocfg_br + - const: iocfg_lt - const: iocfg_lm + - const: iocfg_lb + - const: iocfg_bl - const: iocfg_rb - - const: iocfg_tl + - const: iocfg_rt - const: eint interrupt-controller: true @@ -235,9 +235,9 @@ examples: <0x10002A00 0x0200>, <0x10002c00 0x0200>, <0x1000b000 0x1000>; - reg-names = "iocfg0", "iocfg_bm", "iocfg_bl", - "iocfg_br", "iocfg_lm", "iocfg_rb", - "iocfg_tl", "eint"; + reg-names = "iocfg0", "iocfg_lt", "iocfg_lm", + "iocfg_lb", "iocfg_bl", "iocfg_rb", + "iocfg_rt", "eint"; gpio-controller; #gpio-cells = <2>; gpio-ranges = <&pio 0 0 185>; -- 2.18.0