Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Fri, 19 Aug 2022 06:03:39 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-hwmon@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 1/1] hwmon: (iio_hwmon) Make use of device properties
Message-ID: <20220819130339.GA3108215@roeck-us.net>
References: <20220730125024.87764-1-andriy.shevchenko@linux.intel.com>
 <20220818232256.GA3505808@roeck-us.net>
 <CAHp75Vc5CtOwFFJxLEe2kNTpU0xqWmcwDLAYtFgkhJVx7KvwqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vc5CtOwFFJxLEe2kNTpU0xqWmcwDLAYtFgkhJVx7KvwqA@mail.gmail.com>
Precedence: bulk

On Fri, Aug 19, 2022 at 12:50:46PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 19, 2022 at 2:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
> > On Sat, Jul 30, 2022 at 03:50:24PM +0300, Andy Shevchenko wrote:
> > > Convert the module to be property provider agnostic and allow
> > > it to be used on non-OF platforms.
> > >
> > > Add mod_devicetable.h include.
> > >
> > What does that have to do with this patch ?
> 
> See below.
> 
> > > +#include <linux/mod_devicetable.h>
> 
> > > -#include <linux/of.h>
> 
> The of.h implicitly included missed headers. The mod_devicetable.h is
> necessary when we drop of.h. OTOH I haven't checked if
> mod_devicetable.h is still included indirectly. Either way the correct
> approach is to include mod_devicetable.h since we use a data type from
> it (of_device_id IIRC).
> 
Something like

"Include mod_devicetable.h explicitly to replace the dropped of.h which
 included mod_devicetable.h indirectly"

might be useful.

Thanks,
Guenter

> -- 
> With Best Regards,
> Andy Shevchenko