Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] swiotlb: avoid potential left shift overflow
To:     Chao Gao <chao.gao@intel.com>, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev
Cc:     hch@infradead.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
        jxgao@google.com, konrad.wilk@oracle.com
References: <20220819084537.52374-1-chao.gao@intel.com>
From:   Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <38c58aa0-11c7-f553-95fd-292fd4944a75@oracle.com>
Date:   Fri, 19 Aug 2022 06:44:05 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <20220819084537.52374-1-chao.gao@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmRQMTZQMmp6VkRwbDJjUVplSDhMQ2hHaVN6b0hheTNwV0VBOFM5ZG84c253?=
 =?utf-8?B?TG9CNitxYk9wUUlld2VMVkdLRjUxaFczN1d6cEF5WkhiRGR1V2FDQ2d2OEVt?=
 =?utf-8?B?VGxoa2V6WEs2cWhLRmtuNVBOOVRyeGhRMTFBWjBvdUw0RC9ncVEzNzZ4MTRD?=
 =?utf-8?B?eGlEa1Jyb0tLTmVrTGpxcDl5WCtWazl1bVNPSlQ5eFNDR3BqRDNqK0hPM2Vy?=
 =?utf-8?B?Zm1PblZOWWRYdDRtbzdIZnRsSVRqcEF4bThBY01GbTViV1lPdjZjUUdLS1oy?=
 =?utf-8?B?T1RvUEFnek90ZjV2K3ZLWVFlU2ZkQkVFOHprZ3l5bDRrSFF1TDErdWlkVzdE?=
 =?utf-8?B?d0xuYUJmTWNXNzV1Q3B6MDcyZVduaFEwUVIrWHJpTUhBaS9wZ0RWVXdnbUxa?=
 =?utf-8?B?dldCTE5iemZYQ2FVSHQ5YWVQRTYzNXpNSC8rbkd5NEw4K2E5YzhxY2xxMktL?=
 =?utf-8?B?NGw5eHIxb01nd3kzYXR5aDJlbndFNldzYk55UnNzS05VS0pxNExWUmh1N29v?=
 =?utf-8?B?MFZwWW1HY3NERkloOHpEVnJNZFlTM0ZNWjRSaTRURGlKcFJVL0RqRXg5R3JG?=
 =?utf-8?B?WWpiQlBseUo0OExURnBBWWx5SUF5NmpkcG9aQmpicktUa2J1aGZaMldXazYy?=
 =?utf-8?B?dFFXTzRJQXhuRVNxSzg1U0EyYnRqKzZzNWZHRm4vQXJIRzRzN3oyNEV6UXY0?=
 =?utf-8?B?Tzc5SmdmY3ZON0NvYzV6VHZxVkJWUnpkYWdSVU5oUHVSTllWQnVmWHRoNHZm?=
 =?utf-8?B?U1o0aC9KaFlGbFVDRUxDTENBcXdMSGF1MFUxUWhtVWlEeVZrdXJHaGZEQnlC?=
 =?utf-8?B?d3pVbnlrczc4bXpWQ3k1cmN5QlhGOFgyeEw4VG83eGxLbmFIREdnVllQeVlP?=
 =?utf-8?B?dlRlWVVTSGpZelErS25NdDRkMDRjY2pSRi9iNTNibVVjZ3piWVlTUUpFNllS?=
 =?utf-8?B?VnkxM0toV1FHeXN0SExQTE5wU3cwSzVGYmVSdk5abEpUZE9jSHBIVVdhWkFW?=
 =?utf-8?B?RUhtT0pYZjk1eU55bWNaQnFLelBRRVFTRVZ5MXpXNTczeGpmODFkYUtLdnli?=
 =?utf-8?B?TXJoeGd4amxpZm40UWVFbFRMbzJSb25lRC9rR0pYblQ4RnVQaUJhVjRFSjND?=
 =?utf-8?B?MnhxTEZteVg1YUJuaVVsZjhvRU9HaGZLVGdpMUxicndJS1ovNmo4eDJaaU1m?=
 =?utf-8?B?Y0NYNFNNSTc3dUxwQkE5S29HQ1RJYTFXY2ZRcnJMRTJmb2JaajJNaFU5Mlhl?=
 =?utf-8?B?TFdiSmp2WkxMOE9IRG5UWCtob25PK3BGNUdTbGdqa29YUVlpNHQ1TXlDSEZs?=
 =?utf-8?B?UVNIWkxsWWh4Z3hDbG9YVHdoZ0VqSTJwWUFtaWc4Yy9IeE9oSlpsRGlBMTJH?=
 =?utf-8?B?L1FlUmxXdmtXQlM0cWZJL1llMnJ6eWhrRWt2TnM1Z2Y5MWJ6NEpQSEltblhn?=
 =?utf-8?B?U25BaGgxVXNzc0dLRTJhYVNwck5uS3JRaDcxa3lBYkJ5WWpKcm5MSURYNFYr?=
 =?utf-8?B?WUt5TE5jVTcyb1VMbkdLMStzWWROQld1ZlJnZVk1alJSNGdtVUpJNFc4VmFP?=
 =?utf-8?B?aWRXOUlXWW05bTJTc1Q2NkJmTmxNcGVnNVplVzNjVFpxRVlkQkNFdkVTanQ2?=
 =?utf-8?B?cjVCZjk1emordmxsN1NEejZVNTRFNVZ3NkI5YmgwOEQ0bGc5ZzhJU2ZwK2w0?=
 =?utf-8?B?SkJpSlhDKzgwN0hYQ3hhNllocDNpdyttaDQ0UExEV1hmRUVsc3lPMDRiRW4w?=
 =?utf-8?B?Uzd4YmJOd29pUFVLUVg5bjFlMm9oa21BNi9YK3NrNjhtNnFlZTZ5a1NGTWY4?=
 =?utf-8?B?eGk2N0ZvYU9oWFJyeS9SVzhxa1IzTy9MMDcvWTAzZzJJUHVWdC9PUmZ2N0tD?=
 =?utf-8?B?YTJkbXVZRDRMQkVNQXRQTUF6bHlDNXhTU0NLMUdWYVh2ZloraUEyOTkxb1FE?=
 =?utf-8?B?TUNhK0poc29KNGJqelpOcDR5WVQyeDhnSnFuRU1iQWQzOUUzcmF1TGVtUWVw?=
 =?utf-8?B?SEc5NnlsUksvQW5KSTd0U2dDNmJ1WjNjQ3BzZ0t1Nm5aMVpteXB0dTduR2hu?=
 =?utf-8?B?ZFYveWZIK3lnSGVucTkrUzA1bkF6RmFBa0h6MkZXcWRuUFB2bkRrc0FYRFJR?=
 =?utf-8?B?cWxsalQwV1RaOW9ZVURRZ1k1UVB6dWtWNmZWNHczUHBERVBoK21iMTdNOUNa?=
 =?utf-8?Q?j8YFy2YM2ylDTuh9nzcLMV4=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?T0xURlIwWlpzeURrSzlteUZ3VXVaTG92ZW01RDNkeGpBZGxCYmJsMGI4ZUxN?=
 =?utf-8?B?UFpBWERjcFRsK0pvdSsrNmhuZ1FNWlc5aEpmd0VKYjFQWC9sVXdpajJVeWVl?=
 =?utf-8?B?V3FQd0NXclJIbFdQVjE1SERvbjcxSzkxS3JXMFlSVnZxQTFJS1BvT1dMc3Bx?=
 =?utf-8?B?QXltRWYvYWRRaXZxOTQrZWJCSGxrdVdXc3FwVFhQWDVyK3gwR1JpK3k4WHNk?=
 =?utf-8?B?dEI2SGw0S29PalFjbmlEbkF4bWxCRmNMaVBuZyt3UTlSNWZOVHhTb1RFUXEr?=
 =?utf-8?B?dkt0YVdkZ0I4bEVNaHdJSXdRbVJza29LUjZqNUtCVHFqazdrV2dFQmFrVUJ6?=
 =?utf-8?B?RjhuTTBzNVgwTno1bEdzZ2t4TTRXNkJaRWZxaFdxVm1nUThrSll0R0YzWWh4?=
 =?utf-8?B?YmZMQUswN2JpcjhGTERtNjE2TWVORXEyL1hidFBnTEtXSzRFTUdWS0lLNUs4?=
 =?utf-8?B?MzZWeko2VDNPdzVnNVlUb2VXeVJXYlNuU0tpNUw1bllYSkt4bStvN2xac043?=
 =?utf-8?B?ZXozSVkwTjhTMXg0Z0h2Z09UU1U3Y0pBTk9SL2pIVUlac3Boa0NIUUY2S1Nr?=
 =?utf-8?B?UWZ3NG5JQkV1WlpQdmNMcjdOSFEvVGE0S2ZtQ3NzaUdjaWQzRUl2Njk1QUpY?=
 =?utf-8?B?akMzTDR3aERBOTJPTWJGT3lja2hnRzNOckdKRldiY0JkVmpyRi91cmY0Z3Fy?=
 =?utf-8?B?UVdxMzIrMHpFRTBKWnZmRGpVMENydG5mVmJxMG1KOC9iVlM2c2czMktJSTJM?=
 =?utf-8?B?OWJMVGUwdzl0OVhTZDVjbi9JRXJHZ3dYT3hFYUpXWU9DbFVDa0llZkh1VzRE?=
 =?utf-8?B?dDRtWi9va3c3QTFXTUw5L3k3NHlMUVNkV0hwSFlxTHdXWC9BRDBsSjFFS0E1?=
 =?utf-8?B?cTZYdjA4MkVZRlRibUh5Rlp0dm5aK09UR0VwV0JOR0Z4SkpEUjVwY1lHK2Vj?=
 =?utf-8?B?UStvdWtiZzlQdEhLNGVlaG9sbEhwQ3UrUCsvajZiMWRPYW15RDVKaGUrdktZ?=
 =?utf-8?B?bHF6TWZaOFZhL1dvMGJvSjEwa3lwWGROelN2b3dkbXVEb0prellPeVhCNW12?=
 =?utf-8?B?TW4zK1llOVJ3cmlHaTFMYStnK3pQVy83amt5dXlxL0NFTVdSRTNBNDRoeDN2?=
 =?utf-8?B?L2JtaHN1Y0htTFE5NmJBRnE1Vk1YUUFoMUVDKytoUW04dGZYeVRQM0M0K1Fp?=
 =?utf-8?B?blFCamJKOU1XcEZCRkhKZ0pDRTMwOWNsZzJxcEpQYjgyZy9PbGRRRU4zYlJK?=
 =?utf-8?B?aGlFWHhOODJCMk9lNDk5aVExQjV2ancwUmt6Z2taQXVQQitxeUtaeFpyMVM2?=
 =?utf-8?B?dXJuRm4vTk80WHluZVZ2eW1NNGMwWWZuM2FFK0VzN1lyVFkxTzlpTHpDTUls?=
 =?utf-8?Q?zuQQON2TIu2B0Qh3dnAhHVj1TQ6yabpQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7c2a679-a038-4a49-73db-08da81e8e34d
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 13:44:07.6152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cDwG9k9X7eYtDV1M5lXk/8ynHO9m7wSEkRoQRNO0BnLl8W0YZDkq5ksMYTLu9P+kEqxzhxfgy5T2uhqQNewGrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1524
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-19_08,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208190052
X-Proofpoint-ORIG-GUID: Ldi3q-85kUeqZ7Xc1TpiS8xXsWNlXHVd
X-Proofpoint-GUID: Ldi3q-85kUeqZ7Xc1TpiS8xXsWNlXHVd
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I also encountered this when sending out another version of the 64-bit swiotlb.

https://lore.kernel.org/all/20220609005553.30954-8-dongli.zhang@oracle.com/

Unfortunately, I could not find an environment (e.g., powerpc) to allocate more
than 4G until swiotlb supports 64-bit.

Although xen supports 64-bit, but the hypervisor side limits the max to < 4G.

Dongli Zhang

On 8/19/22 1:45 AM, Chao Gao wrote:
> The second operand passed to slot_addr() is declared as int or unsigned int
> in all call sites. The left-shift to get the offset of a slot can overflow
> if swiotlb size is larger than 4G.
> 
> Convert the macro to an inline function and declare the second argument as
> phys_addr_t to avoid the potential overflow.
> 
> Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> ---
>  kernel/dma/swiotlb.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
> index c5a9190b218f..41ea9fb3efe1 100644
> --- a/kernel/dma/swiotlb.c
> +++ b/kernel/dma/swiotlb.c
> @@ -579,7 +579,10 @@ static void swiotlb_bounce(struct device *dev, phys_addr_t tlb_addr, size_t size
>  	}
>  }
>  
> -#define slot_addr(start, idx)	((start) + ((idx) << IO_TLB_SHIFT))
> +static inline phys_addr_t slot_addr(phys_addr_t start, phys_addr_t idx)
> +{
> +	return start + (idx << IO_TLB_SHIFT);
> +}
>  
>  /*
>   * Carefully handle integer overflow which can occur when boundary_mask == ~0UL.
> 
> base-commit: 5c850d31880e00f063fa2a3746ba212c4bcc510f
>