Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 12:26:28 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 0/4] perf tools: Support reading PERF_FORMAT_LOST (v3)
Message-ID: <Yv+rpO2Zvt1A5cp3@kernel.org>
References: <20220819003644.508916-1-namhyung@kernel.org>
 <Yv9rplmtHB5fZsv+@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yv9rplmtHB5fZsv+@krava>
Precedence: bulk

Em Fri, Aug 19, 2022 at 12:53:26PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 18, 2022 at 05:36:40PM -0700, Namhyung Kim wrote:
> > Hello,
> > 
> > The kernel v6.0 added PERF_FORMAT_LOST which can read a number of lost
> > samples for the given event.  As it can change the output format of
> > read(2) and perf sample data, it needs to access them carefully.
> > 
> > Changes in v3)
> >  * add sample_read_group__for_each()  (Jiri)
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, updated the patchset in my branch.

- Arnaldo
 
> thanks,
> jirka
> 
> > 
> > Changes in v2)
> >  * add a comment in perf_evsel__read_group()  (Jiri)
> >  * simplify perf_evsel__adjust_values()  (Jiri)
> > 
> > 
> > You can get the code from 'perf/read-lost-v3' brach on
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> > 
> > Thanks,
> > Namhyung
> > 
> > Namhyung Kim (4):
> >   tools headers UAPI: Sync linux/perf_event.h with the kernel sources
> >   tools lib perf: Handle read format in perf_evsel__read()
> >   tools lib perf: Add a test case for read formats
> >   perf tools: Support reading PERF_FORMAT_LOST
> > 
> >  tools/include/uapi/linux/perf_event.h         |   5 +-
> >  tools/lib/perf/evsel.c                        |  79 ++++++++-
> >  tools/lib/perf/include/perf/event.h           |   3 +-
> >  tools/lib/perf/include/perf/evsel.h           |   4 +-
> >  tools/lib/perf/tests/test-evsel.c             | 161 ++++++++++++++++++
> >  tools/perf/tests/sample-parsing.c             |  14 +-
> >  tools/perf/util/event.h                       |  21 ++-
> >  tools/perf/util/evsel.c                       |  29 ++--
> >  .../scripting-engines/trace-event-python.c    |  19 ++-
> >  tools/perf/util/session.c                     |  35 ++--
> >  tools/perf/util/synthetic-events.c            |  32 +++-
> >  11 files changed, 356 insertions(+), 46 deletions(-)
> > 
> > 
> > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> > -- 
> > 2.37.1.595.g718a3a8f04-goog
> > 

-- 

- Arnaldo