Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 15:52:42 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Dexuan Cui <decui@microsoft.com>, quic_jhugo@quicinc.com,
        wei.liu@kernel.org, kys@microsoft.com, haiyangz@microsoft.com,
        sthemmin@microsoft.com, lpieralisi@kernel.org, bhelgaas@google.com,
        linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, mikelley@microsoft.com,
        robh@kernel.org, kw@linux.com, alex.williamson@redhat.com,
        boqun.feng@gmail.com, Boqun.Feng@microsoft.com,
        Carl Vanderlip <quic_carlv@quicinc.com>
Subject: Re: [PATCH] PCI: hv: Fix the definiton of vector in
 hv_compose_msi_msg()
Message-ID: <20220819155242.w32vcwobt4ucvpyv@liuwe-devbox-debian-v2>
References: <20220815185505.7626-1-decui@microsoft.com>
 <20220815203545.GA1971949@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220815203545.GA1971949@bhelgaas>
Precedence: bulk

On Mon, Aug 15, 2022 at 03:35:45PM -0500, Bjorn Helgaas wrote:
> s/definiton/definition/ in subject
> (only if you have other occasion to repost this)
> 
> On Mon, Aug 15, 2022 at 11:55:05AM -0700, Dexuan Cui wrote:
> > The local variable 'vector' must be u32 rather than u8: see the
> > struct hv_msi_desc3.
> > 
> > 'vector_count' should be u16 rather than u8: see struct hv_msi_desc,
> > hv_msi_desc2 and hv_msi_desc3.
> > 
> > Fixes: a2bad844a67b ("PCI: hv: Fix interrupt mapping for multi-MSI")
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Cc: Jeffrey Hugo <quic_jhugo@quicinc.com>
> > Cc: Carl Vanderlip <quic_carlv@quicinc.com>
> 
> Looks like Wei has been applying most changes to pci-hyperv.c, so I
> assume the same will happen here.

I can take care of this one via hyperv-fixes, but ...

> 
> > ---
> > 
> > The patch should be appplied after the earlier patch:
> >     [PATCH] PCI: hv: Only reuse existing IRTE allocation for Multi-MSI
> >     https://lwn.net/ml/linux-kernel/20220804025104.15673-1-decui%40microsoft.com/
> > 

... this patch looks to be rejected.

Thanks,
Wei.