Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1860470rwb; Fri, 19 Aug 2022 10:35:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR626kj3m/JZJLqkduHcdBrHF805rlX/FfFdIp86FuejewEZleK24w+PJt6TrQMcI+rteNo3 X-Received: by 2002:a17:902:c945:b0:16d:c318:4480 with SMTP id i5-20020a170902c94500b0016dc3184480mr8389179pla.147.1660930515596; Fri, 19 Aug 2022 10:35:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660930515; cv=none; d=google.com; s=arc-20160816; b=YZOR8js0W0utQggZmStG7EPLISH0cPV3n8Mej1P86EIY47ihMo9uZMvdpHlHXamM4b QlllvVe+yZPuJCUFTF6DOLJJ3v+7IxHuxpEUaxTSqsNnJzh2xEkDKAZ3RUlivCo0gQjy Zdl7NYkVr1vkIGUFvs0eEZeqKzGy+oAOgtDor8srVzIeUQL1Lf04oakDp4lx0ZP8YeRs uwpyciOmjMd9IQNPSk5IcYO1+eVX1fZkwf2ERdWtqOjg8VtEIRUiHsP++cpSAWKRJixq tGUVy3CGNc46l6/b1z9zebbqlHJnJwAqnt46n26yfPuYSpU+NCA+GEzUH61PIx+l4WwM aptA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Qhn0aPSM9eWl5K+xGI8HzceDK3ieID19xmkNV7avdgs=; b=ZxPeA2+ybQw7unfMeihBy7E2S9xcLRJmHA6X4pn1m8rXmNcTkU6c6uozCQs1Q0KokT OOlGLXBdK0KCU4EwoZAjElUPajjwwtr2CwwDOTBgkSwD/I6KJArv+aR9Q1QSNuzEuRA1 2DDOgioiQ900Le15cGp7I6dV8Kf40WceeZewGzqhYJ7QO538BT/Gr6YIWoBCx2V55+sQ lGYxwREaAGPfkkWvTsTyOa/FPQZYyedA6iyzbQ0tfUaLW0e26na6OjbLRhXCBh1lBFWR G0+FCLnYiolUjP7HdCLspqmOMPkwWAL5GETONIj0lYglWZZGYHoRDB+MRNRH2R5nUWi8 qNHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eIqW+cPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z5-20020a1709028f8500b0016e81e59c8fsi4052205plo.544.2022.08.19.10.35.04; Fri, 19 Aug 2022 10:35:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eIqW+cPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351368AbiHSQJF (ORCPT + 99 others); Fri, 19 Aug 2022 12:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351679AbiHSQGU (ORCPT ); Fri, 19 Aug 2022 12:06:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 777021EC5C; Fri, 19 Aug 2022 08:55:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E99D36174E; Fri, 19 Aug 2022 15:55:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7965C433C1; Fri, 19 Aug 2022 15:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660924515; bh=tMmXL/qGN8JSHOlxpl85Dsz797mO7n/oV3gAG5EougU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eIqW+cPdwa2ia9pyn/ILp4Hv96ndisLUucM/amxtnCLjtQhukX914CpoAOnQNc7N3 Bl4efvqQg7QFVyLezfQTmS41qz1wNpm0QgTF9urW1TZKzDImmzsGfvWTQcmVNVRQ2y fe0NSmJTYdlGNvBgJTHLvSTY3/ti43mtYEJlKyWc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Stevenson , Maxime Ripard , Sasha Levin Subject: [PATCH 5.10 196/545] drm/vc4: dsi: Register dsi0 as the correct vc4 encoder type Date: Fri, 19 Aug 2022 17:39:26 +0200 Message-Id: <20220819153838.136072639@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220819153829.135562864@linuxfoundation.org> References: <20220819153829.135562864@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson [ Upstream commit 4d9273c978d4c1af15d7874c10c732ec83d444d0 ] vc4_dsi was registering both dsi0 and dsi1 as VC4_ENCODER_TYPE_DSI1 which seemed to work OK for a single DSI display, but fails if there are two DSI displays connected. Update to register the correct type. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Dave Stevenson Link: https://lore.kernel.org/r/20220613144800.326124-15-maxime@cerno.tech Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 2cedf1cf6758..8e2d5c4237ae 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1488,7 +1488,8 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data) return -ENOMEM; INIT_LIST_HEAD(&dsi->bridge_chain); - vc4_dsi_encoder->base.type = VC4_ENCODER_TYPE_DSI1; + vc4_dsi_encoder->base.type = dsi->variant->port ? + VC4_ENCODER_TYPE_DSI1 : VC4_ENCODER_TYPE_DSI0; vc4_dsi_encoder->dsi = dsi; dsi->encoder = &vc4_dsi_encoder->base.base; -- 2.35.1