Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47ce07adc73887b5afaf9815a78b793d0e9a6b54.camel@collabora.com>
Subject: Re: [PATCH v1 2/3] media: cedrus: Set the platform driver data
 earlier
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Jernej =?UTF-8?Q?=C5=A0krabec?= <jernej.skrabec@gmail.com>,
        linux-media@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
        Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Samuel Holland <samuel@sholland.org>
Cc:     kernel@collabora.com,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        stable@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Date:   Fri, 19 Aug 2022 11:37:20 -0400
In-Reply-To: <4418189.LvFx2qVVIh@jernej-laptop>
References: <20220818203308.439043-1-nicolas.dufresne@collabora.com>
         <20220818203308.439043-3-nicolas.dufresne@collabora.com>
         <4418189.LvFx2qVVIh@jernej-laptop>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

Le vendredi 19 ao=C3=BBt 2022 =C3=A0 06:17 +0200, Jernej =C5=A0krabec a =C3=
=A9crit=C2=A0:
> Dne =C4=8Detrtek, 18. avgust 2022 ob 22:33:07 CEST je Nicolas Dufresne na=
pisal(a):
> > From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >=20
> > The cedrus_hw_resume() crashes with NULL deference on driver probe if
> > runtime PM is disabled because it uses platform data that hasn't been
> > set up yet. Fix this by setting the platform data earlier during probe.
>=20
> Does it even work without PM? Maybe it would be better if Cedrus would se=
lect=20
> PM in Kconfig.

I cannot comment myself on this, but it does not seem to invalidate this
Dmitry's fix.

>=20
> Best regards,
> Jernej
>=20
> >=20
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> > ---
> >  drivers/staging/media/sunxi/cedrus/cedrus.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c
> > b/drivers/staging/media/sunxi/cedrus/cedrus.c index
> > 960a0130cd620..55c54dfdc585c 100644
> > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> > @@ -448,6 +448,8 @@ static int cedrus_probe(struct platform_device *pde=
v)
> >  	if (!dev)
> >  		return -ENOMEM;
> >=20
> > +	platform_set_drvdata(pdev, dev);
> > +
> >  	dev->vfd =3D cedrus_video_device;
> >  	dev->dev =3D &pdev->dev;
> >  	dev->pdev =3D pdev;
> > @@ -521,8 +523,6 @@ static int cedrus_probe(struct platform_device *pde=
v)
> >  		goto err_m2m_mc;
> >  	}
> >=20
> > -	platform_set_drvdata(pdev, dev);
> > -
> >  	return 0;
> >=20
> >  err_m2m_mc:
>=20
>=20
>=20
>=20