Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1864645rwb; Fri, 19 Aug 2022 10:39:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR6jDBMqQEy/QuFLFRteIWG4nNt/k+MHn2nbzCxFk5r0jY73OtoZ6v8dkf+0JWPmtrP566jt X-Received: by 2002:a05:6402:28ca:b0:43b:5235:f325 with SMTP id ef10-20020a05640228ca00b0043b5235f325mr6850180edb.320.1660930781719; Fri, 19 Aug 2022 10:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660930781; cv=none; d=google.com; s=arc-20160816; b=KPmr1qbKSARuvmy6m5RITYDbiZ3e40XsUmapiYxaaTKWgBOhtI5v1FsgsFmaaA9ygE HumLcJmjF+d5yznbyacPlEy3rpne060U8Qjwn4GWg+g6nEZnxoRJKcstqL4oLhavGg38 c/sS6quwZJO3mFFn71uXJb9wLGKSgfiJAxenpBKkZTIvggQv1uZ8N7VJn9fHdlK6cQ9S eIBwqqTLqzsVyQqZcDAbo7X/ajLEs5aRTN1aRRsoJOBAQdkYGVfb8il6PwhS1vmTZ2iv 7+/UhNeFcQ+4zd+AYTOJrkT60ABrSYM/8U+NF3OXLNuovfBZbKU7nKwXJrtvMP2yzKic qxhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qckehrA+jyKutAitjuFHz7dQ89ffY9fZLkTyhvg8WjI=; b=YG+VAt9YWdvBp0FGkpIasIgtLq+cG83/E0BXSFMPuoqNKpjdUattw9OTDYKTsABHG3 /CmCGE5xcWxjApp+1NWubhKQKGBltOQti33//v5LdYblt2jWkWZazK6+ba4tQwL4truD w1HV8qUmai/fW48v8OF84RXNJC8hxNaWt8HAccPEafwF4y4uFxUlSPAmcMkkW4Q0rTZ0 uh3/rijbUdCLfAsiDrgiMF2IDbnyD049IIPIIgQ33y/i29Tyj0aDC3ZVdTqIOEG912k0 PXc2L00bwg+Uk2DL0qHsoJuK0BzapnQPNNQ2AXuyTXWNygm8S615WFfLNloha+e9F9Z/ Eusw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EO63s94M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp42-20020a1709073e2a00b007309910699bsi3568093ejc.673.2022.08.19.10.39.15; Fri, 19 Aug 2022 10:39:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EO63s94M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350378AbiHSPvp (ORCPT + 99 others); Fri, 19 Aug 2022 11:51:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350435AbiHSPud (ORCPT ); Fri, 19 Aug 2022 11:50:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91BFA20BDD; Fri, 19 Aug 2022 08:48:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD3B9B827F8; Fri, 19 Aug 2022 15:48:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25AF0C433C1; Fri, 19 Aug 2022 15:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660924088; bh=eiBYGI/GfKKQfsl7Kp3lm0urt+HgH2Yhm6H9UA64sHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EO63s94M5IzBU9lWewIZY1yksxaYTCM6MYPsw4jiRJ0SQNwA+fG9q0DaYudlznQeY Zl/KzOAneQD9slwjVVfGcBs89rCpcMZz8sJ2cSb4KnPR+iS7RWneMzMSlEFje9gJ4T JtLXYb+X58WV1MB/4XFQXZwo4GH/ffuN/6QWC3m4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai Huang , Michael Roth , Sean Christopherson , Paolo Bonzini Subject: [PATCH 5.10 021/545] KVM: x86: Tag kvm_mmu_x86_module_init() with __init Date: Fri, 19 Aug 2022 17:36:31 +0200 Message-Id: <20220819153830.146714805@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220819153829.135562864@linuxfoundation.org> References: <20220819153829.135562864@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson commit 982bae43f11c37b51d2f1961bb25ef7cac3746fa upstream. Mark kvm_mmu_x86_module_init() with __init, the entire reason it exists is to initialize variables when kvm.ko is loaded, i.e. it must never be called after module initialization. Fixes: 1d0e84806047 ("KVM: x86/mmu: Resolve nx_huge_pages when kvm.ko is loaded") Cc: stable@vger.kernel.org Reviewed-by: Kai Huang Tested-by: Michael Roth Signed-off-by: Sean Christopherson Message-Id: <20220803224957.1285926-2-seanjc@google.com> Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/mmu/mmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1340,7 +1340,7 @@ static inline int kvm_arch_flush_remote_ return -ENOTSUPP; } -void kvm_mmu_x86_module_init(void); +void __init kvm_mmu_x86_module_init(void); int kvm_mmu_vendor_module_init(void); void kvm_mmu_vendor_module_exit(void); --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -5886,7 +5886,7 @@ static int set_nx_huge_pages(const char * nx_huge_pages needs to be resolved to true/false when kvm.ko is loaded, as * its default value of -1 is technically undefined behavior for a boolean. */ -void kvm_mmu_x86_module_init(void) +void __init kvm_mmu_x86_module_init(void) { if (nx_huge_pages == -1) __set_nx_huge_pages(get_nx_auto_mode());