Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6d4ae2e-9cc0-a94c-f862-9b2698cf6640@amd.com>
Date:   Fri, 19 Aug 2022 14:04:53 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: build failure of next-20220817 for amdgpu due to 7bc913085765
 ("drm/amdkfd: Try to schedule bottom half on same core")
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     Alex Deucher <alexdeucher@gmail.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        linux-next <linux-next@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        amd-gfx mailing list <amd-gfx@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <Yv1lepjhg/6QKyQl@debian>
 <CADnq5_Od9W1iuzYpsmODOB=Xem97ogeH_t0JrjWC-S8h0XM9fA@mail.gmail.com>
 <5638aaf1-b808-bdc6-d84a-820f24facea6@infradead.org>
 <CADVatmNA6-qCJEHNn-gRO6Nx88SsTrPsJn_F5J0NiFhyvijNxA@mail.gmail.com>
 <c1869a4b-ead1-2ae5-c9ec-61834b578216@infradead.org>
 <CADVatmPCd5KQ0mAfQGHvqVGFJtK+fyQPB4XUktgfc3fzYJvyCg@mail.gmail.com>
 <df284479-9981-9983-7775-81d7d7875dac@infradead.org>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <df284479-9981-9983-7775-81d7d7875dac@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1RHbVY5bWdTV21zRTdtRGJnUDRKamp1RExiTS9oRnZISXFWSWhGamc1U3Ez?=
 =?utf-8?B?NnNvOFkyY2ljVDFUYXl3UFVzUUgxWVBUTVZDU0NCZGFnemVDczhmOThLYzh1?=
 =?utf-8?B?UGNuSVNiT0ZKZWhMeW5ScG5pSjdWdWRvU1FyUDU2VTdrcEM4UnFDTXh1dC92?=
 =?utf-8?B?WUU1dVkrK3FxZEhGeVNVZVBzTDYwcU9uNjY1d0RFVUU5eGVpMFNZZkNETmlq?=
 =?utf-8?B?YmIrb2FyVEwxSDIwTk1iK0JWNUQyQVF0MXFUeUhDQUJ0c0ErVEd2WDBUc2tH?=
 =?utf-8?B?TnJ6ODBCaFlxams5M0JhQUZTQTEzdE1wVEM3NU9lWE9NaFpMRmI0UjduMHkz?=
 =?utf-8?B?STRtcTAralF2ZDZBWDc1WGxWNWZPNm5iVVF2STZ4QUUxVjN3OUtWOHBhelNv?=
 =?utf-8?B?MWtmbFdzeFZsSkxqUmwvenE2MFg4QWI3TVlvaXVmekZKd0tMenlCeVQxcVZL?=
 =?utf-8?B?K29xaTdRR0diR09QclN0NGJQdEZPMlF4cnFUdDlOTy9CMGNpdXBya050SG9S?=
 =?utf-8?B?aXhJMjNDS3p0eU0rYlduUmZTcDU1aU5LN3BHeVVub0FPV3l1Z1hpSzZlS09z?=
 =?utf-8?B?OWNRMzVUM21PdG5GMW9kZnZtUVk0V0UwYXAvclNuWGsvTDE4aWJJaUlTN0tj?=
 =?utf-8?B?bExkSlkwTkFmTWFCa2dJczI4OVhBeXpRYndQSmljQnVGbFpscjJqY2NUMEJC?=
 =?utf-8?B?M1RRWUtuNXBHR3ZZQXcrNm1uVjZ3bndFK1hPZytOU3VOVVJmSXlPZWc4R0RW?=
 =?utf-8?B?QzMzTnp0a2p5WnpzYWlFKzlLUmlsczV4TFBDYmhsRDFyM0FxckNGckYyQlRQ?=
 =?utf-8?B?YlQySllvWnQvQWtTcVBMeFRyK29MZTJnaS9jRWE0bWo0RzNXRVVSR3NQQjYy?=
 =?utf-8?B?U3dIMmNpTEVHVzE0ZmR6NWJJdlovaEFlWmN2TnFSVWs4eDd2L1N4eUN1QWMy?=
 =?utf-8?B?SHRsbnJkZEFXcGh4czhYcmtzZEVWaHQxYStrdGwxMlJHcTB4YVBUbnpHTjJj?=
 =?utf-8?B?OE0waU5OWHRTSStwUmR2ejl4dUwzV2ZoN1JiTkpEREQxQUpMQkkyUWlIbjlJ?=
 =?utf-8?B?WURramRFMWVCRUJ3d1ZlWktoall3UDQrZEhQS1RZbTJ1U1JFWHJIL3NEL1ZK?=
 =?utf-8?B?UHo5aXV6eEZBeGtTclFnNlZsaGF5OCtieDlTT1JmOEJLR0Y5WDBKK0xnaXlC?=
 =?utf-8?B?bHU2R1ExeXV5dDEyWGtNQTZKZlVQdmVyRkJWVFdRclVEM1hsdmI2QmtFcDh0?=
 =?utf-8?B?c1kwRDA0NXUvYXExMzhVK1VoVEFTam9PRmFVc0NuVExyNEZudnI3SGpaMTV2?=
 =?utf-8?B?eHVWU0d2K1F2VTBvQ2VVWlZ5b2htREFxMU9QdEhDT3YrRmpIZmdRWW5JQTll?=
 =?utf-8?B?aWt5NGpmS1NHZEMyYWJxMzFUbXh0TlVSWitFR1NLU3QzQU03M2tjcDc5NXlS?=
 =?utf-8?B?aTM2T09jb0pHelo3MjMwVURjVUU5T3llc3gxcG1Ca1gyODNBVnRmdFhyTDVm?=
 =?utf-8?B?MzVIRjVFTDBrc2dBV3M5Y1ZlYmROR3ZSb3VVRk1xZWh0TE5VcjRYTy9RdUU1?=
 =?utf-8?B?cWlFV1I0TllGbzZEa1gvYjdUQVJkcWJFME9GZU9wNXJFb1FKUjFoYS9sbHZq?=
 =?utf-8?B?N2NrUU5xVzBscTlWODFHUG5wUzJKc05YaTlQYmtXaFBLR3N0SU4yaVBkbm51?=
 =?utf-8?B?UDdrdzJ1NmpCSWdMUithS3dySnpWakI2WnZvRGxkZER3RVk1cUtoOVRZa3ZP?=
 =?utf-8?B?SnNWb2F1WnZReWUvS3lvcnVDZ1lLa0hGeGR1bGFQWDRxY09nMXpLaTJTUFZw?=
 =?utf-8?B?UEZqZTViVk9zTmVtRzVPdmlZT1V0N3ZIdWdMOU11UmFOcVhZUkFvNlREQWVM?=
 =?utf-8?B?VUhJT0ZZMEJJcE1ZUHN6elMyNXo5UWxIcXo1RFcrWkwyUFZuY255OVRydzdv?=
 =?utf-8?B?NkpTTjdCUTEwZ2R2M3NMSi9UVkZnTlI1ZUNVQjdmSnJXYmtMS0l6eWZKSFFR?=
 =?utf-8?B?M2drVXJrakg1WXBaekNkZG9rb3h0VHNDOWI5MXRDOWV6aUVZWk5rSjZMM0dU?=
 =?utf-8?B?QnM2a09XUmNMUHJhSXVRTGJzYWRNamg3Tks4QnZJR2JJSkdVbUxnNGw5SnJT?=
 =?utf-8?Q?p0zOk7RxvzpFFUSGLKfsoC8GA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7cd0d41-00df-49d5-b4e8-08da820d5223
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 18:04:55.2301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GYvbcxaRI7j5uN9UdH1N6eGtnu+ahl2ZpxF8/OWKlSeoQuNOvEYOvLHfRy6VJBA+cFR6SEqB7YiGgaL0zRGPjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6136
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-08-18 15:34, Randy Dunlap wrote:
> Hi--
>
> On 8/18/22 12:15, Sudip Mukherjee wrote:
>> On Thu, Aug 18, 2022 at 4:10 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> On 8/18/22 03:43, Sudip Mukherjee wrote:
>>>> On Thu, Aug 18, 2022 at 3:09 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>>>
>>>>> On 8/17/22 19:01, Alex Deucher wrote:
>>>>>> On Wed, Aug 17, 2022 at 6:03 PM Sudip Mukherjee (Codethink)
>>>>>> <sudipm.mukherjee@gmail.com> wrote:
>>>>>>> Hi All,
>>>>>>>
>>>>>>> Not sure if it has been reported, build of next-20220817 fails with the
>>>>>>> error:
>>>>>>>
>>>>>>> ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>>>>>>>
>>>>>>> Trying to do a git bisect to find out the offending commit.
>>>>>>>
>>>>>> Thanks.  I don't see that symbol in the driver at all.  Not sure where
>>>>>> it is coming from.
>>>>>>
>>>>> It's powerpc only.
>>>>>
>>>>> Sudip, is it non-CONFIG_SMP by any chance?
>>>> Ohhh.. really sorry for the incomplete report. I should not try to
>>>> mail while travelling.
>>>>
>>>> The error is seen with powerpc allmodconfig and it has CONFIG_SMP=y.
>>> OK, I see that also, but it doesn't make any sense (to me).
>>>
>>> I did 'objdump' on the code file (amdgpu.o) and it's listed as
>>> undefined but there are no code references to it.
>> cpu_smt_mask() is called by drivers/gpu/drm/amd/amdkfd/kfd_device.c.
>> and cpu_smt_mask() is an inline function in
>> arch/powerpc/include/asm/smp.h which is doing "return
>> per_cpu(cpu_smallcore_map, cpu);"
>>
>> So, the offending commit is 7bc913085765 ("drm/amdkfd: Try to schedule
>> bottom half on same core").
> Thanks for digging that up.
>
> It just needs to have that symbol exported I think.
> This builds cleanly now.
> I can submit it or one of the AMD gfx developers can do so.

I'm not sure where I would need to submit this. And I'm not familiar 
with Powerpc code at all. I'm OK if you submit this wherever it needs to go.

Thanks,
   Felix


>
>
> ---
>   arch/powerpc/kernel/smp.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -86,6 +86,7 @@ DEFINE_PER_CPU(cpumask_var_t, cpu_core_m
>   static DEFINE_PER_CPU(cpumask_var_t, cpu_coregroup_map);
>   
>   EXPORT_PER_CPU_SYMBOL(cpu_sibling_map);
> +EXPORT_PER_CPU_SYMBOL(cpu_smallcore_map);
>   EXPORT_PER_CPU_SYMBOL(cpu_l2_cache_map);
>   EXPORT_PER_CPU_SYMBOL(cpu_core_map);
>   EXPORT_SYMBOL_GPL(has_big_cores);
>
>