Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp1953917rwb; Fri, 19 Aug 2022 12:19:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR59NYPq9j/CECdkrn0MJmKV3bLMszkSTA7M5qVFqdZ7bXo1KCu6bn6t3kCS9KvEQjEa8xU5 X-Received: by 2002:a17:90b:390c:b0:1f5:5bbc:2e8 with SMTP id ob12-20020a17090b390c00b001f55bbc02e8mr15771048pjb.233.1660936772392; Fri, 19 Aug 2022 12:19:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660936772; cv=none; d=google.com; s=arc-20160816; b=h9wXGPwp+Y2F0godKvzjqg/y7N2X3kU6Es/AmXekwVpoVKsnz+P66G7+IAYcZZvbn0 wiFU83VPFP1uYlD+1pAk3WMHrK16Kug+HLizDO++9J8I2Fjt98IrxbSPuKtfZ5X2DbXg 8i9jdwcEy//R0LEwftv/v2tAeTIR5xKoLpmaU4cualxgG3Y6oNMKOTrQ7wjCJLLC42cn SW1pJJFTRY5tgfRJtLY1b7s0P7/l87VGp0+VXZc7kw5GSIW5LNdOrIjNocEwgThvvZeR 6OvDkDA/rXzcrsBhiRyP7TlvCuPo0ci4HUXH72Pv/xXundYGIMyP7lhG+uzw/5GXO3N/ jA1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NY3og6uVOGIRfydWAoiK8DTzipQrxXXqtzrWPkrx8rE=; b=W1vz+IXuR+WtpyTzWI5YtU/p8hnyoQzixDVri3UIG9ezzXTs0yTEz/OeqlJsRl5TXq cwQ3aoKT+ln4MG0n29r6vOsgErRFWLdsE9oKD7XJfwgqrQSyOxBFDytkvpjlQsqcdVuI 1NCQNCRgLRbdqt80KNH3XMSht/ehkmfqlK2llVaqP45OSER7RWwfLCTTqjcteNwXw6OQ JRQrBMWkYFcCb4mYcEPFRDNzvCok5d4SobZl0y3V7AcRmkqWoXGGG3nFqAjH8c4mWPLS fhWJGq5kjRcuitypJKNzFJMs9RLFybApX28SPSh3j5lRYCVPi0dNv9PpEmop/xKuS6ld hJtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VJQxFgKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63b748000000b00429fc7c9640si5058450pgt.258.2022.08.19.12.19.21; Fri, 19 Aug 2022 12:19:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VJQxFgKA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351141AbiHSTIr (ORCPT + 99 others); Fri, 19 Aug 2022 15:08:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351114AbiHSTIa (ORCPT ); Fri, 19 Aug 2022 15:08:30 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E414A48C80 for ; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id y127so2138861pfy.5 for ; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=NY3og6uVOGIRfydWAoiK8DTzipQrxXXqtzrWPkrx8rE=; b=VJQxFgKABXidqeK6PcYka/SLJnrMhsN5piLG5aBGrmKOX55QepEObQ88MWMkZXJH0H MiYLtWEBXs8MGcNVMdwZMFOJBshSIXYwtMBZzDrFt9ptpY6CdufVoVXJu16TZ0tajZkv YxXPq9YarjoNbmyvcRjmrlu7hctfeeWFP38yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NY3og6uVOGIRfydWAoiK8DTzipQrxXXqtzrWPkrx8rE=; b=TFkIhEj++Mhbl6cVY8o/BtpMhpwBNOedrwEyJB7LiSTlErXlLIDb8Jgm8kt0PcrBl9 iFbQoHH/h+9JlpL//X0thEwZmXdS9e9wT/Rq0lDAqynWTPzpp6H3fRpekzpvW2CQ8ZfP xnbchgMv3KOpY0IdBYL/6+wB0/t5BaLqewUNbbUZi+vMovJGNMO7VAOvYDWJZOHhKA3o dq+N/d2ogUDPrMdU453pYZuxK3dw6gD8iVnsf++8Tx44WxHBmAQ0JYDJQjM08MDGn1vx 37M76NcIg/yet2KnOGDqGowoSd5EQoDMPl4SlB5X/6NMXQvpeeyjw5/q9iRGKX/g+dcX HTrQ== X-Gm-Message-State: ACgBeo38yPdLTX+h94qBZPLT+17L0edSvib3MxacoD6qsN/9QJeDNvNU M/ySamLtauYlHh89E8HkGXg+oThUMp4Xew== X-Received: by 2002:a63:6b02:0:b0:422:7cf8:4bf with SMTP id g2-20020a636b02000000b004227cf804bfmr7501437pgc.92.1660936108315; Fri, 19 Aug 2022 12:08:28 -0700 (PDT) Received: from pmalani.c.googlers.com.com (137.22.168.34.bc.googleusercontent.com. [34.168.22.137]) by smtp.gmail.com with ESMTPSA id b14-20020a170903228e00b00172a567d910sm3499775plh.289.2022.08.19.12.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 12:08:28 -0700 (PDT) From: Prashant Malani To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: bleung@chromium.org, Prashant Malani , Enric Balletbo i Serra , Guenter Roeck , Heikki Krogerus Subject: [PATCH 2/4] platform/chrome: cros_ec_typec: Correct alt mode index Date: Fri, 19 Aug 2022 19:08:03 +0000 Message-Id: <20220819190807.1275937-3-pmalani@chromium.org> X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog In-Reply-To: <20220819190807.1275937-1-pmalani@chromium.org> References: <20220819190807.1275937-1-pmalani@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alt mode indices used by USB PD (Power Delivery) start with 1, not 0. Update the alt mdoe registration code to factor this in to the alt mode descriptor. Fixes: de0f49487db3 ("platform/chrome: cros_ec_typec: Register partner altmodes") Signed-off-by: Prashant Malani --- drivers/platform/chrome/cros_ec_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 4d81d8d45b73..dc5722db2066 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -698,7 +698,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_ for (j = 0; j < sop_disc->svids[i].mode_count; j++) { memset(&desc, 0, sizeof(desc)); desc.svid = sop_disc->svids[i].svid; - desc.mode = j; + desc.mode = j + 1; desc.vdo = sop_disc->svids[i].mode_vdo[j]; if (is_partner) -- 2.37.1.595.g718a3a8f04-goog