Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ad5cdb5-3f72-1305-b509-d0f68943b618@gmx.de>
Date:   Fri, 19 Aug 2022 21:30:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] parisc: handle failure of kmalloc in ccio_init_resources
Content-Language: en-US
To:     Li Qiong <liqiong@nfschina.com>,
        "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
        yuzhe <yuzhe@nfschina.com>
References: <20220819041510.75473-1-liqiong@nfschina.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220819041510.75473-1-liqiong@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/19/22 06:15, Li Qiong wrote:
> As the possible failure of the kmalloc(), it should be better
> to fix this error path, check and return '-ENOMEM' error code.
>
> Signed-off-by: Li Qiong <liqiong@nfschina.com>

applied.

Thanks!
Helge

> ---
>  drivers/parisc/ccio-dma.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> index 9be007c9420f..f69ab90b5e22 100644
> --- a/drivers/parisc/ccio-dma.c
> +++ b/drivers/parisc/ccio-dma.c
> @@ -1380,15 +1380,17 @@ ccio_init_resource(struct resource *res, char *n=
ame, void __iomem *ioaddr)
>  	}
>  }
>
> -static void __init ccio_init_resources(struct ioc *ioc)
> +static int __init ccio_init_resources(struct ioc *ioc)
>  {
>  	struct resource *res =3D ioc->mmio_region;
>  	char *name =3D kmalloc(14, GFP_KERNEL);
> -
> +	if (unlikely(!name))
> +		return -ENOMEM;
>  	snprintf(name, 14, "GSC Bus [%d/]", ioc->hw_path);
>
>  	ccio_init_resource(res, name, &ioc->ioc_regs->io_io_low);
>  	ccio_init_resource(res + 1, name, &ioc->ioc_regs->io_io_low_hv);
> +	return 0;
>  }
>
>  static int new_ioc_area(struct resource *res, unsigned long size,
> @@ -1543,7 +1545,10 @@ static int __init ccio_probe(struct parisc_device=
 *dev)
>  		return -ENOMEM;
>  	}
>  	ccio_ioc_init(ioc);
> -	ccio_init_resources(ioc);
> +	if (ccio_init_resources(ioc)) {
> +		kfree(ioc);
> +		return -ENOMEM;
> +	}
>  	hppa_dma_ops =3D &ccio_ops;
>
>  	hba =3D kzalloc(sizeof(*hba), GFP_KERNEL);