Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 22:20:47 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        Alexandru Ardelean <aardelean@deviqon.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 13/14] iio: max1363: simplify using
 devm_regulator_get_enable()
Message-ID: <1286ea127d190e5708a0aaff271819b2d3f8802d.1660934107.git.mazziesaccount@gmail.com>
References: <cover.1660934107.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cC7KBBHJIm82dlyL"
Content-Disposition: inline
In-Reply-To: <cover.1660934107.git.mazziesaccount@gmail.com>
Precedence: bulk


--cC7KBBHJIm82dlyL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
add_action_or_reset(regulator_disable)' and use the
devm_regulator_get_enable() and drop the pointer to the regulator.
This simplifies code and makes it less tempting to add manual control
for the regulator which is also controlled by devm.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---
v2 =3D> v3:
New patch
---
 drivers/iio/adc/max1363.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index eef55ed4814a..d900e29d6cb7 100644
--- a/drivers/iio/adc/max1363.c
+++ b/drivers/iio/adc/max1363.c
@@ -169,7 +169,6 @@ struct max1363_state {
 	const struct max1363_chip_info	*chip_info;
 	const struct max1363_mode	*current_mode;
 	u32				requestedmask;
-	struct regulator		*reg;
 	struct mutex			lock;
=20
 	/* Using monitor modes and buffer at the same time is
@@ -1603,15 +1602,7 @@ static int max1363_probe(struct i2c_client *client,
 	st =3D iio_priv(indio_dev);
=20
 	mutex_init(&st->lock);
-	st->reg =3D devm_regulator_get(&client->dev, "vcc");
-	if (IS_ERR(st->reg))
-		return PTR_ERR(st->reg);
-
-	ret =3D regulator_enable(st->reg);
-	if (ret)
-		return ret;
-
-	ret =3D devm_add_action_or_reset(&client->dev, max1363_reg_disable, st->r=
eg);
+	ret =3D devm_regulator_get_enable(&client->dev, "vcc");
 	if (ret)
 		return ret;
=20
--=20
2.37.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--cC7KBBHJIm82dlyL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmL/4o8ACgkQeFA3/03a
ocU5yAgAgK2Nt6SPIs45tZgSmQ3sttM72aM1RgJ8PaRyzr0iVPEv9Rr1MK6/9Z9u
opF00Mt5nmUMlc2sRo2eLti1N7MFVEn8cYOpW2Cc+DSC6rwHSnguJwQASfmj7P1N
DR0nF55ZLuMkN5OFWP52YKFfvSOyIlHFY8PYD3btMTJvUopqxZOhQdJnxBjcSK+j
pQGUFwv6x88XJYhMKTCQAftUNFeEDfBGJ7pNE3x7XoqCP9K/ReNd+vzcseCloVa2
l6Rt7oc52ADt2WiGtVu1sUQq7QNBOmEHwqlT9u6WbIYRdgeGhAg8WZTc6QkmHkMb
+tr9/0CmKkypKujU9qGLmXK+/y9Jaw==
=1ejk
-----END PGP SIGNATURE-----

--cC7KBBHJIm82dlyL--