Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 22:21:02 +0300
From:   Matti Vaittinen <mazziesaccount@gmail.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 14/14] iio: hmc425a: simplify using
 devm_regulator_get_enable()
Message-ID: <8b1193fdefb231a6d721e2bded52c48e56039c20.1660934107.git.mazziesaccount@gmail.com>
References: <cover.1660934107.git.mazziesaccount@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="n0FtiIFG1DkzGVCH"
Content-Disposition: inline
In-Reply-To: <cover.1660934107.git.mazziesaccount@gmail.com>
Precedence: bulk


--n0FtiIFG1DkzGVCH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
add_action_or_reset(regulator_disable)' and use the
devm_regulator_get_enable() and drop the pointer to the regulator.
This simplifies code and makes it less tempting to add manual control
for the regulator which is also controlled by devm.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>

---
v2 =3D> v3:
New patch
---
 drivers/iio/amplifiers/hmc425a.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/iio/amplifiers/hmc425a.c b/drivers/iio/amplifiers/hmc4=
25a.c
index ce80e0c916f4..108f0f1685ef 100644
--- a/drivers/iio/amplifiers/hmc425a.c
+++ b/drivers/iio/amplifiers/hmc425a.c
@@ -34,7 +34,6 @@ struct hmc425a_chip_info {
 };
=20
 struct hmc425a_state {
-	struct	regulator *reg;
 	struct	mutex lock; /* protect sensor state */
 	struct	hmc425a_chip_info *chip_info;
 	struct	gpio_descs *gpios;
@@ -162,13 +161,6 @@ static const struct of_device_id hmc425a_of_match[] =
=3D {
 };
 MODULE_DEVICE_TABLE(of, hmc425a_of_match);
=20
-static void hmc425a_reg_disable(void *data)
-{
-	struct hmc425a_state *st =3D data;
-
-	regulator_disable(st->reg);
-}
-
 static struct hmc425a_chip_info hmc425a_chip_info_tbl[] =3D {
 	[ID_HMC425A] =3D {
 		.name =3D "hmc425a",
@@ -211,14 +203,7 @@ static int hmc425a_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
=20
-	st->reg =3D devm_regulator_get(&pdev->dev, "vcc-supply");
-	if (IS_ERR(st->reg))
-		return PTR_ERR(st->reg);
-
-	ret =3D regulator_enable(st->reg);
-	if (ret)
-		return ret;
-	ret =3D devm_add_action_or_reset(&pdev->dev, hmc425a_reg_disable, st);
+	ret =3D devm_regulator_get_enable(&pdev->dev, "vcc-supply");
 	if (ret)
 		return ret;
=20
--=20
2.37.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--n0FtiIFG1DkzGVCH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmL/4p4ACgkQeFA3/03a
ocWC5wf/dLaY0o4KfYk2D/JFl0YNKp7J4iOndU/+1ot/7R+IZwIFzuTHW3wsoEJz
VMtS7tLRUYPPQoRyjbT1WOO6qTGwD+rNDeIOUqDaoBylUukdFoCTdQFPdxDRjdp7
NYoXLJ9ww6heT18dLLk3Z5ClPeKOdKe+Yb9WpoRO68l9R1fpb23vyRFEwYVRjCoI
8/R/3YP5qDob4TdO3ATZnZPjzJusU+zbxP4Kk9AtZrt3y8+GDIsEwz5iWPMMUXDO
qde4UJJMJjDTN23AhU/BYdi2VVsAgg9sJfHSSv11vXgUlR7fD/0RVi7x9cHxBTmP
faqUSXrx6OtvA76u5MyIj/itBxh0DQ==
=Wxo4
-----END PGP SIGNATURE-----

--n0FtiIFG1DkzGVCH--