Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10e7f147-6f7e-76ad-02f9-2db32c533953@gmx.de>
Date:   Fri, 19 Aug 2022 21:26:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] parisc: move from strlcpy with unused retval to strscpy
Content-Language: en-US
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        linux-kernel@vger.kernel.org
Cc:     "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        linux-parisc@vger.kernel.org
References: <20220818210055.7181-1-wsa+renesas@sang-engineering.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220818210055.7181-1-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=3DwgfRnXz0W3D37d01q3JFkr_i_uTL=3DV=
6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

applied to parisc git tree.
Thanks!
Helge

> ---
>  drivers/parisc/led.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1e4a5663d011..d4be9d2ee74d 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -646,7 +646,7 @@ int lcd_print( const char *str )
>  		cancel_delayed_work_sync(&led_task);
>
>  	/* copy display string to buffer for procfs */
> -	strlcpy(lcd_text, str, sizeof(lcd_text));
> +	strscpy(lcd_text, str, sizeof(lcd_text));
>
>  	/* Set LCD Cursor to 1st character */
>  	gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);