Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2085185rwb; Fri, 19 Aug 2022 15:07:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR4SIN5Xb+/vhoUIeG7Aiq2qsqvkwprVIwLFV5Mxqan2iyQlV2EUHFycxZDNzuexGs5jSkGP X-Received: by 2002:a17:90a:318f:b0:1fa:a374:f565 with SMTP id j15-20020a17090a318f00b001faa374f565mr16094818pjb.146.1660946826959; Fri, 19 Aug 2022 15:07:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660946826; cv=none; d=google.com; s=arc-20160816; b=P3ZLmWBar3aKgAOV1K7FHI+XefmHKxQiRAq68UkEnbwzJp6oeWwgBYEQK52WOg8ZD0 2Y8/nWMP0MT0llACsfJbF3XHM6xCDp9+MEFydaB+CY4eUEtKt9dqvgULoLCgzEwmH3fz tRmfN9hA3tMdu6trJC5LGMXHlCYga5hONOJoVB8tn2X8K6KyFCcQ7+ZmMKbIbqjPF+GI +LsLMgWidVjmrmtlkhiFlN58ld6ylm0sv+GvkEn/t6CjLD6WbOK4s6d0vGD+kIrcCXXh QRyKc39hV/ww6Oa9GG914vElzvPxu7eCg3h9KxX2J9s5phVR1tK594F8sgsP5/4bjKAR MrwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=jp2q8+wHvNQOixYx4PKbIaPjNkYkkJRhsagfB6IVqbE=; b=F2f9Zw9qHW/+fniZO7PnTxhUe2slBexCCEF4V98Kf1d/AklTWtAaLJWotL/naWrBkF GwIG5k1lkJpdeVkL0SGExBXlXxip55gqktqwmI1FYo+TmKUVnOFQo8KKaKpnxy5CRTbI lFX/jMZeUIpLzAP+w9I0njWAxbWkaP4Yi6rPVmsYM2LXUBnIt/cyFcl06IophptNwEtQ I/vzBk9jTBl6G2dv9ZOBdWrMVlgY4dSBLFx0+J9/HV+yVZt1jRAmWRBmJ/Qmz9/CZQX7 3eBruLrxSeknSEbLRuvW1tP7p0utRRYKVlkYfO6hmHjleKiP8uTCBq6zCMqUiavyNWTS ne0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=PPmhQwtB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a17090a850800b001fac555a329si4888380pjn.166.2022.08.19.15.06.55; Fri, 19 Aug 2022 15:07:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=PPmhQwtB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235211AbiHSVyz (ORCPT + 99 others); Fri, 19 Aug 2022 17:54:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiHSVyx (ORCPT ); Fri, 19 Aug 2022 17:54:53 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0419DB56E5 for ; Fri, 19 Aug 2022 14:54:52 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id h20-20020a056830165400b00638ac7ddba5so3911565otr.4 for ; Fri, 19 Aug 2022 14:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=jp2q8+wHvNQOixYx4PKbIaPjNkYkkJRhsagfB6IVqbE=; b=PPmhQwtBns0UgyOPryIOLzd4HAKVCFqN2ePPjyg7KUrvexio/mO780s7hYZIdav8VA ofv2yYu2kRM+d/fARgdaREQW7gT9+hs6/1Us91wLeLXSq+JlkqFNbn9LhJMcAqIAm7iQ ZglsA+78ZnGHsi+8z0ttBhHa5hOMdyYde/NX3WbqBrQHGODkF1XkeiQ12wY2kPembcvs SGgtXPK7Hh7JuEeoYMChxK6LpZKvHsTgLvwW73cWebWTSZKtIgZL7oMi3hYS2K0PEYLM AeZDsZbGMcfy7iEXTGjiNJ4HJKs7Z/Adt6IJAj6CagE1KCbiVRYrHT229QRx5Z5dTeGh YNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=jp2q8+wHvNQOixYx4PKbIaPjNkYkkJRhsagfB6IVqbE=; b=BOqPSyC8pwaNfTYcGKz6Ca2D9FLR9co4gGeJHaamdxhFDL0kBUNa38nhxKk30DCq8s 3Pr1QmMl+f8zd/D/leWt2aYJKpaiiq75z/W2Yd36KEcXVYgstzhjbYR0iox7alp/IdMX fBTeeCIfUqo8mA8aqXLu7BSHanyqbsBkvbjFnhPt0HRCWiMmpGRv0I5RwlQlub+ZT4Rq 9B0bEannsI09kJoh38cczpP07nOUJwMR0PcIkkP8Gk6FQ36RwKikS4/DSLZCHDxYeZwa As2PXBUaMiM/1RSfn4uvLA8SjCONRYjedK+yMu49HjCWgRRxqF3qWp+GHeXVsshtMPLp 6itw== X-Gm-Message-State: ACgBeo1IzJgWZaMCgHEJ7HDnFLclLru8oLGl40NNWcTHRzu+erRhXH7P EncTOkRlT0cbVKWy/zVvKB36cSYowlK67wtLN873Dg== X-Received: by 2002:a05:6830:2a8e:b0:638:c41c:d5a1 with SMTP id s14-20020a0568302a8e00b00638c41cd5a1mr3877418otu.367.1660946091212; Fri, 19 Aug 2022 14:54:51 -0700 (PDT) MIME-Version: 1.0 References: <20220819182258.588335-1-vipinsh@google.com> In-Reply-To: <20220819182258.588335-1-vipinsh@google.com> From: Jim Mattson Date: Fri, 19 Aug 2022 14:54:40 -0700 Message-ID: Subject: Re: [PATCH] KVM: x86: Fix mce_banks memory leak on mci_ctl2_banks allocation failure To: Vipin Sharma Cc: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 11:23 AM Vipin Sharma wrote: > > If mci_ctl2_banks allocation fails, kvm goes to fail_free_pio_data and > forgets about freeing mce_banks memory causing memory leak. > > Individually check memory allocation status and free memory in the correct > order. > > Fixes: 281b52780b57 ("KVM: x86: Add emulation for MSR_IA32_MCx_CTL2 MSRs.") > Signed-off-by: Vipin Sharma > --- Reviewed-by: Jim Mattson