Received: by 2002:ab3:689a:0:b0:1da:d01c:d2b2 with SMTP id t26csp6774ltj; Fri, 19 Aug 2022 16:01:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR4e8DBD3EV+Yiok5X/A+kT3J2FuLBUuVZQAzUFfKtjhS5GbKSlhoW4DtjKRpF/9EALBzolh X-Received: by 2002:a17:90b:4c52:b0:1f6:3a26:9f08 with SMTP id np18-20020a17090b4c5200b001f63a269f08mr10915711pjb.206.1660950088728; Fri, 19 Aug 2022 16:01:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660950088; cv=none; d=google.com; s=arc-20160816; b=ZWK2uQaLYBAZwHFMBcq03sWdXIsuxWDYcMJi2Vss69s7LNTKHHbFnaOlDUMkCOV5X/ VseL8e80iSB6LTAihG6ktB1o+VtNViPMLnmwKWAf7HFwkLtRZeVxYE4cpLWmcLyl1MW1 b2G1bwW3XhW4bnWKuLlkR6UIEAEqzSyPrMciL+nLZxcO3jWWfIRlH2iVEkV33Ys+SVdH Xvs+NOE3fzpKsUOlx6QbWHyD1mFb0Nge8CISdIpLr7ttqzfpgqj/uZvPopFJRnI6OLmz eGZnBGGLSvNm0y1WnFFNExXHSfkZhJe7xi1Th5G0z/UJpn73G9hrgyY4OkU3s2jtphIE Fuuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2R6bEzH5X0US7SIr2pmnzxk7xcQvF8aF0RXjZAvGoE0=; b=c9AcCBXTLVTKsTbBfNHJ5Ech/hhRx3HvP7h8eruTLGoIEKrtrEyqRhSvg+uNbAH2+j L5AfnYDU0HQACLQMXruI19JONT9M6u1rgHMF4mL91lGFrT7cKGTYz7IuVqZFWuA+Sw8D sFSwbc4kAN59Nsl6r9CUXisfgQpQMrMVEqo1murcMERRIqluTqXAeP2esTfx+WP2NcVm oZKzyuMyVRzzf+QmB2RdX+YlyzHuTiVIu+6ah3/NCr+L0nlPwWdvsdclG9Z+b3LEuoRj A+K8q2NmLGfpGx3Rt1mINu1bA3ys5ETlCoaz6kyBopBtU/9mrdEN9lAmVF7O9HyqhWE0 hWmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SSxNMzpl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w190-20020a6382c7000000b004218caaa6aesi5035217pgd.345.2022.08.19.16.01.16; Fri, 19 Aug 2022 16:01:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SSxNMzpl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243088AbiHSWsv (ORCPT + 99 others); Fri, 19 Aug 2022 18:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242959AbiHSWst (ORCPT ); Fri, 19 Aug 2022 18:48:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86F01753AD for ; Fri, 19 Aug 2022 15:48:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23B8E61831 for ; Fri, 19 Aug 2022 22:48:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFFEC433B5; Fri, 19 Aug 2022 22:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660949327; bh=gJJMr+uLwUVCPzts92iC8fkEyz8iwbsHjS9H2CKktno=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSxNMzplA2gu4/xhcncDwTntKN9odHWKv95YC8+mNoUC5/3g6X5a23RegRJeNi6Ae bQfRD7nZsqSn/MtcxQnhRtJtLVpD93A0rnd+ONj1o7+RoOQyPyg7WHv+bu66WDZupE WRn+wKzi3wq96SMg9f/LyxBmM9lN0FrY62EIDgRK5uHQnB1zOnETtyiq56KujueYI+ i2J46Bs1SDx5ch5Ec0geLQU87AtRdDtifjlszVQfzuFtJ4aRhdLCOtkcGWYAYdJlcV zkiYOva1IbPpnNh/3cCymf8Q+3dqDz61VGy+XgyKj5tN56MDKMdwsOC2Hk6/D/YA2A ErCT/L78dsLwQ== Date: Fri, 19 Aug 2022 23:48:42 +0100 From: Mark Brown To: Andrew Halaney Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, bmasney@redhat.com, dianders@chromium.org Subject: Re: [PATCH] regulator: core: Clean up on enable failure Message-ID: References: <20220819194336.382740-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P7YyzzYVLd5ZYWMp" Content-Disposition: inline In-Reply-To: <20220819194336.382740-1-ahalaney@redhat.com> X-Cookie: Process promptly. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --P7YyzzYVLd5ZYWMp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 19, 2022 at 02:43:36PM -0500, Andrew Halaney wrote: > - if (regulator->uA_load && regulator->enable_count == 1) > - return drms_uA_update(rdev); > + if (regulator->uA_load && regulator->enable_count == 1) { > + ret = drms_uA_update(rdev); I am vaugely surprised and a bit concerned that drms_uA_update() can fail... --P7YyzzYVLd5ZYWMp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMAE0oACgkQJNaLcl1U h9A1PQf/SxzOvIgno1rey/F4HXQL7HDaiadmoJVdsBE+O8gVCb7rcCSeZTbYAmfz bYvnjFbeL7EOxKdN9+fsKQGcRMtZik6hrXO3BICTE8IsdgwgzDROL8US6+B9fNTa GSI1QysdkGUfaHbtUxw2xfAqz2fZuc21yBbsT3jDo1iJsAM0evCH04aYj3xE0h6G gBkTeHuMexyvJY+h1onqQ+ZL8Vx5G41K1m38bTbkV2loc/YCpkdNWmxEmdTxA19u LUzhE4JVuIISCoPDMcy6xLC4yQWqgi87oibEMOj1fSyT6NwkoeSx5zcersyviWuG 4zIG8LKxrK7l0Pla3vZjHN/+R6vbAg== =9N9/ -----END PGP SIGNATURE----- --P7YyzzYVLd5ZYWMp--