Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20b88926-3252-cc70-a39e-9fa76a6f49c9@amd.com>
Date:   Fri, 19 Aug 2022 18:14:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     "Gautham R . Shenoy" <ego@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org, amd-gfx@lists.freedesktop.org,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>
References: <20220819210112.7924-1-rdunlap@infradead.org>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <20220819210112.7924-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z29hdTF4eCt0dENyYXpjazd0bUNCcUFpYkRjaUJTRjR0bEMxK2lRVExlbnZY?=
 =?utf-8?B?S0pRUEYwa3R1OVllVGR3SkR2WHlBSUhGMFFpZlM1ZlNaV0xZbEdaL0xOeFFN?=
 =?utf-8?B?bnExOVU4V3NxUy93UkV1amx4dHh0SmRhenBTSnB5Q1M4REwrbGo2VlpFcHNq?=
 =?utf-8?B?M2hrd2FRR1NsS1FidFpHV1lCYVZ3aE01THFxYkZocW1pTHhtZUZzMG1jUW0v?=
 =?utf-8?B?dGgxU3BsYVI4Rkk5K0cxb2xuVDY1MnZlYzRpTnpCYklTU2ovbVdrZGhHNUdU?=
 =?utf-8?B?QmNXY1o2UGpHMzBieFV3RUZLYllrUzg5dFFMOEdHVy94WmpFK0VveURqeGxC?=
 =?utf-8?B?bUdZSjFMQk5tbWxRK2pCRXAxbHMwOUpDOVRlUDIvcThONkZRa1VJSEFjMXV0?=
 =?utf-8?B?Mi9xc1lkVC9LVWR4Qy9yL0V3dEhjWnJGbFNjTXR2K28vTlBmenBic051QzJ1?=
 =?utf-8?B?aGRzVmEzTUFta29xL0c5Z1JBVWgydkpwWnI4bTJ3ckFVVWVQUURwVjhXc0JJ?=
 =?utf-8?B?ZjMyYzNXMWs2UnpjZWtMdXdpZGx0ZmErc1ArSkl1OEhweDhWV21SSlQzUW0w?=
 =?utf-8?B?L3JKbTZLTElQQkVGOGlIWnZVeVBjNCs1dFd3Z1BIZzhXNmczOXEzcmI2UkYy?=
 =?utf-8?B?WWFTZTJqUTVnbGhFb0pkK08yazB2bE1FK0lpK0s1d1JINHFjNWduZG5DU3hz?=
 =?utf-8?B?cXFoaHRkVXdwY2xzSXBMb1ZHTEk1QWJMdVA4OW00aU9qbHk3Zyt2MXRLVVJN?=
 =?utf-8?B?RFBUWmNyTmxIR0o0aDR0ekZpVHZsMzZ1MmQybVhXZFpUZmJUTkpJQzhFd09T?=
 =?utf-8?B?Q1owQmc2Y3Y3RVlDU3VlRU42VkJCSFpLZUg0TDFMb09NNlJ4Zy9uZUJuR0NW?=
 =?utf-8?B?VzRycDA0OEJrNkJIMEx1cjh0RWYyeVhwQWMvZW5mOEFkWk4wWlhxV0J4UFQ4?=
 =?utf-8?B?Si8xM1BWTTBuNGZMem1KZmZIMkpZMUpxK1lqcFhlV2RXclQxZEFtODN2cWxv?=
 =?utf-8?B?NXk3eGFPZ1RPTit1OEk3OXI1MUVSbW42SFVOdjB5bmVUV2dBTnVPVGFzcDUw?=
 =?utf-8?B?MHNiTEhXSmZWT3RKMlUxeVBySnRmQTlMZjNuUWtMaTk3amNOZm01cmdSODd6?=
 =?utf-8?B?S0tQKzA4bGFRY1pWeEJKVnhyUWttS2NSVEY0V3hVRVRZeWNwNGhLNGJ0d0dX?=
 =?utf-8?B?UmtHQXJoMDRUdkczdGxzbnFHeVVBaUlzeWJxOHY0cy8xVUlkNEdkQTN2OUta?=
 =?utf-8?B?eElIMXhlU3g5MnoxYWkwZGYrK25LcUJ5SUN0K1Y0K09ENlhRdWtHd2VVWnJ2?=
 =?utf-8?B?Tlp6aUdyZTA3M0xZQWJ3QVJqNXZsZDFnaEIrTFU4Q0FmUUoxYWhQK3RkVVdl?=
 =?utf-8?B?eFBmeTRhdzM1QTIvK0ViNVp1VER4QzBnTG9DWVdkcTZFRGU0bWZRdkdIQ2Rs?=
 =?utf-8?B?eVU3Z0NhTGt4d0wwYS9sZXo1VXZReC9kWS9VWlNsS0Q0ZW1TWFRMVnE4cDJ5?=
 =?utf-8?B?Rm9mQm93Q3E4YnRlUkFBL2UvTm5URk16Nm5OOVlWVFUxOXU3Q2p4VXZYanpo?=
 =?utf-8?B?ZUNBUWI3RFV6S2dEMmcxOFJSaXd2d2NldlN5V0ZzRTNEZUp0MlFrNEd0RXVa?=
 =?utf-8?B?U3Vpb0dtTmRmQjgvWm5LcTBqcDhxSDJsQ2wzeGw5azQzRzN4Z1FseTBzVmZT?=
 =?utf-8?B?ZFY5dTE0QUc1MkJzMy8yblZBQkNMeTZpM0ZxeHRndGRwM3AyM2YyMVRFaDZM?=
 =?utf-8?B?cWU1d2dUM0x4cGo0K3dMY1R5QTN2VEtFSllSU3Btc0s0eXBVMVJjOUJLc2U2?=
 =?utf-8?B?djFnTmdZUkYyUXIrdE1jdlA0cy9qWVR2Zjd5RFdFa2ZDSk5QUFlML3EzMU9j?=
 =?utf-8?B?ZkViaGFmZmF0S2hCWk1vZE1WZFM3UktKdWxZN0pBMjN6dmpuUktSQnloSER0?=
 =?utf-8?B?QllEVHR6ejVvWmhRaTZ5b09jbHBYc0hOL0E1alpQM3hab3E1ak5wR0NzWG50?=
 =?utf-8?B?L1FJTTFoU1I2Uy8wS1ZkbTUweExiQi9tWGdBUS9lQVNWbzdtNFdGK2VNMVIw?=
 =?utf-8?B?a3c3YWRLRXBFaGVzTE05U2dNVXBEYTBDN2dxeGRlZXkxNktkQ2Rld2VaVFln?=
 =?utf-8?Q?Ahv44/c51LdDI2j0+1d4J2y/f?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d29d9d66-ff1e-4fd2-5287-08da82303c67
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 22:14:51.0885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7DPayuRARk8S1FGVaG5hC8tmlm5WKPhwUw8bb88zKetw/n3jZtc0CUyfpDE92Fl4F0vNugnv4gjI99CuojDl8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2527
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-08-19 17:01, Randy Dunlap wrote:
> Fix build error when CONFIG_DRM_AMDGPU=m:
>
> ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> by exporting 'cpu_smallcore_map' just as other per_cpu
> symbols are exported.
>
> drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> This is an inline function on powerpc which references
> cpu_smallcore_map.
>
> Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: amd-gfx@lists.freedesktop.org
> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>

Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   arch/powerpc/kernel/smp.c |    1 +
>   1 file changed, 1 insertion(+)
>
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -86,6 +86,7 @@ DEFINE_PER_CPU(cpumask_var_t, cpu_core_m
>   static DEFINE_PER_CPU(cpumask_var_t, cpu_coregroup_map);
>   
>   EXPORT_PER_CPU_SYMBOL(cpu_sibling_map);
> +EXPORT_PER_CPU_SYMBOL(cpu_smallcore_map);
>   EXPORT_PER_CPU_SYMBOL(cpu_l2_cache_map);
>   EXPORT_PER_CPU_SYMBOL(cpu_core_map);
>   EXPORT_SYMBOL_GPL(has_big_cores);