Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 15:44:51 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     SeongJae Park <sj@kernel.org>
Cc:     gregkh@linuxfoundation.org, badari.pulavarty@intel.com,
        damon@lists.linux.dev, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] mm/damon/dbgfs: avoid duplicate context directory
 creation
Message-Id: <20220819154451.9f424d9d563969d9cc6437f7@linux-foundation.org>
In-Reply-To: <20220819211631.16658-1-sj@kernel.org>
References: <20220819140809.1e3929fd8f50bfc32cae31d3@linux-foundation.org>
        <20220819211631.16658-1-sj@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 19 Aug 2022 21:16:31 +0000 SeongJae Park <sj@kernel.org> wrote:

> > It would be simpler (and less racy) to check the debugfs_create_dir()
> > return value for IS_ERR()?
> 
> I was merely following Greg's previous advice for ignoring the return value[1]
> of the function, but I might misunderstanding his intention, so CC-ing Greg.
> Greg, may I ask your opinion?
> 
> [1] https://lore.kernel.org/linux-mm/YB1kZaD%2F7omxXztF@kroah.com/

Thing is, the correct functioning of the debugfs interfaces is utterly
critical to damon.  And that's apart from these memory leak and
oops-we-killed-damon issues.

So damon simply cannot ignore the state of its debugfs interfaces and
keep going along - because if something goes wrong at the debugfs
layer, damon is dead and useless and the machine needs a reboot.

Perhaps this means that damon should not be using debugfs for its
interfaces at all.  Or it means that the debugfs interfaces are
misdesigned.  I go with the latter, which, alas, also affirms the
former.

From a quick scan it appears that a significant minority (20%?) of
drivers are checking the debugfs_create_dir() return value.