Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CGME20220716081736epcas2p346100e67cf44b1dbb79f6e2a4ab07dbf@epcas2p3.samsung.com>
 <20220716084532.2324050-1-youngmin.nam@samsung.com> <CAK7LNAR3YGoQU6ZTZmC84C1OoH0rPinjoyPDXCD0BDPoRS4NDA@mail.gmail.com>
In-Reply-To: <CAK7LNAR3YGoQU6ZTZmC84C1OoH0rPinjoyPDXCD0BDPoRS4NDA@mail.gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 19 Aug 2022 16:33:00 -0700
Message-ID: <CAKwvOd=FBDqutQ-6De577GDje=YR32GxDbkgcGeP9J=2Lb3CqQ@mail.gmail.com>
Subject: Re: [PATCH] Makefile.extrawarn: add -Wformat-insufficient-args for
 clang build
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Youngmin Nam <youngmin.nam@samsung.com>,
        Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        hosung0.kim@samsung.com, d7271.choe@samsung.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 21, 2022 at 9:22 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Sat, Jul 16, 2022 at 5:17 PM Youngmin Nam <youngmin.nam@samsung.com> wrote:
> >
> > The -Wformat-insufficient-args for clang is useful to detect the situation
> > when the total number is unmatched between format specifiers and arguments.
> >
> > Originally, this option is enabled by default(Link[1]), but it is disabled by
> > -Wno-format explicitly so that we can't detect this unmatched situation.
> >
> > We can enable it by adding this option after -Wno-format.
> >
> > Link[1]: https://releases.llvm.org/13.0.0/tools/clang/docs/DiagnosticsReference.html#wformat-insufficient-args
> > Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com>
> > ---
>
>
> Please let me hold on this patch because
> I'd rather go straight to the removal of  -Wno-format.
>
> https://lore.kernel.org/linux-kbuild/CAFhGd8pk+0XEz0tMiJcwMM7B3NYF=yF4cHW8A-6-81SgpKFPNw@mail.gmail.com/T/#m4becf6ed91f25217b59a840ed1829f36e49fe347

Let's see what the feedback on
https://reviews.llvm.org/D132266 is. If it lands, I will send a series
with this patch first, then wrap it in the else clause of a
conditional like: if clang version >= 16 then enable -Wformat else
enable -Wformat-insufficient-args.

>
>
>
> >  scripts/Makefile.extrawarn | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> > index f5f0d6f09053..c23d7c286bad 100644
> > --- a/scripts/Makefile.extrawarn
> > +++ b/scripts/Makefile.extrawarn
> > @@ -48,6 +48,7 @@ else
> >  ifdef CONFIG_CC_IS_CLANG
> >  KBUILD_CFLAGS += -Wno-initializer-overrides
> >  KBUILD_CFLAGS += -Wno-format
> > +KBUILD_CFLAGS += -Wformat-insufficient-args
> >  KBUILD_CFLAGS += -Wno-sign-compare
> >  KBUILD_CFLAGS += -Wno-format-zero-length
> >  KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
> > --
> > 2.34.0
> >
>
>
> --
> Best Regards
> Masahiro Yamada


-- 
Thanks,
~Nick Desaulniers