Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 16:33:59 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <chao@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, stable@kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix wrong continue condition in GC
Message-ID: <YwAd5wyhXIs1n108@google.com>
References: <20220813143709.11909-1-jaegeuk@kernel.org>
 <65562b32-505f-796e-305a-d1b03baeb388@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65562b32-505f-796e-305a-d1b03baeb388@kernel.org>
Precedence: bulk

On 08/15, Chao Yu wrote:
> On 2022/8/13 22:37, Jaegeuk Kim wrote:
> > We should decrease the frozen counter.
> > 
> > Cc: stable@kernel.org
> > Fixes: 325163e9892b ("f2fs: add gc_urgent_high_remaining sysfs node")
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >   fs/f2fs/gc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index 6da21d405ce1..7e4b41240d59 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -102,7 +102,7 @@ static int gc_thread_func(void *data)
> >   					sbi->gc_urgent_high_limited = false;
> >   					spin_unlock(&sbi->gc_urgent_high_lock);
> >   					sbi->gc_mode = GC_NORMAL;
> > -					continue;
> > +					goto next;
> >   				}
> >   				sbi->gc_urgent_high_remaining--;
> >   			}
> 
> Why not:
> 
> 	if (!sbi->gc_urgent_high_remaining) {
> 		sbi->gc_urgent_high_limited = false;
> 		spin_unlock(&sbi->gc_urgent_high_lock);

Should not call spin_unlock, if so. Anyway, let me send v2.

> 		sbi->gc_mode = GC_NORMAL;
> 	} else {
> 		sbi->gc_urgent_high_remaining--;
> 	}
> 
> Thanks,