Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 Aug 2022 16:41:23 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     gregkh@linuxfoundation.org, rafael@kernel.org,
        akpm@linux-foundation.org, osalvador@suse.de, david@redhat.com,
        andi@firstfloor.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, muchun.song@linux.dev
Subject: Re: [PATCH RESEND] mm: hugetlb: simplify per-node sysfs creation and
 removal
Message-ID: <YwAfo/y/4WqVeBZ1@monkey>
References: <20220819080029.12241-1-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220819080029.12241-1-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IdrZQLQggWdrCjqWRemkxW2y9G4/bpYbr+4h9zWJzMdzS4tKk+iJw8bgVGbh?=
 =?us-ascii?Q?lEUzTp51+jJFKE3Qzd5+fxS/MUVQQjaS/pGPa9rESI3Jt4UV0yWj5uuuXiGI?=
 =?us-ascii?Q?UKko5u/o+9CbBJ8fxEdjHG6NlO0scScJ2U/XX1vO0tTeekFz9GUB+bx6UT82?=
 =?us-ascii?Q?UJMsAHWA/jg6FByE6UdRro95a2EnuvdojsozI/9sy8vF1LtuzJ5z1X7VtZha?=
 =?us-ascii?Q?XicEBOYzIKrdPZB0t4bOjFwdRG9XLDr5rvRFnvUiBGe0lNhq76VqwY0zeIxY?=
 =?us-ascii?Q?JL4J7p3dqSaMAheGCbNvbQMtMMXLLhoADIVZuCs29NK0dAq3k51FEbVFEgTo?=
 =?us-ascii?Q?lziYrSrVo3pxOCTFwDb2XwwTmRXRk/7OzU80TLDb64FalWH5YFrpxJkQaxRU?=
 =?us-ascii?Q?IuHOxd2uIdVmaxox7J4u2r+W6XtTb8kE22PkxEerFgN09K1hNwut0sYTLPre?=
 =?us-ascii?Q?6h410FySVF0HG4NVKzO2ntt7qxIldgNEkPygbFPOWYLDDDAzCoyBCuy1462E?=
 =?us-ascii?Q?jpv4KKlsVTP72hm1et5fY9+FVijpY52Vcz4gfIHkPpBPiR44gcQ2iV747MyM?=
 =?us-ascii?Q?DSjjYkrYRDvKPzx+lU4CmHhit1iv2M+fMvjvCJk2sbhHscBNVGLmwiAunEP3?=
 =?us-ascii?Q?VirJqRx6/ONtFK3l9CGZO12Gkc7xpAJIvYvYeC/CrZRPTN8BvOsTkYr+AkNd?=
 =?us-ascii?Q?Z63rZ7mzgexqVYL5TuD85UDDysEAsfDjbDgUInRqyRWuPusEXXcsCoLAjN6j?=
 =?us-ascii?Q?k9CcgzQaSeIx9TylKOo8C9zgJt67QJ40zcBxbtasUezbXet6m9aNEfynNK9C?=
 =?us-ascii?Q?5eb4ko4/yoPfDGcA7EkbOZxi9OYZ2dEaShagULat9V7oqeW+a/7SaqrOWe3+?=
 =?us-ascii?Q?NsyNA+zQ7lM+LhTMXGJfF5TvdIJICTrc7EwnNjl0sNRIHXzalQIUqZT/rxtJ?=
 =?us-ascii?Q?8g2IKRXn28TuqKRlvtwqdCYMW7GkqXiw/yo+Lnn6aw3cYDMQZ7FPeaqB2bCB?=
 =?us-ascii?Q?t+svHIjDXUAEn+UBPbPlHdKtALEN+l4l8WhD85XcHQn1YUYrykMBACylQPid?=
 =?us-ascii?Q?kyZYDXQuzWmmOeWzaj9Rkw5VoI8H4+yBsBWmsR+eTvpzX2eprn1wOr03dJsd?=
 =?us-ascii?Q?UsRacTxLc0pA2jA6VFuNAQxZMLvePPEfFYFV5Y5jBfb6TdOjRziP/SlsuUCq?=
 =?us-ascii?Q?0VCSriWvAFbwoGmVGE13PxxDsVQ1ECZGiiQxFt7bB1TGFV9sCrz8MhicBUxd?=
 =?us-ascii?Q?087YkhNwLLHNMg6I7W7dDAfZ0bCmeS2nVqzLQ6UfhYuIPa7Eb6nt5niVN9i3?=
 =?us-ascii?Q?voTOiiF0ratFiRFG008X9Lntdy0QWbpalHkkffFC4/BkScWLedyQ9VW2ave5?=
 =?us-ascii?Q?CjYxaosbCoiNMuZW5o+jySVOXrivl8NF2/79KxMo6KI6zdU3aZNbVwkTchfy?=
 =?us-ascii?Q?QB+Ts6qMVZ8xXV9pGUgJU/HoiTBfH0ZeR7jyTRprDQs+o2ExhfkevMAOc0WG?=
 =?us-ascii?Q?sD2pxP9Hife7r8YsHdIzWbvhhA7yohuCqs/VVOKopfTJnjwuu+tNWSiIHayr?=
 =?us-ascii?Q?w1iuhOoan0UU7R1U982H2HsIVk5SnE5+whDt28TYYOM2w0SUpyGBPuOfLkeW?=
 =?us-ascii?Q?Pg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b13979cc-456b-4499-bed6-08da823c553d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2022 23:41:27.0025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HcsOdYF2CHMiAzZ0iW1UVwp2FnB6s7HpdlN+Rd/GlKCOvhasAX9nw0rjjS+rFHX9/CNS31807J33E7Rfo2P5pQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1495
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-19_13,2022-08-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxlogscore=825
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208190088
X-Proofpoint-GUID: x9B14Q8VuwafqHCXMzxxxXYY8uN6VRFu
X-Proofpoint-ORIG-GUID: x9B14Q8VuwafqHCXMzxxxXYY8uN6VRFu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/19/22 16:00, Muchun Song wrote:
> The following commit offload per-node sysfs creation and removal to a kworker and
> did not say why it is needed.  And it also said "I don't know that this is
> absolutely required".  It seems like the author was not sure as well.  Since it
> only complicates the code, this patch will revert the changes to simplify the code.
> 
>   39da08cb074c ("hugetlb: offload per node attribute registrations")
> 
> We could use memory hotplug notifier to do per-node sysfs creation and removal
> instead of inserting those operations to node registration and unregistration.
> Then, it can reduce the code coupling between node.c and hugetlb.c.  Also, it can
> simplify the code.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---

Looking at commit 39da08cb074c, it mentions that other memory register/unregister
handlers use work queues.  That seemed to be true at the time, but those handlers
have been rewritten or no longer exist.  With a quick look, I did not find any
memory notifiers doing so today.

I certainly like decoupling node driver and hugetlb code.  By no means am I an
expert in the hotplug interfaces.  I could not find any issues in moving the
functionality to memory hotplug notification.  FWICT, functionality should be

> 
> Cc Andi per Greg.
> 
>  drivers/base/node.c  | 139 ++-------------------------------------------------
>  include/linux/node.h |  24 ++-------
>  mm/hugetlb.c         |  45 +++++++++++------
>  3 files changed, 36 insertions(+), 172 deletions(-)

Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz