Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp104334rwb; Fri, 19 Aug 2022 18:01:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7Ox8PVAa/aTOViDG8c3J0XPppV2hSuU4m1ApVDrL0S6zYP6U9JyrjERNHKGFt14uTeK3Z7 X-Received: by 2002:a62:6497:0:b0:52e:e0cd:1963 with SMTP id y145-20020a626497000000b0052ee0cd1963mr10455617pfb.58.1660957298679; Fri, 19 Aug 2022 18:01:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660957298; cv=none; d=google.com; s=arc-20160816; b=obRoRLIQifamKXvaDHdPKcGIR0JEwdba0yDeiJqh0g84sRzJYFecdpDHRI0zZIZ9Ya QKnH6p69YpcrSox+/LbZ5W+jjC2Kcbs0bMrIvOWQjd84noPze23vJIQEXgWIn7npW+B9 p1JIvBUWYd0w/Q2XLQYnV7BWsom45jtLDSSY/0/822e72Fu85xTo9gM0cHqrdhJHNN30 8uo7zSSAjxxWrRvXT9sS6Ca1CF5oVXUSiJNv/lHVN6HgEIGHVAZioY3QDJPDzCWFQD45 ou2dOmEboPlQJDITVOBRtCgCECkjCNFkRQF4basz8uTb6B9Vaz5pRU0entpJeVm7OD4R Eo0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=K4p+gNrW7fbruva8rK60CNvrIXqiF+6LNIDdMngLKJg=; b=Iblc+0Xef/paLpz1RylEtyKsU7drEeWPHOcU1NULxt8uhMi3VA0lL4YypG5K1BkIE2 LuDfuJzn3DGuhyZpkcMZd97z+Mks2LNoRMLZxJCZ33PPOrltRMNZ/J4EhKlvJN16lgCp H4+Np5L+eInvjqqYlXAmoSg4FajZS0tzTORgaZRJMTabAY4jD9sdOb0VQHPEECVv+Rpl KMMZNQrRtd7pQ8CfqgxtMuTSYBJjUJly+IF7mtgM+PQjhyJ7tb5WJiufe9l6rngAPbc3 8BM/r/edJuc0BLfWq2t+9phN6srRCARMLLZx8PEETOK0iRlJqF9Bef1lS/quPIzgvklG 5IQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C8aP0vET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x24-20020a17090aca1800b001f8b8d48e3csi2833636pjt.103.2022.08.19.18.01.28; Fri, 19 Aug 2022 18:01:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C8aP0vET; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245356AbiHTAeq (ORCPT + 99 others); Fri, 19 Aug 2022 20:34:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245275AbiHTAek (ORCPT ); Fri, 19 Aug 2022 20:34:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B22BC14; Fri, 19 Aug 2022 17:34:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D1A3DB829A0; Sat, 20 Aug 2022 00:34:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4C8FC433D7; Sat, 20 Aug 2022 00:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660955675; bh=EDb/TDUNl2c98Al1euf0fcsVVMwYWDBPVHtktMfZh6I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C8aP0vETUkZLXwye39N8PdHfiBcyqNtpruSfhvGDI8wnKpyLBntFfgz0nLWAQ29gQ KIcwSC5xZE1xG7VTQBcdNL1jV10Nt4/znPp9wpcWWfumygXOIwWAYCd1YKW3/ncF+l G/88A/5P9FhbiwhOTZ6RwuQaibkIDmTZ9CSG1BcAINoI4cgsHa0k/wrM3B5lWR+RfM Qt/pcAMFJkjndWbv7QjorbAa3bzEcHphWrP7gDXGrgqcQJnrKA1cqQHrxfIYsU4VX0 4jt9O5V6xmH5xQUcfBTa08nJwtVjztKBxIq61WzaBQ5R1cHAMMfTSJd4RQhw8m6aZs vus6rbIRmwgQw== Date: Fri, 19 Aug 2022 17:34:30 -0700 From: Jakub Kicinski To: Tejun Heo , Xin Gao Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, sdf@google.com, daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] core: Variable type completion Message-ID: <20220819173430.20f8653b@kernel.org> In-Reply-To: References: <20220817013529.10535-1-gaoxin@cdjrlc.com> <20220819164731.22c8a3d2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Aug 2022 14:07:26 -1000 Tejun Heo wrote: > On Fri, Aug 19, 2022 at 04:47:31PM -0700, Jakub Kicinski wrote: > > On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote: > > > 'unsigned int' is better than 'unsigned'. > > > > Please resend with the following subject: > > > > [PATCH net-next] net: cgroup: complete unsigned type name > > Out of curiosity, why is 'unsigned int' better than 'unsigned'? Good question, a citation in the commit message would also be good.