Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 20 Aug 2022 09:42:38 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Dongli Zhang <dongli.zhang@oracle.com>
CC:     <linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
        <hch@infradead.org>, <m.szyprowski@samsung.com>,
        <robin.murphy@arm.com>, <jxgao@google.com>,
        <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2] swiotlb: avoid potential left shift overflow
Message-ID: <YwA8DttmM7wgYuHv@gao-cwp>
References: <20220819084537.52374-1-chao.gao@intel.com>
 <38c58aa0-11c7-f553-95fd-292fd4944a75@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <38c58aa0-11c7-f553-95fd-292fd4944a75@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LeDTUs8nF4XzMPY9bn1XRaj52XSHq/fEWEi/IVgOezRVYAgbSFmTQTxy+Q84?=
 =?us-ascii?Q?KFgfUEpssrAenfhNqVSc6+dnUQbHtfINGaSnTOISyukEnVqFsEV9fcw1pOYG?=
 =?us-ascii?Q?y3OFD6sYMDNvGR9pXUddrUt1Nkr9/y7W7aNkgID3T4J5t6Gg5IWjVZPAdssh?=
 =?us-ascii?Q?1bnH0ZDNTIxVj7YFXiGivmmFoKH8ebyuTF54XhSed3cUpVGA2yXJ1tJtgkCu?=
 =?us-ascii?Q?kf/zuZOICyq7stdft1qaS184PI+a4AEjzYCygLKNFnSxnyTIpwx/y1et15k2?=
 =?us-ascii?Q?UclphMdbqbLNe5DVA8A69oaHKIy+pdX+ZAtYwN6cIJ4ffkRU7PaG19lFE30g?=
 =?us-ascii?Q?F3IgP7LApluGbwBkBxwBfcC9i3/KnBVL6B2XjHsodA/FDTQfNVt7URoJEvD4?=
 =?us-ascii?Q?M+MtA92BrCRFO3qr+UvEMaAIf4ODJ3RJ8n7R7L1M/aaTaAAPd0Rq0LPe8V4E?=
 =?us-ascii?Q?WkNT4OO1V4LxnIByLE1bN1DegkuPWbonMfcxTTiPP1QzpoQbYK7uZpX0VhdH?=
 =?us-ascii?Q?VPaFsrJ5qweoDMYLBeHO6wyQgozPRYNqlAXH7BslRMfvCKZ86w7vUQxsm0XM?=
 =?us-ascii?Q?OE/X6DNaApoUptnkgSjQ1KS57tb6rpuvu35RkTtO/KOKuZOCq6JLNd2wpHjF?=
 =?us-ascii?Q?jA+ba9b06MhOiWoSl/SaKMiCbLbOuKoPqd8fCaRC1mO/WEMOdW5lP4tA7irR?=
 =?us-ascii?Q?AKChq9zB7225jru2O6ubS21Of1pyQHM8Qt+ZIwQT/OnlzCNrDgAW4rWrkcOr?=
 =?us-ascii?Q?gTVJrgFlzgu9WvoEp2nWFXYzc2D9f0xum6eO32SyhcB7CEa62UeTmhUK0wIV?=
 =?us-ascii?Q?roRHgaa80v2l2gcgSmx1kZlomSK/x/KrlV8PPQ28A886J5vFns8zuqx8xTFp?=
 =?us-ascii?Q?ZAJAXbcmUTl+HzCL36lNEhTttucnXNFpSltt3tSJpTyV4LZNg/48/lXzcQw6?=
 =?us-ascii?Q?/Cksk/qk2LAg8pq9ooZ8Em4ukIzKCbpEcvNagn+9IZfJOedqWfavST4kZeSB?=
 =?us-ascii?Q?bPbl4wkA6EI5oXOSvol3tMMpyZU1706s6G4knvYwhOwCQ7Dy3T1jwif4VM5j?=
 =?us-ascii?Q?wTrXTT6TiKzTcbd5HYSenE9k3yV0KlW3yvb6YTvoqrPIFZYqdnhA08GTPAFI?=
 =?us-ascii?Q?MRyQ5bRFXpyY+vnUpBELm7n2y8ZEg/iZyzCfZSlSEJhUUGHvogyX/f2HEPsf?=
 =?us-ascii?Q?QLf7N9E/u/WZ1/a8GeEbS++/APd2hLDNlr5xoPPzYtVT1dFawuhHg2x1sD9S?=
 =?us-ascii?Q?Yi6pDlMC++b+2EvNqWW04Z7fxhSilWPRS3M2MW+lRJo3CE4iQ5KBN+8YbMdj?=
 =?us-ascii?Q?fTkoz+tdvaSLkI+oIgdfmE/vUw7ESAdZ2uMtEIGAZaXvJRkamxBt2raJkosF?=
 =?us-ascii?Q?flLpgVbUUFWNh+aDd0aNsI9LfLFxcj3ZAsMqVA35HjWvQhtyKCcZGlIIi0KM?=
 =?us-ascii?Q?g8i2Y7Kb4FtyombqCdncQUFjXGrrRstdFNGZOL3yjcKFRWYNOn6agM/tzzcw?=
 =?us-ascii?Q?hrul8FjaxCT8DZ5l4Edc1MedQbeZOw4fkpQXky9s0l4qgcUmArn3945mAsQM?=
 =?us-ascii?Q?Mo6ozy9vEbmnP+bIbQHs/cWm5NgzdftK/xcgUHox?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d03f04b-8e35-46bb-f36c-08da824d477c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2022 01:42:45.1685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p3DnihihJKvn6KpRc9OQZ39sHQTv6GOCVnPtL17fAte3WDRdJckSId6ygNRa3qdP4o682uIgVXWA92KUh/iZPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1804
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 19, 2022 at 06:44:05AM -0700, Dongli Zhang wrote:
>I also encountered this when sending out another version of the 64-bit swiotlb.
>
>https://lore.kernel.org/all/20220609005553.30954-8-dongli.zhang@oracle.com/
>
>Unfortunately, I could not find an environment (e.g., powerpc) to allocate more
>than 4G until swiotlb supports 64-bit.
>
>Although xen supports 64-bit, but the hypervisor side limits the max to < 4G.

Sorry. I didn't notice your series before. I agree that the overflow
isn't an issue if swiotlb size cannot be larger than 4GB. That's why
I said the overflow is a potential issue.

In an internal effort to measure the impact of swiotlb size to IO
performance of confidential VM (e.g., TDX VM), we simply added
SWIOTLB_ANY to the default io_tlb_mem to lift the restriction on swiotlb
size. Then we hit this issue and worked out this fix. I posted this
fix because I think the fix by itself is helpful because it removes the
implicit dependency of the left-shift in slot_addr() on swiotlb size and
then someone trying to lift the size limitation won't hit the same issue.