Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220819081403.7143-1-zhangqing@loongson.cn> <20220819081403.7143-2-zhangqing@loongson.cn>
 <f9b12eed-a7a0-0f2b-4679-1f465e22cad6@loongson.cn> <20220819125343.1623d850@gandalf.local.home>
 <06575d5e-7451-17ca-b5a8-4153816b3808@loongson.cn>
In-Reply-To: <06575d5e-7451-17ca-b5a8-4153816b3808@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Sat, 20 Aug 2022 10:16:59 +0800
Message-ID: <CAAhV-H4hVhid1=aaP-fDtdvYyJ+yJqkKeznEN5a9zF9S-dHgog@mail.gmail.com>
Subject: Re: [PATCH 1/9] LoongArch/ftrace: Add basic support
To:     Qing Zhang <zhangqing@loongson.cn>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Jinyang He <hejinyang@loongson.cn>,
        Ingo Molnar <mingo@redhat.com>,
        WANG Xuerui <kernel@xen0n.name>, loongarch@lists.linux.dev,
        LKML <linux-kernel@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, all,

On Sat, Aug 20, 2022 at 9:34 AM Qing Zhang <zhangqing@loongson.cn> wrote:
>
>
>
> On 2022/8/20 =E4=B8=8A=E5=8D=8812:53, Steven Rostedt wrote:
> > On Fri, 19 Aug 2022 17:29:29 +0800
> > Jinyang He <hejinyang@loongson.cn> wrote:
> >
> >> It seems this patch adds non-dynamic ftrace, this code should not
> >> appear here.
> >> BTW is it really necessary for non-dynamic ftrace? I do not use it
> >> directly and frequently, IMHO, non-dynamic can be completely
> >>
> >> replaced dynamic?
> >
> > Note, I keep the non dynamic ftrace around for debugging purposes.
> >
> > But sure, it's pretty useless. It's also good for bringing ftrace to a =
new
> > architecture (like this patch is doing), as it is easier to implement t=
han
> > dynamic ftrace, and getting the non-dynamic working is usually the firs=
t
> > step in getting dynamic ftrace working.
> >
> > But it's really up to the arch maintainers to keep it or not.
> >
> Before submitting, I saw that other architectures almost kept
> non-dynamic methods without cleaning up, I tend to keep them.
> How do you think, Huacai. :)
I prefer to keep the non-dynamic method.

Huacai
>
> Thanks,
> - Qing
> > -- Steve
> >
>
>