Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp147780rwa; Sat, 20 Aug 2022 00:39:29 -0700 (PDT) X-Google-Smtp-Source: AA6agR4NEvfMTVDnTweZSgBM4AMwaIX+Iyuin6x0YGC3McuoF5mDAj+XOpmeeb6eRCGVfYmZXs7V X-Received: by 2002:a63:1f1b:0:b0:429:b4be:72f0 with SMTP id f27-20020a631f1b000000b00429b4be72f0mr9052755pgf.622.1660981168723; Sat, 20 Aug 2022 00:39:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660981168; cv=none; d=google.com; s=arc-20160816; b=jGVy7LK59i1OMJe2W5VpprPEj6DtiiQ9PMArOgQa8azPAQyZ4QZRGJ5CPPK8z9IqGS ynOgMsk2F4+Q704cIhmc0lsf5zuq1d7iNfw8FRuPBejOJNRPDRrGnoCRZ6bf0Pn89aTt fAnmuZqTsl78QfZl8ejgORP9hkgGNMoZbgOnTs5GV6zn8zAFkt4afWYU+79vvngCUUjx S3qtpSbxoWnuqk9iE+C/s41KYK+iYX7qMDrzo/UauisHrGpNYvXxiHxCbQ+KqPzRM8kW 3Ppq1fQypPPc/1axUTutqeevPAgAmmUNPD796cOQBA0iuva8r6A9bltzUu0DW2YjDzRC 7Jzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hxId8EXkM6wL6taHhHYAwb9icvQWKyVr7gitqZ85vRA=; b=QCRdoBGzj4AqZW9mbuIb25uVjx2E4r27mPSxdEV4KC+zToVSRd9BOg1cZXh4HbDR23 UMO/wY7mxdBwL5NFIuLjFB669f8qoLkF+388KY52HITMgZ3IK2Rai/S4GQ78pMcqZl+e oIc20zV46UYM5VMotaFCvIKfwt9jYqXKKRnJbbtxAAT6lWDZC9UwYT6/bzrWbkR+Ds3k yIhy80g0s7dnImbOjTdS+/FJNFtFIEVXvdkASyY2FeaPQiHlTU9lGaV8qMSQgG2FuAU4 RQv7tfPV2upKxJAVVMdfee4EO8Z/1WYLzSl8AeJids0QYJM1BrhtY04K0T2TjB1y50r8 TzPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=UJOWq4Gv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a056a00214200b0051840478994si6005771pfk.375.2022.08.20.00.39.16; Sat, 20 Aug 2022 00:39:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=UJOWq4Gv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343849AbiHTHTt (ORCPT + 99 others); Sat, 20 Aug 2022 03:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344129AbiHTHTp (ORCPT ); Sat, 20 Aug 2022 03:19:45 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A0C63FA24; Sat, 20 Aug 2022 00:19:34 -0700 (PDT) X-UUID: bb32a0a51fd245a1ba5952515b431118-20220820 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=hxId8EXkM6wL6taHhHYAwb9icvQWKyVr7gitqZ85vRA=; b=UJOWq4Gvy33zmYhK7KTufvngHXsL/0GawYr8PRLPmHHAECjYIp1XM/0C30jHZhpNoRxDReHE8KHCDvwmITzhMRftdCcNG5VUiCFl+kj6ZNK36bJi2gBjnOWvJ9oJF0iNJVkz2Qo/eI/KtsoUwsQt88Jy4y5kZnIm9Bdki7MluaE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:0e4a0cf7-f31e-40f1-8979-dd046f28e97d,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_ Ham,ACTION:release,TS:0 X-CID-META: VersionHash:84eae18,CLOUDID:63aa12cf-20bd-4e5e-ace8-00692b7ab380,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: bb32a0a51fd245a1ba5952515b431118-20220820 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 33657519; Sat, 20 Aug 2022 15:19:28 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Sat, 20 Aug 2022 15:19:26 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 20 Aug 2022 15:19:26 +0800 From: Jiaxin Yu To: , CC: , , , , , , , Jiaxin Yu Subject: [PATCH] ASoC: mediatek: mt8186: fix DMIC record noise Date: Sat, 20 Aug 2022 15:19:25 +0800 Message-ID: <20220820071925.13557-1-jiaxin.yu@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the first DMIC recording is power down, mtkaif_dmic will be reset. This will cause configuration error in the second DMIC recording. So do not reset mtkaif_dmic except in "MTKAIF_DMIC Switch" kcontrol. Signed-off-by: Jiaxin Yu --- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c index 266704556f37..094402470dc2 100644 --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c @@ -271,9 +271,6 @@ static int mtk_adda_ul_event(struct snd_soc_dapm_widget *w, /* should delayed 1/fs(smallest is 8k) = 125us before afe off */ usleep_range(125, 135); mt8186_afe_gpio_request(afe->dev, false, MT8186_DAI_ADDA, 1); - - /* reset dmic */ - afe_priv->mtkaif_dmic = 0; break; default: break; -- 2.25.1