Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 20 Aug 2022 12:57:09 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     sunliming <sunliming@kylinos.cn>
Cc:     ktsai@capellamicro.com, lars@metafoo.de,
        kai.heng.feng@canonical.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, kelulanainsley@gmail.com,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: light: cm32181: make cm32181_pm_ops static
Message-ID: <20220820125709.7df567c1@jic23-huawei>
In-Reply-To: <20220815012930.150078-1-sunliming@kylinos.cn>
References: <20220815012930.150078-1-sunliming@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 15 Aug 2022 09:29:30 +0800
sunliming <sunliming@kylinos.cn> wrote:

> This symbol is not used outside of cm32181.c, so marks it static.
> 
> Fixes the following sparse warnings:
> >> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'  
> was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>

Applied.  Thanks,
> ---
>  drivers/iio/light/cm32181.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index edbe6a3138d0..001055d09750 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
>  					 cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
>  }
>  
> -DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
>  
>  static const struct of_device_id cm32181_of_match[] = {
>  	{ .compatible = "capella,cm3218" },