Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp338497rwa; Sat, 20 Aug 2022 04:58:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR6UZm9NW+Ck9hgcxqA30xmrA6w8vLfLSHh2ISR98pRTKWqEpVHd7f9pNSSnlVUaLqMkt0jH X-Received: by 2002:a05:6a00:2387:b0:52f:17a0:628c with SMTP id f7-20020a056a00238700b0052f17a0628cmr12237219pfc.17.1660996720823; Sat, 20 Aug 2022 04:58:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660996720; cv=none; d=google.com; s=arc-20160816; b=0M63FNXiqnH2dfzIHT4G6lD5QTY6PvQoOWpt9eh9sYA4gQQ5Odg2yLZtVuk98khax6 RRnSUZJc083ff4OMKb7D92s4zOYJ/E1ewbs9ZHeRZh7ZSNJCMalAA3VjSRAu25ffC+kf aZE1thBDi9seujeqCWaE6xcWyohAdN2UH31fmiJRW1RrZZO5nHY3gHcC18ZL3idfimFg dD7V02IGwLmFj7vzoGEc2bsURZ5sqVauvWg5E4cMKOntO5sjucFwoxH11coKGf0I7HA8 e3E3Y3dUhEzBk+JJX0Le2L6JnYAiGoYNyrijO6J+Az3s+2Cisyx2VMDpg8c62oNnjovM Y6nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/mFWKva9hLr4+jAuplvwuQV5Wd7WKODBw62DtN8J+YY=; b=ML4xki+x5LDco7lrufdF0RfI7V2ZcW+k1UD4CrXP/xv2YxXgZudvaN94nQ3eSPoylv 8lSsp/UDT1JyHo4v3fciKLMz1nvX92qY6kX2jQ2dQk5kTuTTp9JwKbCzXqUAB43TPGj4 VAjBFzlgSo9iN0Q/PzLxwijboW6NYWsBEJ3nmnZli4lnlw8pkd7gWk8tcBH2UFCKemIh eAvFuOzFfPrKcp5nnaEnUeq+nzNoQaOuhMxm+xrgkZ9RqDFn86waRqtnicxA2amEjfiG SH5RH0qXFoqHpSgHZyeeUyN0kGlUlUGsGJtkt+Df+Ynl1vDKGTVVrx4garB1/2XxwZxl njfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fbdj2EXs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a17090301cd00b0016ce8847b4dsi4423690plh.27.2022.08.20.04.58.30; Sat, 20 Aug 2022 04:58:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Fbdj2EXs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345408AbiHTLkS (ORCPT + 99 others); Sat, 20 Aug 2022 07:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242181AbiHTLkQ (ORCPT ); Sat, 20 Aug 2022 07:40:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13B499AFD4; Sat, 20 Aug 2022 04:40:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A79ECB80B8E; Sat, 20 Aug 2022 11:40:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDC45C433D6; Sat, 20 Aug 2022 11:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660995613; bh=EcUHd1SWLgvec3h1hgGjlCxBv5BJzZ8+dzXEcK4LL3Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fbdj2EXsY4W47DuNQ5pBrs0wkqYfIttxu8Uh4cUt34F7eEj9+JPjk1XhmIArNQW0h ZEZaRC5IrMNyZuYPbb4TXco1qb4PmYHmoP92iECSX90nf7uWeMdrwJ5YLkgTwNnFHV aFmUP1mdqCLvJ53HKg62tbIWBY7Reu4MhuDzrPQUnuQoGnRS6+eJRhfijafW4pRNko yke3ohY7AmtQZskcC/mJqsgTjl2AQegCidWKjZBQOCtceF1LfFWigfmz/sa3ENAUVS K8Iow8bv7RaBwm+gkWRKkLX83Zw5tngJx2gl/F/WZOvDAmrNZz8oXjdoz2bHMSINAm Cf+46OVN2FN9g== Date: Sat, 20 Aug 2022 12:50:49 +0100 From: Jonathan Cameron To: Eddie James Cc: Andy Shevchenko , linux-iio , Lars-Peter Clausen , Linux Kernel Mailing List , Joel Stanley Subject: Re: [PATCH v4 2/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt Message-ID: <20220820125049.4e35e721@jic23-huawei> In-Reply-To: References: <20220809211246.251006-1-eajames@linux.ibm.com> <20220809211246.251006-3-eajames@linux.ibm.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Aug 2022 08:59:03 -0500 Eddie James wrote: > On 8/12/22 17:13, Andy Shevchenko wrote: > > On Wed, Aug 10, 2022 at 12:12 AM Eddie James wrote: > >> Corruption of the MEAS_CFG register has been observed soon after > >> system boot. In order to recover this scenario, check MEAS_CFG if > >> measurement isn't ready, and if it's incorrect, reset the DPS310 > >> and execute the startup procedure. > > Looks like both patches miss the Fixes tag. Can you add them? > > > Well this isn't really a software fix - there's no identifiable bug in > the driver. Just trying to recover the chip in this observed mystery > scenario. The tag is useful as well for where to backport this to. Probably just tag the driver introduction. Your description makes it clear we aren't finding faults in the driver - just that it didn't cover this undocumented case! Jonathan