Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp436402rwa; Sat, 20 Aug 2022 06:44:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ftOueg6kO1znoXDU9QD4Zsq0C7jFc6Gj4NXmWPOHzj2OWTG7QEvtvrB74xPKqwEgLEfCz X-Received: by 2002:a63:6ac8:0:b0:42a:3638:86ac with SMTP id f191-20020a636ac8000000b0042a363886acmr7191219pgc.582.1661003073971; Sat, 20 Aug 2022 06:44:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661003073; cv=none; d=google.com; s=arc-20160816; b=Re2Tm7m6VoVLg0FgV8zVWOHaA3hue6IPMcHV570I0nc0gnr/NvyDkvL4m0raO96Yh9 +vi7j8jqdV9TmRFL04h+DPu36N8Pn24n5T1sd5MnwiyConcs7RJo70iflbwM8OiHEJPa 0HRoeubee5bLI/pCgB7UkS+k71cIR6N1D1xTXM9aghuIP+DmiPMIMLblFCWWhQ+/yVKT HANeSvXapkYzj7tmUzEFwC3plW6ur0CBaNL/dP46/j341l98GWvANwPcLp1WnNTdroQ0 xPPbJ62/z6FcMSK1mAC4zAmEoDzWm+736H6iuWZ8VKvLkqSro39p3Pf2aa1j4k8eNEY9 rmvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=pyvqBQX7PHmwUkD+kzK/20YnD2vhcnUIvUwtpvVjDak=; b=j4JPHLQSHcdm0vR9DR6SVOHREMBGKVlahZtHEOImXm0CuNVTCMnyLKcmI2r0OOgOnD XhadGfmIaR2vwV5Xglef9nagmcw/VET+dlewyIVPao/8ZWwIEvodsjoZtCzqb9ThBPnS 9z1YW1su09g+Su99Fu1jHSSkDnLprdrMjeOKQYL3gztnHhmMn0yYz0S4Rj+iJ+stLFeX 9AORg3FzW6luKt8LJUxQ3pm6GDYrDPCcWy//zgi+6JhT9bDdWDu+mCsieJ6zkgK8NyjP vnipmBhBdPBUeGXPn4NRw5cEMq6/Ra8Sc2u81gTvfUvfLLwu/QRcKYRVlwH8wrA4/bS6 yZ/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kohlschutter-com.20210112.gappssmtp.com header.s=20210112 header.b=NftAlwsk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l187-20020a6391c4000000b00415bfaddcddsi7032488pge.471.2022.08.20.06.44.22; Sat, 20 Aug 2022 06:44:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kohlschutter-com.20210112.gappssmtp.com header.s=20210112 header.b=NftAlwsk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346326AbiHTM0G (ORCPT + 99 others); Sat, 20 Aug 2022 08:26:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346308AbiHTM0E (ORCPT ); Sat, 20 Aug 2022 08:26:04 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37ADC52FD0 for ; Sat, 20 Aug 2022 05:26:01 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id v7-20020a1cac07000000b003a6062a4f81so5348594wme.1 for ; Sat, 20 Aug 2022 05:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kohlschutter-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=pyvqBQX7PHmwUkD+kzK/20YnD2vhcnUIvUwtpvVjDak=; b=NftAlwskhxmtCVJFb5fh7kneVXZ1G92WgDy0jpvlgWIgzvey3QAkLYh3/caPufj816 OH5TOVSWmpdWp2+60Fokw76l+ze5h3Qd3/NCuEEOo0FfqUFtzxI3LQnKqiOJxVIkXiOc lYyi939FS9LSr0nox39HyYwAOK2huC3EedhaRXXsKrijFd+1koSJEQcZaa6++QuanBMp fCLv432XbnpEE2+JHaihD+eoSe8UkM1k9OvVvgIWSYqeF7rC4t/jV07/TNKIAJh7/Nwr duSLKADuNZ8QT+K7vH/ygdyOJVsj/ew2bt78T0YITMSGNHh+BCR3RaKYq4FlD4k3gX2w O0dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=pyvqBQX7PHmwUkD+kzK/20YnD2vhcnUIvUwtpvVjDak=; b=0bDrsX6SgoWVOfEScC55+f3B162MApytm+1lS9nyX0nMQB9hNn3joxqJkepKUtjUmy 3YzzCqczG4LkgclqN16F8GYCzvn+jH1x6E+pRGH/AQ+Zut8kF3cFWuIdDGF/qRUJffEF NRaiAMqhMcdB9kWuWE0ISfKJJWAEj6XwQBhgkUhKx5EPPcFEyRgWmNF3fHgq6E/ZskTX PDTs15dgeZsCgjk+3XVp/eI8brm1h0yK2uvUDYAD0lUXTyxCqgqc1q0mqXenQ3dOyGbu 26raDlKWdxTnp3ChzRmWCmC8gZKG5icd6kRn198y/vH1hUUKIiN+KTyvvZCouWjEI9v5 1cJw== X-Gm-Message-State: ACgBeo3Tn5J3n6WJSavq3mYevrytFVcj8Etmtk0cNm7hDYMUmP3Q3qgO gcwWi04HDWZyA/N6MKqEhIoc3zuzxD6JEOBe X-Received: by 2002:a05:600c:4c06:b0:3a5:4eec:eb4b with SMTP id d6-20020a05600c4c0600b003a54eeceb4bmr7557051wmp.151.1660998359654; Sat, 20 Aug 2022 05:25:59 -0700 (PDT) Received: from p330.kohl.home (ip5b434222.dynamic.kabel-deutschland.de. [91.67.66.34]) by smtp.gmail.com with ESMTPSA id l28-20020a056000023c00b00225213fd4a9sm6484553wrz.33.2022.08.20.05.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Aug 2022 05:25:59 -0700 (PDT) From: =?UTF-8?q?Christian=20Kohlschu=CC=88tter?= To: Matthias Kaehlcke , Liam Girdwood , Mark Brown Cc: =?UTF-8?q?Christian=20Kohlschu=CC=88tter?= , linux-kernel@vger.kernel.org Subject: [PATCH] regulator: core: Remove "ramp_delay not set" debug message Date: Sat, 20 Aug 2022 12:24:54 +0000 Message-Id: <20220820122453.13071-1-christian@kohlschutter.com> X-Mailer: git-send-email 2.36.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message shows up occasionally but in bursts (seen as up 30 times per second on my ODROID N2+). According to Matthias Kaehlcke's comment in 'regulator: core: silence warning: "VDD1: ramp_delay not set"', this message should have been removed after restructuring previous code that assumed that ramp_delay being zero in that function was an error. Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/ Signed-off-by: Christian Kohlschütter --- drivers/regulator/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a5033c6ba01..18fa9206ec2 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev, (new_uV < old_uV)) return rdev->constraints->settling_time_down; - if (ramp_delay == 0) { - rdev_dbg(rdev, "ramp_delay not set\n"); + if (ramp_delay == 0) return 0; - } return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay); } -- 2.36.2