Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220820082606.953886-1-floridsleeves@gmail.com>
In-Reply-To: <20220820082606.953886-1-floridsleeves@gmail.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Sat, 20 Aug 2022 10:19:47 -0400
Message-ID: <CAHC9VhSXMO7FxKAonxowYBCPjPfhhvuAErju8oU8qPgx62tiVw@mail.gmail.com>
Subject: Re: [PATCH v1] selinux/ss/services.c: check the return value of
 audit_log_start() in security_sid_mls_copy()
To:     lily <floridsleeves@gmail.com>
Cc:     selinux@vger.kernel.org, linux-kernel@vger.kernel.org,
        stephen.smalley.work@gmail.com, eparis@parisplace.org,
        cgzones@googlemail.com, michalorzel.eng@gmail.com,
        xiujianfeng@huawei.com, omosnace@redhat.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Aug 20, 2022 at 4:26 AM lily <floridsleeves@gmail.com> wrote:
>
> The function audit_log_start() can fail, so its return value should be
> checked against NULL.
>
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
>  security/selinux/ss/services.c | 3 +++
>  1 file changed, 3 insertions(+)

audit_log_start() can safely return NULL as the audit_log_*()
functions are designed to handle a NULL audit_buffer.  This is an
expected behavior and not a bug.

-- 
paul-moore.com