Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp820138rwa; Sat, 20 Aug 2022 15:47:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR7e/MdwlFX+bsVnOMcwGjaNuHvKp2W/+KcrusZ2RDx0dxZeiiCkhRXaKMUd9OuC7wM+fQlJ X-Received: by 2002:a17:902:e945:b0:16b:f802:1660 with SMTP id b5-20020a170902e94500b0016bf8021660mr13881351pll.7.1661035668692; Sat, 20 Aug 2022 15:47:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661035668; cv=none; d=google.com; s=arc-20160816; b=nkJ7eKnWCrWnuBLki4if65VU1TQzXVMe7KlWyPsL0gvgT9gdTCQdzwthJlJd5JGq5U fQxZPUx8ECrGMNOZy/CRq+FYJYQKHCmLr1Lo0Q042FvSkv7P6Onsu997p5qzAh+LLc+6 9CkzhmwDR9QwBEd+U7MXGQawKQjiQWJ3OZvAxlVx4oc88CtloJxfvJhB1c73PnygcgWv bkeV8o1wR/v2u4nWMaNZFmqYppGbpLaACLpAza7Y6usjJdGloTwhMQ5TFoGABMEBi4g5 znm8/oWWRUkOD1mTiEQJAUUOji82AyCLJS8aAPUoFOzKEJ2xPpG+ut9FWl/A9Rmoy8DN oh0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0jImID30Vp/vYAutmCPaQyC4TRyXEdkw0IIMRl2iUHw=; b=hOdy5ieGVHJhQxG8V30GWAZYPc1Y0oO90DgeC9yvoo/kVzq7Q4Jlm6LGi4lfFdaD8m ejkx0DXw+zZKI3cSw5D1hrVbaGez8pRN117mMx2FjFd1fW2ZyAFVNn7D7NXVxw6ci36d Pi5PsxBS3FwCF+0f5fOMh7ob7KF53nqSqoWuYfTNXOtOyihxgGRDsm/FukRij38Q0/cj tY3W8aUJrbS5ezX84Cc9rMBmg6NAj0z8eSWkcl2fHZ8PRLzvgyUIYthY02Yyju3wZa/2 Bobmp1Ere65OQJwSN/qaZB83YF0k4ml1DBaEGhX3OEC3DFJWkjzNiig4ytvk986bFI9B A4rQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@fe80.eu header.s=20190804 header.b=D1AsLfGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fe80.eu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h20-20020a17090aa89400b001d991dfad30si10251458pjq.153.2022.08.20.15.47.30; Sat, 20 Aug 2022 15:47:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@fe80.eu header.s=20190804 header.b=D1AsLfGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fe80.eu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233992AbiHTWq0 (ORCPT + 99 others); Sat, 20 Aug 2022 18:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiHTWqY (ORCPT ); Sat, 20 Aug 2022 18:46:24 -0400 Received: from mail.base45.de (mail.base45.de [IPv6:2001:67c:2050:320::77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4976D222BC; Sat, 20 Aug 2022 15:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fe80.eu; s=20190804; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0jImID30Vp/vYAutmCPaQyC4TRyXEdkw0IIMRl2iUHw=; b=D1AsLfGkGFO8vKorMpoTaWZNsl NANJ1QhSUExJ4IgqmDEx4TmgJNkg4zENBdhHel9qsdWmJMXdqszgq0lGTz7kg1wQuymdB9Z18kSYM UBqzqtQudV27B3yxvlqGCpxOoKMlm0Rg00P5QWYW1KG+h2a9XR1hL63pBL3F5Mrq0eXilQ4lOO9gy TC7WcZV0w+6g6lZ7jBejGiVBxQl3bKKmfp516Ru/PuKQ/cf5Ls+fuCb//YPSbAfp1Fbx8UT4G/ePz TDkncPoux6+6HeH0O/UnhFCucYveIQJ7qSfB/oK+oUuMgM7/0Cv+2FZ+WgHGCyG49qh8r0/hBQN0n 28+6kYcw==; Received: from [2a02:2454:9869:1a:9eb6:54ff:0:fa5] (helo=cerator.lan) by mail.base45.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oPXE6-00G2sh-4c; Sat, 20 Aug 2022 22:45:58 +0000 From: Alexander Couzens To: Felix Fietkau , John Crispin , Sean Wang , Mark Lee Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Russell King , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Golle , Alexander Couzens Subject: [PATCH 3/4] net: mediatek: sgmii: mtk_pcs_setup_mode_an: don't rely on register defaults Date: Sun, 21 Aug 2022 00:45:37 +0200 Message-Id: <20220820224538.59489-4-lynxis@fe80.eu> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220820224538.59489-1-lynxis@fe80.eu> References: <20220820224538.59489-1-lynxis@fe80.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ensure autonegotiation is enabled. Signed-off-by: Alexander Couzens --- drivers/net/ethernet/mediatek/mtk_sgmii.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c index 782812434367..aa69baf1a42f 100644 --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c @@ -32,12 +32,13 @@ static int mtk_pcs_setup_mode_an(struct mtk_pcs *mpcs) regmap_write(mpcs->regmap, SGMSYS_PCS_LINK_TIMER, SGMII_LINK_TIMER_DEFAULT); + /* disable remote fault & enable auto neg */ regmap_read(mpcs->regmap, SGMSYS_SGMII_MODE, &val); - val |= SGMII_REMOTE_FAULT_DIS; + val |= SGMII_REMOTE_FAULT_DIS | SGMII_SPEED_DUPLEX_AN; regmap_write(mpcs->regmap, SGMSYS_SGMII_MODE, val); regmap_read(mpcs->regmap, SGMSYS_PCS_CONTROL_1, &val); - val |= SGMII_AN_RESTART; + val |= SGMII_AN_RESTART | SGMII_AN_ENABLE; regmap_write(mpcs->regmap, SGMSYS_PCS_CONTROL_1, val); /* Release PHYA power down state -- 2.35.1