Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755988AbXFLMSh (ORCPT ); Tue, 12 Jun 2007 08:18:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754594AbXFLMS1 (ORCPT ); Tue, 12 Jun 2007 08:18:27 -0400 Received: from out4.smtp.messagingengine.com ([66.111.4.28]:42564 "EHLO out4.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531AbXFLMSZ (ORCPT ); Tue, 12 Jun 2007 08:18:25 -0400 X-Sasl-enc: dFU/f+q27TSqHTPTkywKBbHeotYF8pwkICVDJpxcWUWU 1181650704 Date: Tue, 12 Jun 2007 09:18:19 -0300 From: Henrique de Moraes Holschuh To: Matthew Garrett Cc: Arjan van de Ven , Jeff Garzik , Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , Kristen Carlson Accardi , james.bottomley@steeleye.com, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, htejun@gmail.com Subject: Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers. Message-ID: <20070612121819.GA20408@khazad-dum.debian.net> References: <20070611184146.448266229@intel.com> <20070611114839.907bcae2.kristen.c.accardi@intel.com> <20070612011148.GA9808@khazad-dum.debian.net> <466DF3E9.30303@linux.intel.com> <466DFE09.3020408@garzik.org> <20070612035928.GB9808@khazad-dum.debian.net> <466E1A32.90306@linux.intel.com> <20070612090940.GA9719@srcf.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070612090940.GA9719@srcf.ucam.org> X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 28 On Tue, 12 Jun 2007, Matthew Garrett wrote: > On Mon, Jun 11, 2007 at 08:59:46PM -0700, Arjan van de Ven wrote: > > that's a temporary shortcoming; even with these power savings you can > > do hotplug as long as you're willing to poll for it at a reasonable > > interval and are willing to wait the time between polls for a hotplug > > to take effect.. > > On laptops, I suspect that we'll probably get an ACPI interrupt even if > the AHCI hotplug pathway can't manage. As long as we don't crash the drive or AHCI controller because we hotplugged it in a way it didn't like (like trying to hotplug a ICH5R would cause). It is not like 1Hz would not be fast enough for laptop bays and docks, so the polling frequency would not be a problem. I still prefer when levels and on/off are kept separate, but if it won't stand in the way of hotplug, I certainly don't care enough to bother. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/