Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp1043962rwa; Sat, 20 Aug 2022 22:56:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR4+7oqnwPMcgai6mlOsL6crMHU972wBQqL5ptkCbmUqtazNytp66KvMXNLNHngJ8iN9mlOZ X-Received: by 2002:a63:4948:0:b0:41c:1e55:7efa with SMTP id y8-20020a634948000000b0041c1e557efamr12751700pgk.555.1661061399203; Sat, 20 Aug 2022 22:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661061399; cv=none; d=google.com; s=arc-20160816; b=IDYfk0xoBMOvLn7WlrgJ98Y+hVA1314c5SvA/HsCeNN7UqCDGcSqhSL7+91AuJMg1e y5fChGdHgVcKlMh2xR0iPXCx9W/HOHaHZnwy4aRhQ4j9VXZo1VCedNlhrkW0QhTRjTrJ S0wF1cbZd+a/O28AULLNMKOMLBx1vEKXwEAGu3be3FAWBIAyGgOrtefxbSsPcUaJHXDK AievhbYZ3UfA4kmaMi/Xw8frLBlsZGPp8acN9feR9dZfda6yEH7563TkY/TIADuRSVjJ 2RTOCMiZMhF9CpGDgVz1MsjMeLKoDooW7D92oOMVVQOrLRQ0by5FMr/Q5TBXQkPYX6l1 F3Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lURQ8F7BGFS7aLjKoi+mm1vzhPa6mY4vW57qU3+4Ha4=; b=wGZr/FuI6779A4ryzRLAFbcJ6BGpJE266g/Y919SvLeotNuZw5btgsq6rHsX+yzXcn 9i37DPO8Cbrgs48UkwTbQyJA470ruLYgU5pTnRty9Cy0BtPTDgwZFV3rOYapPBGhLFRi V/XWLXNT9iyEGLOnXVl6rc2BsItD9H62lisoKHH9YotxB9aSIqxDMFSH5uUyqIiTqAHi seznekt8mnv7a6z9jUhQ9CErnmbQ5Z107j9mYJISZFz5V28YLp+7elu9xydjVgP/LRHN ziG35IRwWEYCWGw10rw0rdin7thitSqZ0y4cAcmUzc7FGRfric4pt0tGDLPuUeT3WdfC 4fQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cm2-20020a17090afa0200b001f27babb6fbsi7995080pjb.56.2022.08.20.22.56.24; Sat, 20 Aug 2022 22:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229505AbiHUFqH (ORCPT + 99 others); Sun, 21 Aug 2022 01:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiHUFqG (ORCPT ); Sun, 21 Aug 2022 01:46:06 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C85F1D326 for ; Sat, 20 Aug 2022 22:46:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6548468C4E; Sun, 21 Aug 2022 07:46:02 +0200 (CEST) Date: Sun, 21 Aug 2022 07:46:02 +0200 From: Christoph Hellwig To: "Fabio M. De Francesco" Cc: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Chaitanya Kulkarni , Keith Busch , Ira Weiny Subject: Re: [PATCH v2] nvmet-tcp: Don't kmap() pages which can't come from HIGHMEM Message-ID: <20220821054602.GA25754@lst.de> References: <20220817184519.25141-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220817184519.25141-1-fmdefrancesco@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This introduced tons of pointless over 80 character lines, please stick to a proper coding style. Also or in-kernel I/O wouldn't it make more sense to use a BVEC iter insted of a KVEC if we have the pages anyway? Or does networking not support them properly?