Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp1094560rwa;
        Sun, 21 Aug 2022 00:27:23 -0700 (PDT)
X-Google-Smtp-Source: AA6agR68R1FIXW2iA7a3uIOjb4lodDOTH9d+pf0q4dhADxHgeeo1C+Jb9apeMmkJOOHDjzUoacYF
X-Received: by 2002:a63:1f1b:0:b0:429:b4be:72f0 with SMTP id f27-20020a631f1b000000b00429b4be72f0mr12284624pgf.622.1661066843492;
        Sun, 21 Aug 2022 00:27:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1661066843; cv=none;
        d=google.com; s=arc-20160816;
        b=fmRGqiyuDGYEXsBNqjALWxsmUjjwMum9jcOrwiExQcZEiJsyPBqZ7+CkHRunj0Y375
         GnegGOdFiKGy5fcj6IxtWQ5HvU/r6S2X3acGFPKckBjbLfXqutqKAnm83Mb+RFvbhcru
         bS5mRLnrRmjUOAV944jqa4e4LWSRjSFxYQcJzOaeTScfBYuznHB/Wc3GhUp+VcCz8aPz
         cqcYZzPblaC6Kn5Ia+ADWKWxK9GG5tzU/Bvk3oghhKCiZGNdXVVGGFM4wOFscG89RQCW
         hZz0NUNEr2QIPNggwf3uUnRfdp2w4K9JkZRz3DEanc+8T10k1i5xsrr7NCSZCF4IpM7d
         7ojA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=nQM4oPZzphwSDtvEtGpl2bA0fG0oLY3le8thgzAQhNg=;
        b=rF0Xt6zsgYjDs5WWeo2L0JMxI8T3d8o+7ilHQ0KS+Q4S3bQXVD4SN3HoCB2d9t1Zet
         1ZPu2mvZGhVGF2kOimocsMj5DC3L8UYBHLARx5aOVU/mqwHn4WCq36chPNrtHd4KCd8y
         sOpjG4OASteCE2FTG3wd0fAHX24084ky2t6fISkOgglzgPuy+LpQHxwDNE3GJD6ogdd9
         FwYoNMfmAhdOt0dSpfPMVbwCkyrgcKndTQPdJE4YEiXByEVg6QqsvE4qzBaf7uNPbUwj
         tXUGacnMooebMhIN3UoNlZa8c8M3FNvvkNM/CKQ8e2+1vdlbk/cQjE0mNq1N1+wt9PYu
         T9ww==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JkBhF3nr;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id e8-20020a656488000000b0041da5a05f4csi9832494pgv.526.2022.08.21.00.27.11;
        Sun, 21 Aug 2022 00:27:23 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JkBhF3nr;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229618AbiHUGy7 (ORCPT <rfc822;andreqb@gmail.com> + 99 others);
        Sun, 21 Aug 2022 02:54:59 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46052 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229379AbiHUGyz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 Aug 2022 02:54:55 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8228F1D30F
        for <linux-kernel@vger.kernel.org>; Sat, 20 Aug 2022 23:54:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=nQM4oPZzphwSDtvEtGpl2bA0fG0oLY3le8thgzAQhNg=; b=JkBhF3nreFwoDyib/sG7ENabdx
        k1OH4BrKOFhNgvArnk8jflKPqMmepsbcKLRKbrMOzyefREECHQ+Z9RpxfesTxBwS3scFav+XbbCYa
        ziJLi8YLh1xEG6QcZ4PLKiBgzVAOxFEF/+nanDmU0sXUaKtUXEl1NnGhjeeGJuhYmTjrkjQzbgn+Z
        CbTu5OsA+o3IgGYU86+2J+G1apP3lg7jZzOEbk0929IeKT8vS07hIZLVQes2frPFBQ+NOx++uyQNO
        Q0APSZhun1pSiXyU+dgbDyg51DWXm6UAwduXkwpKVHNhJNkHkErgRCGCyWDsFBqWnO6mRLelWjckL
        k6zX/QtA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1oPerG-006zaX-KB; Sun, 21 Aug 2022 06:54:54 +0000
Date:   Sat, 20 Aug 2022 23:54:54 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, hch@infradead.org,
        agordeev@linux.ibm.com, wangkefeng.wang@huawei.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and
 page prot
Message-ID: <YwHWvjoZF1V4FSlW@infradead.org>
References: <20220820003125.353570-1-bhe@redhat.com>
 <20220820003125.353570-3-bhe@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220820003125.353570-3-bhe@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot);
> +void __iomem *
> +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val);

It seems a bit odd to do this in two steps vs just doing the entire
change in the first patch.  Any good reason for that?