Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220821141819.3804-1-jszhang@kernel.org>
In-Reply-To: <20220821141819.3804-1-jszhang@kernel.org>
From:   Guo Ren <guoren@kernel.org>
Date:   Sun, 21 Aug 2022 22:37:53 +0800
Message-ID: <CAJF2gTTTWP1sWmYgUgJnqwkOhB9F_wOPTGywucvXbjZdrcHdHQ@mail.gmail.com>
Subject: Re: [PATCH] riscv: compat: s/failed/unsupported if compat mode isn't supported
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Aug 21, 2022 at 10:27 PM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> When compat mode isn't supported(I believe this is the most case now),
> kernel will emit somthing as:
> [    0.050407] riscv: ELF compat mode failed
>
> This msg may make users think there's something wrong with the kernel
> itself, replace "failed" with "unsupported" to make it clear. In fact
Acked-by: Guo Ren <guoren@kernel.org>

> this is the real compat_mode_supported meaning. After the patch, the
> msg would be:
> [    0.050407] riscv: ELF compat mode unsupported
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  arch/riscv/kernel/process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c
> index ceb9ebab6558..b0c63e8e867e 100644
> --- a/arch/riscv/kernel/process.c
> +++ b/arch/riscv/kernel/process.c
> @@ -105,7 +105,7 @@ static int __init compat_mode_detect(void)
>         csr_write(CSR_STATUS, tmp);
>
>         pr_info("riscv: ELF compat mode %s",
> -                       compat_mode_supported ? "supported" : "failed");
> +                       compat_mode_supported ? "supported" : "unsupported");
>
>         return 0;
>  }
> --
> 2.34.1
>


-- 
Best Regards
 Guo Ren