Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b189372-b855-bedc-779a-a834ddbab8d6@axentia.se>
Date:   Sun, 21 Aug 2022 16:45:18 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] mtd: rawnand: atmel: Unmap streaming DMA mappings
Content-Language: en-US
To:     Thorsten Leemhuis <regressions@leemhuis.info>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc:     nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
        claudiu.beznea@microchip.com, bbrezillon@kernel.org,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
References: <20220728074014.145406-1-tudor.ambarus@microchip.com>
 <f041e45a-679c-5633-f855-9be0974d0086@leemhuis.info>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <f041e45a-679c-5633-f855-9be0974d0086@leemhuis.info>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCtpZTZOTXJHQ3AxMGJaQ01idU42cVdUWnVpemJxZTNhMWllaVF3VjJybnpM?=
 =?utf-8?B?RGJnbjg0VTFsK2hNVFFVcyt5OHYxL244aGRnUDdIOE9oSzFlSnVHUnZmVGJm?=
 =?utf-8?B?MEVvKzg4NS83UTc3MDBWcVdrTHJTWlY5UlB5Vm0rblRTMXJiTStNRlJ3RDNM?=
 =?utf-8?B?Y0UxQzZiaTdzMW5yY3Q0ejJTejNGa01ZNjI0ZS9hQXVVTGVqRE9xZXJBdTdS?=
 =?utf-8?B?T0I3NlAybUR2MzZCa1RwcVlzNVZ3TVo1eHNoa1JqZmN5T0FUbjc4bnZvZTY0?=
 =?utf-8?B?Q1owY0JRMGtqRlV5UzE1dVFzQmFlN2ZQT3ZTL2wvYjQ3QWRWSW5ibkp2UEJD?=
 =?utf-8?B?V2ZFYTBPcTRDU0laSUhYenlRTTBhcUs0dGczd1czcERmRm9VdHA4R05HT0w5?=
 =?utf-8?B?UDlFc25iU2J0MzRoeVA3eFJCYjBrMGNxVW12YzFHYjk1bnMvaE1LZ1pUUkRu?=
 =?utf-8?B?Z0RYdUVVWWFsRXV3eDhLZkl1SU1aeml0VXZCSjduYjBIVk5IZWxVeGZkYTA1?=
 =?utf-8?B?QklLNndhazNqSDNpWHBhTkpUWjRPUDE5R3F2VGxWTW5ibnd3bU41NFdDVEU3?=
 =?utf-8?B?R0ozU0RwRVIwSGdGUDhzeHNFR1A3KzNMamc0SVBuRjFjNmRyM1BKOEp3aDY2?=
 =?utf-8?B?ZUFPUVdWTU5CTGs2ZVFMaS95WGpERDR5WUppVjRmZjdBQktHb245WW5jbGFh?=
 =?utf-8?B?RUF5cE1hUkE0OHo5ZllYOVpqdnJIeXhIUkZvUnFBOWVvVWoyNExHSGptWGR6?=
 =?utf-8?B?c3Exdkhic2xSQXpLMDFnRnZuTVdseUZQb2FHTXZiZWU4ZlhHV1dObVltOEJp?=
 =?utf-8?B?QjlEWTJUUGROVXMvVi8ycWwvM3dsR3FiWWMrZkhjMm1hdG9BeG0yNG5CRjFC?=
 =?utf-8?B?eG9HTldYdGIyOHJBa2g1c2dZbWhjZVZNOVFlbmpGNlJvSk1YWmpDUjF6TUl2?=
 =?utf-8?B?ZkdqaVk3RFgyUTBqM0RVQ09veFdiVXFyK04rVVFaVVJONFRSd2kwSElpMnBI?=
 =?utf-8?B?R25BN3JHMDFsdERTdVhyTXBBLzl6bGg2bk1qR01LM21LRkRSL2ZkOWg0eG1K?=
 =?utf-8?B?aXpWQkpYZzBHdFBwZ3RtSWhaOS9lMCtMbHdTTUNLN0diK3BkM2d6UnZDb2pH?=
 =?utf-8?B?aE9LU3hESkk0dEVoUk5sOUVJNmZUejkwdkNpZDM2dzVpRVFsY0o0a0t4Tkov?=
 =?utf-8?B?VC9zMCtHemtQRGtiQlV4U3ZkNHkzWkNRaU82Ukt5bmpiTHRLaWRGRGwzQUM1?=
 =?utf-8?B?WVFZVHFtL3BzdmxwYmZiVGdVR3ZQclZYUSsxbFBVc1Y1ZERDTERXWU1lSlFG?=
 =?utf-8?B?eG14Q0U1LzhhKzZYaERsNm9xZFZsTzBKVnEwOVRoT3dTSHFPWHJRZDBzc3Q4?=
 =?utf-8?B?KzdtK0NRSXcwNExFa2l5bkpLZEMwZkxwTWtYQ1J2WktBeGhvTkxwT00vMkpH?=
 =?utf-8?B?VUtiZE55MjNzQ2duZHE5dW4xNFV3Tnd5VFk3K1JjYXlNbngvM3l4c2diME5y?=
 =?utf-8?B?a0pWVkpGcXdldi9IVkV6YnlaT0xCejZtTEp3UWs0czVMNk9WYWxaT25LejZw?=
 =?utf-8?B?ZHYva000dENNNGVWNmJOWVR0KzZsV3FvMU9lNzNuZjNGTndmM3JQQVR2L3RB?=
 =?utf-8?B?b1dPMEJUM1laQ3I4S041WFh2ZGhkekJrTUg2MTVlVnkyVjIwUGphL0Niakta?=
 =?utf-8?B?akF5Z3hBT0tITE83YTZjNnRXV002eENmZk1GbG94V1h2TDhISXBOdytwNEdu?=
 =?utf-8?B?Mjc4ZEFSajBlT2tzbFptNmh5Qm5CNlUyMjk4UzNhRFFKVG9NUHpKZWMycmNL?=
 =?utf-8?B?UEx2K2R0MHRhYi94YVI1UG5kdG93bmJrZ3VBbVY3OXZBVkhDVStPV1puZ0Er?=
 =?utf-8?B?WlNiSTg0OEUxY3dwVnVEN3dYVVdtc0V1bWYwc3J1NFFLRkpVTCtkanRBWm0y?=
 =?utf-8?B?YnRNb2xSYzV0ZjIwOW5SRjFDTVVEZ3VncVRjUHNyaTROQmppblp2SmdOcnZq?=
 =?utf-8?B?Zkc4VGtaNU8zRTJ3U094RFBXMVVUU0JDdHc2S1lqQVhNQTUrRDVubDNGVkRJ?=
 =?utf-8?B?dFlKa292QWpxWTVGVkRWYUorRHpOaVNrSFI3RWlsazdVM1hNN2V4cEhzUTF4?=
 =?utf-8?Q?4slcoZqycw6amFuzNwtyi7NOb?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 47702db2-7ba8-41b7-f4c8-08da8383bac5
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2022 14:45:02.5711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uq4NmzGXvdMpmwq8QVMQIWI2VDVaIRqzoDd+a85QUAosnvhbB6aK1uVzqinhQbJ+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB4959
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2022-08-17 at 11:28, Thorsten Leemhuis wrote:
> 
> 
> On 28.07.22 09:40, Tudor Ambarus wrote:
>> Every dma_map_single() call should have its dma_unmap_single() counterpart,
>> because the DMA address space is a shared resource and one could render the
>> machine unusable by consuming all DMA addresses.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> 
> This afaics is missing the following tag:
> 
> Link:
> https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@axentia.se/

Indeed, I can confirm that this patch fixes that regression. Yay!

I didn't realize this previously because 1) vacation and 2) many patches
to juggle and I never tried this one on its until this weekend.

Tested-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> These tags are considered important by Linus[1] and others, as they
> allow anyone to look into the backstory weeks or years from now. That is
> why they should be placed in cases like this, as
> Documentation/process/submitting-patches.rst and
> Documentation/process/5.Posting.rst explain in more detail. I care
> personally, because these tags make my regression tracking efforts a
> whole lot easier, as they allow my tracking bot 'regzbot' to
> automatically connect reports with patches posted or committed to fix
> tracked regressions.
> 
> [1] see for example:
> https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/
> https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/
> https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/
> 
> Apropos regzbot, let me tell regzbot to monitor this thread:
> 
> #regzbot ^backmonitor:
> https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@axentia.se/
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> P.S.: As the Linux kernel's regression tracker I deal with a lot of
> reports and sometimes miss something important when writing mails like
> this. If that's the case here, don't hesitate to tell me in a public
> reply, it's in everyone's interest to set the public record straight.