Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 21 Aug 2022 15:49:28 +0000
From:   ThePaulODoom <thepaulodoom@thepaulodoom.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int'
In-Reply-To: <YwHuSyur7AQ7PUsC@kroah.com>
References: <YvxF0yn07ztg9r4A@gus-fring.localdomain> <Yv5SG8XMR2mZGAqG@kroah.com> <Yv7s5dedhRaDlsAC@gus-fring.localdomain> <YwHuSyur7AQ7PUsC@kroah.com>
Message-ID: <BA62DE39-AFED-47BC-964C-8AF150A0B9F1@thepaulodoom.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On August 21, 2022 8:35:23 AM UTC, Greg KH <gregkh@linuxfoundation=2Eorg> =
wrote:
>On Thu, Aug 18, 2022 at 08:52:37PM -0500, Paul Lemmermann wrote:
>> On Thu, Aug 18, 2022 at 04:52:11PM +0200, Greg KH wrote:
>> > On Tue, Aug 16, 2022 at 08:35:31PM -0500, Paul Lemmermann wrote:
>> > > found with checkpatch=2Epl
>> >=20
>> > That is a very sparse changelog text=2E
>> >=20
>> > Why make this change?  Please be descriptive=2E
>> >=20
>> I wanted to make this change to be more fitting with the kernel coding
>> guidelines, and to reduce a WARNING made with checkpatch preferring the
>> use of 'unsigned int' over 'unsigned'=2E With NOMMU_MAP_COPY defined in
>> 'include/linux/fs=2Eh' as an unsigned integer, I felt like the change w=
as
>> fitting=2E I was quickly reminded that the changelog was not properly d=
one,=20
>> and I now understand that, and will learn from my mistake in the future=
=2E
>> As I am a new kernel contributor, and looking to hone my skills, what a=
re=20
>> my next steps?=20
>>=20
>> Should I:
>>=20
>> o Drop the patch and resubmit it,
>> o Simply drop the patch,
>> o Could I change it somehow?,
>> o Or something else?
>
>Try something else=2E  Start out by working in drivers/staging/ on basic
>coding style fixes and other things listed in the drivers/staging/*/TODO
>files=2E  That's the best place for new developers to get started and the=
n

That's what I'll do=2E Again, thank you for being patient and guiding me i=
n the right direction!=20

Many thanks,
- Paul