Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 21 Aug 2022 11:19:10 -0700
From:   Cong Wang <xiyou.wangcong@gmail.com>
To:     lily <floridsleeves@gmail.com>
Cc:     ziw002@eng.ucsd.edu, lizhong@ucsd.edu, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v1] net/ipv6/addrconf.c: Check the return value of
 __in6_dev_get() in addrconf_type_change()
Message-ID: <YwJ3HufZK/784UQc@pop-os.localdomain>
References: <20220820102434.995678-1-floridsleeves@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220820102434.995678-1-floridsleeves@gmail.com>
Precedence: bulk

On Sat, Aug 20, 2022 at 03:24:34AM -0700, lily wrote:
> The function __in6_dev_get() could return NULL pointer. This needs to be
> checked before used in ipv6_mc_remap() and ipv6_mc_unmap(). Otherwise it
> could result in null pointer dereference.

Its caller already checks it:

3689                 if (idev)
3690                         addrconf_type_change(dev, event);
3691                 break;