Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 3/3] hwmon: (dell-smm) Improve warning messages
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
Cc:     jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220821151713.11198-1-W_Armin@gmx.de>
 <20220821151713.11198-4-W_Armin@gmx.de>
 <20220821154610.e2fokkqzytoqm2ba@pali>
From:   Armin Wolf <W_Armin@gmx.de>
Message-ID: <54f18641-a7a3-65f8-1542-369b6652614c@gmx.de>
Date:   Sun, 21 Aug 2022 21:17:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20220821154610.e2fokkqzytoqm2ba@pali>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Precedence: bulk

Am 21.08.22 um 17:46 schrieb Pali Roh=C3=A1r:

> On Sunday 21 August 2022 17:17:13 Armin Wolf wrote:
>> When dell-smm-hwmon is loaded on a machine with a buggy BIOS
>> with the option "force" being enabled, it wrongly prints
>> what the buggy features where disabled. This may cause
>> users to wrongly assume that the driver still protects them
>> from these BIOS bugs even with "force" being enabled.
>> Change the warning message to avoid such a misunderstanding.
> Should not there be also FW_BUG too?

Since the driver itself is unable to detect if a buggy BIOS was fixed,
i would not use FW_BUG here since it may cause confusion if such a message
was printed on an already fixed BIOS.

> I'm thinking more about message, would not it be better to print also
> information if fan support and fan type call is allowed or disallowed
> (based on force argument) when broken BIOS is detected?

Something like "Disabling fan support due to BIOS bugs" and "Enabling fan =
support despite BIOS bugs"?
The first message could only be a notice message, while the second message=
 could be a warning message.

Armin Wolf

>> Tested on a Dell Inspiron 3505.
>>
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>> ---
>>   drivers/hwmon/dell-smm-hwmon.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hw=
mon.c
>> index f7bab1a91b93..bf13852afe48 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1354,13 +1354,13 @@ static int __init dell_smm_probe(struct platfor=
m_device *pdev)
>>   	platform_set_drvdata(pdev, data);
>>
>>   	if (dmi_check_system(i8k_blacklist_fan_support_dmi_table)) {
>> -		dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan suppor=
t\n");
>> +		dev_warn(&pdev->dev, "BIOS has broken fan support\n");
>>   		if (!force)
>>   			data->disallow_fan_support =3D true;
>>   	}
>>
>>   	if (dmi_check_system(i8k_blacklist_fan_type_dmi_table)) {
>> -		dev_warn(&pdev->dev, "broken Dell BIOS detected, disallow fan type c=
all\n");
>> +		dev_warn(&pdev->dev, "BIOS has broken fan type call\n");
>>   		if (!force)
>>   			data->disallow_fan_type_call =3D true;
>>   	}
>> --
>> 2.30.2
>>