Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 21 Aug 2022 19:25:16 +0000
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Molly Sophia <mollysophia379@gmail.com>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl
Message-ID: <bc8380fc-faed-9f99-6d96-3c7c9afc66a1@connolly.tech>
In-Reply-To: <629afd26008c2b1ba5822799ea7ea5b5271895e8.1660903997.git.geert+renesas@glider.be>
References: <629afd26008c2b1ba5822799ea7ea5b5271895e8.1660903997.git.geert+renesas@glider.be>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 19/08/2022 11:14, Geert Uytterhoeven wrote:
> "make dtbs_check" says:
>
>      bias-disable: boolean property with value b'\x00\x00\x00\x00'
>
> Fix this by dropping the offending value.
>
> Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix=
2s")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
> Marked RFC as I do not have the hardware or documentation.
> Perhaps the "bias-disable" property should be dropped instead?

This is correct, the ` =3D <0>` is a downstream style, but it does actually=
 mean to disable the bias
afaik, from downstream docs:

- bias-disable:
=09Usage: optional
=09Value type: <none>
=09Definition: The specified pins should be configued as no pull.


> ---
>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/ar=
m64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index 7747081b98875aad..dba7c2693ff50073 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active {
>   =09=09pins =3D "gpio6", "gpio10";
>   =09=09function =3D "gpio";
>   =09=09drive-strength =3D <8>;
> -=09=09bias-disable =3D <0>;
> +=09=09bias-disable;
>   =09};
>
>   =09sde_dsi_suspend: sde-dsi-suspend {
> --
> 2.25.1
>

--
Kind Regards,
Caleb