Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 10:30:51 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Muchun Song <songmuchun@bytedance.com>,
        Michal Koutn?? <mkoutny@suse.com>,
        Eric Dumazet <edumazet@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        "Sang, Oliver" <oliver.sang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] memcg: increase MEMCG_CHARGE_BATCH to 64
Message-ID: <YwLqW8Bc2CWCJsAE@feng-clx>
References: <20220822001737.4120417-1-shakeelb@google.com>
 <20220822001737.4120417-4-shakeelb@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220822001737.4120417-4-shakeelb@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JvVuy5H6mJLxyXneY9GFTYVev51MHF1TrSIshdH9XUFQo1BsnlLxzJKQFOCZ?=
 =?us-ascii?Q?ONnbLyyyfkaLA2V3LZOlf00jdGpQPaB+UeXrW3ZnJu4LwN4FwjkdfI9veUGB?=
 =?us-ascii?Q?Ge9H7kSuUcxEYFz1Nel0MT4va08YAqod52gp1vbwjqrT0Td3hL6gPq5yAytl?=
 =?us-ascii?Q?TVq4I5l4BS/S6lSGr6AcfpH/YrKhPd7rSLiMz+qbkkdhqk9ME5WocX6+cK2M?=
 =?us-ascii?Q?D9cfrfHblP8kgjhyA6M37b517tPDN7vWkaHg/aCMvYX+DhtW0mCS0VmTz1/A?=
 =?us-ascii?Q?0SVmBX5rHOialVw9TMo1svq+OCuSeU6cMxnZS6vI0ivFVEj7ZIcQThXrt3ls?=
 =?us-ascii?Q?GhrnJYvU9o4hUllNUeVltf4ITtGEYn23QJo12s4X+eFxGRxPmAo8yDNNp2m6?=
 =?us-ascii?Q?2kmoIhj+al2T9dAkKG944H1RcFWOr/LpNvSYbtXFwKLQDqcpKCuTUrpA21pa?=
 =?us-ascii?Q?YpEW2RGUvtXrASFJ9oEnlFzGWsgGkFQQSn9oO3o+3xF2STqi9Wh94wUwPyiP?=
 =?us-ascii?Q?THbaNzrD9peLPVxXtgRf5394UtX/cc/t0LdHPy18KZcy3x/d70ug3cfyoKU/?=
 =?us-ascii?Q?ZELSX2xDrxkIhrB6nNxFS+DOCGbKpcIy2VVVd+wQ9UKHSMkQBC/Uh4v5J0g7?=
 =?us-ascii?Q?uUdsWmNftepH5LThZkU6eVR+ex/m9aYx5gBHqkKf38mEgseLbUUBFyMzIFxF?=
 =?us-ascii?Q?MOSGGdcyQNblO/BAsbph4tSwJa80Z+txtZwI5qeXCfBWh20eJqVOck3rsA+G?=
 =?us-ascii?Q?MzaZmYnQ6mULzZ0gt0THIQH26Ou/YoLuqxDIlgwTcHVxqkSu9Q+hjc1jKuZs?=
 =?us-ascii?Q?AO3cd/OycgWopneis30fk7tqQHy2fcRuOR1G7hFxInLv+P6QsQUIkI1weW5G?=
 =?us-ascii?Q?zHp0PQLfN3M83EXfnjtIpOE9/rhq8oSAanMvw/lbrPOoWA59NV+n6glhXLU4?=
 =?us-ascii?Q?S9cNgmpeVX9pnyDSlxudr6KQo0DcGhizibhwAdTBEWgBIkYMgYdFyN3LFUwD?=
 =?us-ascii?Q?UT+Lm0dFJ/PSkjWkvFmoD5fDAC3h2byrJr2Nx9A4SegfDIjj84vxrsMadHlC?=
 =?us-ascii?Q?g1Qk8hKa+Id6xX92f4hIylGGcN4lPwxmI5ahO6GGsbq8eF2SXWg65i8/I32I?=
 =?us-ascii?Q?A+W4R7TrRrVoW9RojxXxBqZhI8XsAMUkn0VyEvZCCJ4dSffs6aSOx4ouFbCf?=
 =?us-ascii?Q?6ZJVEkGkb5YeBh/w1+Anq5KU0O8F51lU/1Mh0noP7mCzkCkdg7Ba5xiNFhZG?=
 =?us-ascii?Q?iLB+5gxMbd4N2RpAbuucj8Vj+bUQ8m3KWpFqDF0/mYwbRj02jrCdueefFaKO?=
 =?us-ascii?Q?3RARtUwbSwENs18vmDDScKvUTkwHjekh8t1ngYlgcoH66ODF9p929s/fInG5?=
 =?us-ascii?Q?2PGC2cHkluu8X4n4jJn7CfHiQtIDEkpBdsc6USI9oXd/XMhGG/CxB8murH64?=
 =?us-ascii?Q?M6550W/W0Lqk7iRZ/PNsq2gD80BFlgv9mRTFtjQwufLhel8m0jb1RXlNXD/2?=
 =?us-ascii?Q?BUJHwGuuz3inN+MKPi0OLUDys08hjmv/lGD/KFeyP0n6fHgSPclzyQ2gqpkG?=
 =?us-ascii?Q?CRVl6zvpaVGT14fKnyiujKbgzaq+5soKHlQopPIm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 55bc82f2-98ea-4d81-5a2d-08da83e67418
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 02:31:44.1534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ECR4CeuVZiYlOpwO1S+Qr3Jx20gRBrt9iQzIiEghMiT89g/ov2aLB4QZKNJ2EadwxxX9IP4PhAPWSqyqeUt2g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4729
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2022 at 08:17:37AM +0800, Shakeel Butt wrote:
> For several years, MEMCG_CHARGE_BATCH was kept at 32 but with bigger
> machines and the network intensive workloads requiring througput in
> Gbps, 32 is too small and makes the memcg charging path a bottleneck.
> For now, increase it to 64 for easy acceptance to 6.0. We will need to
> revisit this in future for ever increasing demand of higher performance.
> 
> Please note that the memcg charge path drain the per-cpu memcg charge
> stock, so there should not be any oom behavior change.
> 
> To evaluate the impact of this optimization, on a 72 CPUs machine, we
> ran the following workload in a three level of cgroup hierarchy with top
> level having min and low setup appropriately. More specifically
> memory.min equal to size of netperf binary and memory.low double of
> that.
> 
>  $ netserver -6
>  # 36 instances of netperf with following params
>  $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K
> 
> Results (average throughput of netperf):
> Without (6.0-rc1)       10482.7 Mbps
> With patch              17064.7 Mbps (62.7% improvement)
> 
> With the patch, the throughput improved by 62.7%.
> 
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Reported-by: kernel test robot <oliver.sang@intel.com>

This batch number has long been a pain point :) thanks for the work!

Reviewed-by: Feng Tang <feng.tang@intel.com>

- Feng

> ---
>  include/linux/memcontrol.h | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 4d31ce55b1c0..70ae91188e16 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -354,10 +354,11 @@ struct mem_cgroup {
>  };
>  
>  /*
> - * size of first charge trial. "32" comes from vmscan.c's magic value.
> - * TODO: maybe necessary to use big numbers in big irons.
> + * size of first charge trial.
> + * TODO: maybe necessary to use big numbers in big irons or dynamic based of the
> + * workload.
>   */
> -#define MEMCG_CHARGE_BATCH 32U
> +#define MEMCG_CHARGE_BATCH 64U
>  
>  extern struct mem_cgroup *root_mem_cgroup;
>  
> -- 
> 2.37.1.595.g718a3a8f04-goog
>