Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 Aug 2022 10:39:02 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Muchun Song <songmuchun@bytedance.com>,
        Michal Koutn?? <mkoutny@suse.com>,
        Eric Dumazet <edumazet@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        "Sang, Oliver" <oliver.sang@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm: page_counter: remove unneeded atomic ops for
 low/min
Message-ID: <YwLsRqJDRtshKQ1P@feng-clx>
References: <20220822001737.4120417-1-shakeelb@google.com>
 <20220822001737.4120417-2-shakeelb@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220822001737.4120417-2-shakeelb@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gxwu32/9n9ZS2q4ZcFQg0+FrfQkjoFTn92fGHYuZU/VKVYocVHpa2cVo+VNx?=
 =?us-ascii?Q?jRG27YXMXo1dvd4Avce34ZOz32Jhm9+Cshvdm46MpiOFQGQOVsTGKnk7ZzgK?=
 =?us-ascii?Q?KUoht7Hu+EtFnbt29tEWPzawjUkH6PovEJjvMBZYdubz/s+XfPKH/Bp9LRw5?=
 =?us-ascii?Q?YYs/aFpGTvzwavu3JABUq6RLL0IzBaxL6DItC5n+wQqqbAl+P7f88ysctJrx?=
 =?us-ascii?Q?SLtuZ8Jzw+A/KwC7Z7RpyjwfjDgYIZxp9jQqguc/vSEFpLOnMjaOFFgigpkV?=
 =?us-ascii?Q?LUHlgT6iMQDwvVBhvuQbNAQbnvOpX9KkQSckxdtHI27GVhJOQRzS+3rZCYyj?=
 =?us-ascii?Q?XupvW+nGs+PIJ0F6if5JvaEMDEovS9yPWJIi0CNFUpUubGC5fUp1AOWxfT54?=
 =?us-ascii?Q?AklWGdSnFTvJrSurZow0rwvKoiSZCobi7HVQFOR97/trduD9UboOAE1jAxtE?=
 =?us-ascii?Q?D80I/wMyPwDIlNPzeB4ZmOfOEqow4hapqcB1pRS8VVRxAiswI4pXc6E0A2Wa?=
 =?us-ascii?Q?JEvLC39NvtoFMqxr7STrt1vuWGRkyHVroZCn2gyYNouTQBkP9PdYSNN4HH7u?=
 =?us-ascii?Q?42h6yq+6lMu0cjXhP/7fII/lt2w6lhK3eq6DxbTAM5F0oxpmLrhmDZeQCyYR?=
 =?us-ascii?Q?zGfldF0oJFP50GzaDkfTybwMwNA1lLrH7jIVQscnYN2te4T1p2LM+JWkHc+m?=
 =?us-ascii?Q?pZ2N+baX6dc6RlbVqSfXgAeDloMgLm2/Wf5CKms3YhSg4nPoK+DmzQeCwPYe?=
 =?us-ascii?Q?yBgJRVoY2frNNR2SHfdWXgSCD4fchOY8Vbd7Py2bLnU0MhzJiEOfOtIRUgWm?=
 =?us-ascii?Q?EAzS0XEce8Dg9DeUQviR7xpylnaZdzb+E89J9uhjf2QULemnK9XsbaPLacEX?=
 =?us-ascii?Q?VM9deE985OJxTVBI1zY77Q23vQMyEXHDB7j3MObTXvoDlcv4Fji24aAWeMyH?=
 =?us-ascii?Q?rNEUiqYRywS+KHzmof3g1+mOa0IhOk0FPNQj/IexWri+5OoS/NcORZpKTGow?=
 =?us-ascii?Q?170U+Z3j4lU+mRKyjH7Hf4kXiMe3ONzI8LY5iRACAQZy+Rq38Ejg0RglTW7u?=
 =?us-ascii?Q?e0/mVT+Jah8VzRUTAiDuN5Pt33LhR4Y3b2odBQegrBqu8S/I0s5VpbGMuyJT?=
 =?us-ascii?Q?iUDWviAX7RzR+EMRbBjmKHRgsuNxh6MgAStc6rHC+RM1wy+vyuYjjaT/AIYF?=
 =?us-ascii?Q?rA1WvapV3avgaCR5AcCDrQVGvo6vplvQij4f0IhawqWlPK2N9J6zvwGBBCqd?=
 =?us-ascii?Q?axIJ7z0Ti2Y4QdGh5SIq9hhHkTyTIpJBUR/NJZUWHoHZHzJYz18/e6k9XCOJ?=
 =?us-ascii?Q?zoLvd67JH90kphwVz6TNfcUyMK86EW+oFmvLRMm6hGkLCDVModxGXrfzLOuI?=
 =?us-ascii?Q?rx4MWp15d8yXgCmOmuKZH6wpEa022/e1/KZ/46zlLny5opBO89vm3/K3wRtc?=
 =?us-ascii?Q?62SGw00fZb/Yp0VPOdk7D3akwJM+g15eEqplCJ1OsxN5vPDo8pNIqAfeADzP?=
 =?us-ascii?Q?MV5c2OEPn9RmLFaG8kJKgckEqD6ytdOSSmpNQpDJ8SIYYOCSA0hBDyihejyv?=
 =?us-ascii?Q?ZC95BnUmu0NN2Tatg6OjLQc2EwrpCE6bSReXG/yd?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cd7334d1-0c52-4f7e-9cc3-08da83e7921e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2022 02:39:44.0072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 49G4tI0KVqxdzHvQc1EYtlS31zudfecna8rMybI9b8G/SC/OqyYx3VoEsVn0V/l9Xlj63VDmYfmWpZYjFDyTbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1398
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 22, 2022 at 08:17:35AM +0800, Shakeel Butt wrote:
> For cgroups using low or min protections, the function
> propagate_protected_usage() was doing an atomic xchg() operation
> irrespectively. It only needs to do that operation if the new value of
> protection is different from older one. This patch does that.
> 
> To evaluate the impact of this optimization, on a 72 CPUs machine, we
> ran the following workload in a three level of cgroup hierarchy with top
> level having min and low setup appropriately. More specifically
> memory.min equal to size of netperf binary and memory.low double of
> that.
> 
>  $ netserver -6
>  # 36 instances of netperf with following params
>  $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K
> 
> Results (average throughput of netperf):
> Without (6.0-rc1)	10482.7 Mbps
> With patch		14542.5 Mbps (38.7% improvement)
> 
> With the patch, the throughput improved by 38.7%
> 
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Reported-by: kernel test robot <oliver.sang@intel.com>

Reviewed-by: Feng Tang <feng.tang@intel.com>

Thanks!

- Feng

> ---
>  mm/page_counter.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/page_counter.c b/mm/page_counter.c
> index eb156ff5d603..47711aa28161 100644
> --- a/mm/page_counter.c
> +++ b/mm/page_counter.c
> @@ -17,24 +17,23 @@ static void propagate_protected_usage(struct page_counter *c,
>  				      unsigned long usage)
>  {
>  	unsigned long protected, old_protected;
> -	unsigned long low, min;
>  	long delta;
>  
>  	if (!c->parent)
>  		return;
>  
> -	min = READ_ONCE(c->min);
> -	if (min || atomic_long_read(&c->min_usage)) {
> -		protected = min(usage, min);
> +	protected = min(usage, READ_ONCE(c->min));
> +	old_protected = atomic_long_read(&c->min_usage);
> +	if (protected != old_protected) {
>  		old_protected = atomic_long_xchg(&c->min_usage, protected);
>  		delta = protected - old_protected;
>  		if (delta)
>  			atomic_long_add(delta, &c->parent->children_min_usage);
>  	}
>  
> -	low = READ_ONCE(c->low);
> -	if (low || atomic_long_read(&c->low_usage)) {
> -		protected = min(usage, low);
> +	protected = min(usage, READ_ONCE(c->low));
> +	old_protected = atomic_long_read(&c->low_usage);
> +	if (protected != old_protected) {
>  		old_protected = atomic_long_xchg(&c->low_usage, protected);
>  		delta = protected - old_protected;
>  		if (delta)
> -- 
> 2.37.1.595.g718a3a8f04-goog
>